You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/17 06:29:27 UTC
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10468: [Improvement][Api] Interface and entity optimization to improve code scalability (#10466).
zhongjiajie commented on code in PR #10468:
URL: https://github.com/apache/dolphinscheduler/pull/10468#discussion_r899803139
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java:
##########
@@ -231,11 +248,12 @@ public Result updateProcessDefinition(@ApiIgnore @RequestAttribute(value = Const
@RequestParam(value = "tenantCode", required = true) String tenantCode,
@RequestParam(value = "taskRelationJson", required = true) String taskRelationJson,
@RequestParam(value = "taskDefinitionJson", required = true) String taskDefinitionJson,
+ @RequestParam(value = "otherParamsJson", required = false) String otherParamsJson,
@RequestParam(value = "executionType", defaultValue = "PARALLEL") ProcessExecutionTypeEnum executionType,
@RequestParam(value = "releaseState", required = false, defaultValue = "OFFLINE") ReleaseState releaseState) {
Map<String, Object> result = processDefinitionService.updateProcessDefinition(loginUser, projectCode, name, code, description, globalParams,
- locations, timeout, tenantCode, taskRelationJson, taskDefinitionJson,executionType);
+ locations, timeout, tenantCode, taskRelationJson, taskDefinitionJson,otherParamsJson, executionType);
Review Comment:
I wonder why this addition can pass checktyle, i think it is should be a space before `otherParamsJson`
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/python/PythonGateway.java:
##########
@@ -232,6 +230,7 @@ public Long createOrUpdateProcessDefinition(String userName,
int releaseState,
String taskRelationJson,
String taskDefinitionJson,
+ String otherParamsJson,
Review Comment:
This change will fail python API submit function, maybe we should change python integrate test to avoid regression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org