[GitHub] [spark] cloud-fan commented on a change in pull request #30023: [SPARK-33126][SQL] Improve offset window function(Remove direction field)

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #30023:
URL: https://github.com/apache/spark/pull/30023#discussion_r503762036



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -348,16 +348,12 @@ abstract class OffsetWindowFunction
 
   /**
    * (Foldable) expression that contains the number of rows between the current row and the row
-   * where the input expression is evaluated.
+   * where the input expression is evaluated. If `offset` is a positive integer, it means that
+   * the direction of the `offset` is from front to back. If it is a negative integer, the direction
+   * of the `offset` is from back to front.

Review comment:
       what if the offset is 0?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org