You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/12/23 00:45:37 UTC
Review Request 29328: Add option to disable docker containerizer
killing orphans
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Add option to disable docker containerizer killing orphans
Diffs
-----
src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665
src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef
Diff: https://reviews.apache.org/r/29328/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Jan. 7, 2015, 4:13 p.m., Bernd Mathiske wrote:
> > src/slave/containerizer/docker.cpp, line 529
> > <https://reviews.apache.org/r/29328/diff/1/?file=798948#file798948line529>
> >
> > While you are editing this code, you may opt to also make this pre-existing comment more clear. It is somewhat misleading in that the comment seems to cover both parts of this statement, but it only really covers the first clause. Suggestion:
> > "Get the list of all Docker containers (...) and then remove any orphans."
>
> Timothy Chen wrote:
> Hmm, the comment seems to suggest just the first clause? it's getting the list "in order" to remove the orphans. BenH originally wrote this comment I think it's fine as-is.
Or maybe something along the lines of:
// Get the list of all the running containers so that we can remove any orphans that we find.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review67030
-----------------------------------------------------------
On Jan. 9, 2015, 1:20 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 1:20 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp f1b8dfb
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
> On Jan. 7, 2015, 4:13 p.m., Bernd Mathiske wrote:
> > src/slave/containerizer/docker.cpp, line 529
> > <https://reviews.apache.org/r/29328/diff/1/?file=798948#file798948line529>
> >
> > While you are editing this code, you may opt to also make this pre-existing comment more clear. It is somewhat misleading in that the comment seems to cover both parts of this statement, but it only really covers the first clause. Suggestion:
> > "Get the list of all Docker containers (...) and then remove any orphans."
Hmm, the comment seems to suggest just the first clause? it's getting the list "in order" to remove the orphans. BenH originally wrote this comment I think it's fine as-is.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review67030
-----------------------------------------------------------
On Jan. 6, 2015, 10:15 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 10:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665
> src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review67030
-----------------------------------------------------------
Ship it!
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29328/#comment110857>
While you are editing this code, you may opt to also make this pre-existing comment more clear. It is somewhat misleading in that the comment seems to cover both parts of this statement, but it only really covers the first clause. Suggestion:
"Get the list of all Docker containers (...) and then remove any orphans."
- Bernd Mathiske
On Jan. 6, 2015, 2:15 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 2:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665
> src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
> On Jan. 17, 2015, 1:34 a.m., Ben Mahler wrote:
> > Just curious, what happens to the orphans if you don't kill them? Was there a ticket for this?
>
> Timothy Chen wrote:
> the orphans remains untouched. there is a jira ticket for adding this flag, i can fimd it later once im next to a computer
>
> Ben Mahler wrote:
> I understood that part :)
>
> But why is it ok to leave orphans untouched? Sounds like a bug to me.. is there some context I'm missing here?
I think the context is that sometimes it's not desirable to remove all orphans on recovery, especially when the discovery mechanism that a task is launched by Mesos currently is looking for Docker containers with a mesos- prefix (future going to be mesos-{slave_id} which is safer).
We want to leave this optionally so if users like to keep the containers and want to have their own recovery or gc plan we can let them do so.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review68532
-----------------------------------------------------------
On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp a4498e6
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
> On Jan. 17, 2015, 1:34 a.m., Ben Mahler wrote:
> > Just curious, what happens to the orphans if you don't kill them? Was there a ticket for this?
>
> Timothy Chen wrote:
> the orphans remains untouched. there is a jira ticket for adding this flag, i can fimd it later once im next to a computer
>
> Ben Mahler wrote:
> I understood that part :)
>
> But why is it ok to leave orphans untouched? Sounds like a bug to me.. is there some context I'm missing here?
>
> Timothy Chen wrote:
> I think the context is that sometimes it's not desirable to remove all orphans on recovery, especially when the discovery mechanism that a task is launched by Mesos currently is looking for Docker containers with a mesos- prefix (future going to be mesos-{slave_id} which is safer).
> We want to leave this optionally so if users like to keep the containers and want to have their own recovery or gc plan we can let them do so.
Btw this flag is on by default so unless users really want to it's always killing orphan docker container tasks.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review68532
-----------------------------------------------------------
On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp a4498e6
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Ben Mahler <be...@gmail.com>.
> On Jan. 17, 2015, 1:34 a.m., Ben Mahler wrote:
> > Just curious, what happens to the orphans if you don't kill them? Was there a ticket for this?
>
> Timothy Chen wrote:
> the orphans remains untouched. there is a jira ticket for adding this flag, i can fimd it later once im next to a computer
I understood that part :)
But why is it ok to leave orphans untouched? Sounds like a bug to me.. is there some context I'm missing here?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review68532
-----------------------------------------------------------
On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp a4498e6
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
> On Jan. 17, 2015, 1:34 a.m., Ben Mahler wrote:
> > Just curious, what happens to the orphans if you don't kill them? Was there a ticket for this?
the orphans remains untouched. there is a jira ticket for adding this flag, i can fimd it later once im next to a computer
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review68532
-----------------------------------------------------------
On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp a4498e6
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review68532
-----------------------------------------------------------
Just curious, what happens to the orphans if you don't kill them? Was there a ticket for this?
- Ben Mahler
On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp a4498e6
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
> On March 11, 2015, 5:25 p.m., Joerg Schad wrote:
> > src/slave/flags.hpp, line 325
> > <https://reviews.apache.org/r/29328/diff/4/?file=824288#file824288line325>
> >
> > Could you add this flag also the the docs/configuration.md?
This is fixed in a later commit.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review76081
-----------------------------------------------------------
On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp a4498e6
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review76081
-----------------------------------------------------------
src/slave/flags.hpp
<https://reviews.apache.org/r/29328/#comment123483>
Could you add this flag also the the docs/configuration.md?
src/slave/flags.hpp
<https://reviews.apache.org/r/29328/#comment123484>
..containers*.*
- Joerg Schad
On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp a4498e6
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/
-----------------------------------------------------------
(Updated April 7, 2015, 12:28 a.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Bugs: MESOS-2155
https://issues.apache.org/jira/browse/MESOS-2155
Repository: mesos
Description
-------
Add option to disable docker containerizer killing orphans
Diffs
-----
src/slave/containerizer/docker.cpp f9fb078
src/slave/flags.hpp 3da71af
Diff: https://reviews.apache.org/r/29328/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/
-----------------------------------------------------------
(Updated April 7, 2015, 12:26 a.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Repository: mesos
Description
-------
Add option to disable docker containerizer killing orphans
Diffs (updated)
-----
src/slave/containerizer/docker.cpp f9fb078
src/slave/flags.hpp 3da71af
Diff: https://reviews.apache.org/r/29328/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/
-----------------------------------------------------------
(Updated Jan. 17, 2015, 1:26 a.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Changes
-------
rebased
Repository: mesos-git
Description
-------
Add option to disable docker containerizer killing orphans
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 5f4b4ce
src/slave/flags.hpp a4498e6
Diff: https://reviews.apache.org/r/29328/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/
-----------------------------------------------------------
(Updated Jan. 16, 2015, 11:29 p.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Changes
-------
Rebased.
Repository: mesos-git
Description
-------
Add option to disable docker containerizer killing orphans
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 5f4b4ce
src/slave/flags.hpp a4498e6
Diff: https://reviews.apache.org/r/29328/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review67798
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 9, 2015, 1:20 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 1:20 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp f1b8dfb
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 1:20 a.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Repository: mesos-git
Description
-------
Add option to disable docker containerizer killing orphans
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 5f4b4ce
src/slave/flags.hpp f1b8dfb
Diff: https://reviews.apache.org/r/29328/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 10:15 p.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Repository: mesos-git
Description
-------
Add option to disable docker containerizer killing orphans
Diffs
-----
src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665
src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef
Diff: https://reviews.apache.org/r/29328/diff/
Testing (updated)
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 10:14 p.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Repository: mesos-git
Description
-------
Add option to disable docker containerizer killing orphans
Diffs
-----
src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665
src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef
Diff: https://reviews.apache.org/r/29328/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/
-----------------------------------------------------------
(Updated Dec. 22, 2014, 11:47 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Add option to disable docker containerizer killing orphans
Diffs
-----
src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665
src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef
Diff: https://reviews.apache.org/r/29328/diff/
Testing
-------
make check
Thanks,
Timothy Chen