You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "liurenjie1024 (via GitHub)" <gi...@apache.org> on 2023/12/29 06:33:54 UTC
[I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]
liurenjie1024 opened a new issue, #139:
URL: https://github.com/apache/iceberg-rust/issues/139
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #139:
URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-2143674376
> Is there any movement on this one? I see there was a prior PR to close, but it was closed pending upstream releases.
>
> If there's nobody working on it anymore, I would like to take a shot at it if that's okay 👍
>
> For mine/anyone else's reference, is there a preference to using `impl Future<Output = ...>` or maintaining the `async fn` signatures with [`trait_variant`](https://crates.io/crates/trait-variant) crate?
Hi, @jdockerty Thanks for you interest, I think we can go on this work after https://github.com/rust-lang/impl-trait-utils/pull/27 is release on new rust release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]
Posted by "jdockerty (via GitHub)" <gi...@apache.org>.
jdockerty commented on issue #139:
URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-2143505467
Is there any movement on this one? I see there was a prior PR to close, but it was pending upstream changes.
If there's nobody working on it anymore, I would like to take a shot at it if that's okay :+1:
For mine/anyone else's reference, is there a preference to using `impl Future<Output = ...>` or maintaining the `async fn` signatures with [`trait_variant`](https://crates.io/crates/trait-variant) crate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 closed issue #139: refactor: Remove `async_trait` in `Catalog` trait.
URL: https://github.com/apache/iceberg-rust/issues/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #139:
URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-2158450268
I personally do not favor adopting `async in trait` for the `Catalog` API because it compromises object safety. Users will no longer be able to use `Box<dyn Catalog>`. All APIs related to `Catalog` should include generic parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 closed issue #139: refactor: Remove `async_trait` in `Catalog` trait.
URL: https://github.com/apache/iceberg-rust/issues/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #139:
URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-2211090385
I propose closing this issue as it's unlikely we'll remove `async_trait` from `Catalog` until easier methods for implementing object-safe trait objects are available. Additionally, catalog API calls are usually not on the critical path in most of our use cases. Adding such a maintenance burden isn't worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #139:
URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-2211701858
+1, we can close this first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #139:
URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-1905134581
> Could I work on this ? Please tell me what precisely is to be done here?
The release of rust 1.75 enables a fancy feature so that we no longer need to use `async_trait` macro, you can read [this blog](https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html) for reference.
You can also see the `FileWriter` trait in [this pr](https://github.com/apache/iceberg-rust/pull/168/files) as an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]
Posted by "hiirrxnn (via GitHub)" <gi...@apache.org>.
hiirrxnn commented on issue #139:
URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-1903756750
Could I work on this ? Please tell me what precisely is to be done here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org