You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/07/04 10:33:16 UTC
Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is failing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Bugs: CLOUDSTACK-3354
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3354: [automation] scale up VM is failing
Marking default centos template as dynamically_scalable template.
Diffs
-----
setup/db/db/schema-410to420.sql 11204c7
Diff: https://reviews.apache.org/r/12263/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22754
-----------------------------------------------------------
Commit 1e646629fe84fea56371cf75b5f6f05fbdff54a4 in branch refs/heads/master from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1e64662 ]
CLOUDSTACK-3354: Fix scalevm test
After you scale the vm, user is expected (oddly) to update the virtual
machine to signal that the PV tools are installed. This tells cloudstack
that the VM has been successfully scaled up/down.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit c8ad4e5ced323d27862b7197a05f022f1a6efd4f)
- ASF Subversion and Git Services
On July 4, 2013, 8:33 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:33 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3354
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3354: [automation] scale up VM is failing
>
> Marking default centos template as dynamically_scalable template.
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 11204c7
>
> Diff: https://reviews.apache.org/r/12263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22755
-----------------------------------------------------------
Commit c8ad4e5ced323d27862b7197a05f022f1a6efd4f in branch refs/heads/4.2 from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c8ad4e5 ]
CLOUDSTACK-3354: Fix scalevm test
After you scale the vm, user is expected (oddly) to update the virtual
machine to signal that the PV tools are installed. This tells cloudstack
that the VM has been successfully scaled up/down.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On July 4, 2013, 8:33 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:33 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3354
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3354: [automation] scale up VM is failing
>
> Marking default centos template as dynamically_scalable template.
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 11204c7
>
> Diff: https://reviews.apache.org/r/12263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22775
-----------------------------------------------------------
Commit e404d82ad5903016bba28214332c641998bf4aac in branch refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e404d82 ]
CLOUDSTACK-3354: The CentOS built-in is dynamically scalable
Marking default CentOS template as dynamically_scalable template. The
PV tools are installed in our CentOS 5.6 template already.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On July 4, 2013, 8:33 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:33 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3354
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3354: [automation] scale up VM is failing
>
> Marking default centos template as dynamically_scalable template.
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 11204c7
>
> Diff: https://reviews.apache.org/r/12263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22805
-----------------------------------------------------------
Commit d249bc7ce6c35df47705b6cd95eecf8a57de8b49 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d249bc7 ]
CLOUDSTACK-3354: The CentOS built-in is dynamically scalable
Marking default CentOS template as dynamically_scalable template. The
PV tools are installed in our CentOS 5.6 template already.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On July 8, 2013, 6:46 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> -----------------------------------------------------------
>
> (Updated July 8, 2013, 6:46 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3354
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3354: [automation] scale up VM is failing
>
> Marking default centos template as dynamically_scalable template.
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 8130999
>
> Diff: https://reviews.apache.org/r/12263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22804
-----------------------------------------------------------
Commit 800c9e4091e72d1e6d02da3b66c9a9c9120357f5 in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=800c9e4 ]
CLOUDSTACK-3354: The CentOS built-in is dynamically scalable
Marking default CentOS template as dynamically_scalable template. The
PV tools are installed in our CentOS 5.6 template already.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit d249bc7ce6c35df47705b6cd95eecf8a57de8b49)
- ASF Subversion and Git Services
On July 8, 2013, 6:46 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> -----------------------------------------------------------
>
> (Updated July 8, 2013, 6:46 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3354
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3354: [automation] scale up VM is failing
>
> Marking default centos template as dynamically_scalable template.
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 8130999
>
> Diff: https://reviews.apache.org/r/12263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22806
-----------------------------------------------------------
Ship it!
Ship It!
- Prasanna Santhanam
On July 8, 2013, 6:46 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> -----------------------------------------------------------
>
> (Updated July 8, 2013, 6:46 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3354
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3354: [automation] scale up VM is failing
>
> Marking default centos template as dynamically_scalable template.
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 8130999
>
> Diff: https://reviews.apache.org/r/12263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/
-----------------------------------------------------------
(Updated July 8, 2013, 6:46 a.m.)
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Changes
-------
Updated patch to apply on master
Bugs: CLOUDSTACK-3354
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3354: [automation] scale up VM is failing
Marking default centos template as dynamically_scalable template.
Diffs (updated)
-----
setup/db/db/schema-410to420.sql 8130999
Diff: https://reviews.apache.org/r/12263/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On July 4, 2013, 9:06 a.m., Nitin Mehta wrote:
> > setup/db/db/schema-410to420.sql, line 1866
> > <https://reviews.apache.org/r/12263/diff/1/?file=318243#file318243line1866>
> >
> > only for XS ?
Yes. Vmware default template does not have VMWare tools in it.
On July 4, 2013, 9:06 a.m., Harikrishna Patnala wrote:
> > You need to also update templates.sql for fresh installs correct ?
Just after processing create-schema.sql template.sql is processed so new columns won't be get affected at that time.
Anyhow for fresh install/upgrade DB upgrade happens from 41 to 42 so no need to put in template.sql
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22757
-----------------------------------------------------------
On July 4, 2013, 8:33 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:33 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3354
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3354: [automation] scale up VM is failing
>
> Marking default centos template as dynamically_scalable template.
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 11204c7
>
> Diff: https://reviews.apache.org/r/12263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22757
-----------------------------------------------------------
setup/db/db/schema-410to420.sql
<https://reviews.apache.org/r/12263/#comment46453>
only for XS ?
You need to also update templates.sql for fresh installs correct ?
- Nitin Mehta
On July 4, 2013, 8:33 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:33 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3354
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3354: [automation] scale up VM is failing
>
> Marking default centos template as dynamically_scalable template.
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 11204c7
>
> Diff: https://reviews.apache.org/r/12263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by Prasanna Santhanam <ts...@apache.org>.
> On July 4, 2013, 2:52 p.m., Prasanna Santhanam wrote:
> > Hari is correct. The new install base schema will have the flag set to false while the upgrade on server startup will set it to true.
Hari - this patch does not apply on master/4.2. It applies on master-6-17 stable only. Can you resubmit?
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22772
-----------------------------------------------------------
On July 4, 2013, 8:33 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:33 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3354
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3354: [automation] scale up VM is failing
>
> Marking default centos template as dynamically_scalable template.
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 11204c7
>
> Diff: https://reviews.apache.org/r/12263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by Prasanna Santhanam <ts...@apache.org>.
> On July 4, 2013, 2:52 p.m., Prasanna Santhanam wrote:
> > Hari is correct. The new install base schema will have the flag set to false while the upgrade on server startup will set it to true.
>
> Prasanna Santhanam wrote:
> Hari - this patch does not apply on master/4.2. It applies on master-6-17 stable only. Can you resubmit?
Also - I changed the comment in the commit.
The [AUTOMATION] tag is only for the bug report. Often the bug reports do not indicate the root of the problem and/or the investigation you've done. In this case the default built-in was made dynamically scalable by default because PV tools were already present.
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22772
-----------------------------------------------------------
On July 4, 2013, 8:33 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:33 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3354
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3354: [automation] scale up VM is failing
>
> Marking default centos template as dynamically_scalable template.
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 11204c7
>
> Diff: https://reviews.apache.org/r/12263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is
failing
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22772
-----------------------------------------------------------
Ship it!
Hari is correct. The new install base schema will have the flag set to false while the upgrade on server startup will set it to true.
- Prasanna Santhanam
On July 4, 2013, 8:33 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:33 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3354
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3354: [automation] scale up VM is failing
>
> Marking default centos template as dynamically_scalable template.
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 11204c7
>
> Diff: https://reviews.apache.org/r/12263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>