[GitHub] [spark] srowen commented on a diff in pull request #37336: [SPARK-39916][SQL][MLLIB][REFACTOR] Merge ml SchemaUtils to SQL

[GitBox <gi...@apache.org>]

srowen commented on code in PR #37336:
URL: https://github.com/apache/spark/pull/37336#discussion_r934463178


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala:
##########
@@ -297,4 +296,117 @@ private[spark] object SchemaUtils {
       .replaceAll("\u000B", "\\\\v")
       .replaceAll("\u0007", "\\\\a")
   }
+
+  /**
+   * Check whether the given schema contains a column of the required data type.

Review Comment:
   Overall I'm not sure it simplifies things, just moves them around. I'd be neutral on this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org