You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/02/27 00:04:54 UTC

[GitHub] [lucene-solr] andyvuong opened a new pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter

andyvuong opened a new pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter
URL: https://github.com/apache/lucene-solr/pull/1293
 
 
   In shared storage, deletion from the blob store works by listing files beginning with a certain prefix and reading from a blob store requires knowing some or all of the file name.
   
   The sharedShardName, or the identifier prefixing all blob storage files per shard works by concatenating the collection name (uniqueness assumption in solr cloud overall) and the shard name with "_" joining the two. "_" is allowed in collection names which allows for a bug in listing files from other collections unintentionally.
   
   This change changes the delimiter to use "/" which is more consistent with how index files stored in blob are structured anyway <collection identifier>/<index_file_blob_name>. Piggy-backed a minor unrelated test fix in DistributedZkUpdateProcessorTest.java that I missed earlier.
   
   Change Summary
   - Use "/" in sharedShardName
   - Update tests
   - Fix DistributedZkUpdateProcessorTest which tries to delete all collections after every test. In the same cleanup method the entire tmp directory we use as a local blob store gets deleted at the same time so the collection deletion errors out and leaks threads. This is a test setup issue vs a functional one. We spin up a new cluster in the different test cases anyway so we don't need to delete all collections.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] yonik merged pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter

Posted by GitBox <gi...@apache.org>.
yonik merged pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter
URL: https://github.com/apache/lucene-solr/pull/1293
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter

Posted by GitBox <gi...@apache.org>.
mbwaheed commented on a change in pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter
URL: https://github.com/apache/lucene-solr/pull/1293#discussion_r388038676
 
 

 ##########
 File path: solr/core/src/test/org/apache/solr/store/blob/metadata/CorePushPullTest.java
 ##########
 @@ -52,7 +53,7 @@
   private static CoreStorageClient storageClient;
   private static Path localBlobDir;
   
-  private String sharedBlobName = "collectionTest_shardTest";
+  private String sharedBlobName = "collectionTest" + BlobClientUtils.BLOB_FILE_PATH_DELIMITER + "shardTest";
 
 Review comment:
   Minor: use Assign.buildSharedShardName?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] andyvuong commented on issue #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter

Posted by GitBox <gi...@apache.org>.
andyvuong commented on issue #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter
URL: https://github.com/apache/lucene-solr/pull/1293#issuecomment-595431605
 
 
   cc @yonik can you merge. Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org