[jira] [Updated] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

["Areek Zillur (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Areek Zillur updated LUCENE-5404:
---------------------------------

    Attachment: LUCENE-5404.patch

Thanks Michael for the clarification on the API and the pointer to the jira. I understand the concern with the API better now. I will try to come up with something to improve the API in the future, hopefully.

I have attached an updated patch, the changes are as follows:
  - let individual suggesters deal with their count in .store/.load
  - added abstract getCount to Lookup API
  - tests to make sure getCount works
  - left the load/store(Input/OutputStream) for sugar in Lookup API

On a different note, I also see the different options that can be fed in the lookup() for different suggesters, I was thinking an object (LookupOptions?) can be passed instead (which will encapsulate all the params). I think this will make the API 'cleaner' and allow suggester specific options to be passed by just using the Lookup class, Thoughts?  (I will probably just do this separately)

> Add support to get number of entries a Suggester Lookup was built with and minor refactorings
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5404
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5404
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Areek Zillur
>             Fix For: 5.0, 4.7
>
>         Attachments: LUCENE-5404.patch, LUCENE-5404.patch, LUCENE-5404.patch, LUCENE-5404.patch
>
>
> It would be nice to be able to tell the number of entries a suggester lookup was built with. This would let components using lookups to keep some stats regarding how many entries were used to build a lookup.
> Additionally, Dictionary could use InputIterator rather than the BytesRefIteratator, as most of the implmentations now use it.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org