You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "2010YOUY01 (via GitHub)" <gi...@apache.org> on 2024/12/10 17:33:19 UTC

[I] Avoid explicit cast during execution in `corr` aggregate function [datafusion]

2010YOUY01 opened a new issue, #13721:
URL: https://github.com/apache/datafusion/issues/13721

   ### Is your feature request related to a problem or challenge?
   
   Thanks @jayzhan211 for noticing it in https://github.com/apache/datafusion/pull/13581#discussion_r1865684095
   
   Casting of input should be done automatically according to function signature
   For example, the execution logic of `corr` is implemented in float64 type, so when input is int32 or other compatible type, it will automatically convert to Float64
   
   If the casting logic is implemented correctly during planning, we can safely remove the explicit cast, however, if I try to remove it now, the benchmark query mentioned in https://github.com/apache/datafusion/pull/13581 won't run
   
   ### Describe the solution you'd like
   
   1. Remove `cast` and fix the error
   2. Add the regression test
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Avoid explicit cast during execution in `corr` aggregate function [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #13721: Avoid explicit cast during execution in `corr` aggregate function
URL: https://github.com/apache/datafusion/issues/13721


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Avoid explicit cast during execution in `corr` aggregate function [datafusion]

Posted by "kumarlokesh (via GitHub)" <gi...@apache.org>.
kumarlokesh commented on issue #13721:
URL: https://github.com/apache/datafusion/issues/13721#issuecomment-2815807095

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Avoid explicit cast during execution in `corr` aggregate function [datafusion]

Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on issue #13721:
URL: https://github.com/apache/datafusion/issues/13721#issuecomment-2535284332

   Thanks for creating this issue
   
   > If the casting logic is implemented correctly during planning, we can safely remove the explicit cast, however, if I try to remove it now, the benchmark query mentioned in #13581 won't run
   
   That sounds like a bug, right?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Avoid explicit cast during execution in `corr` aggregate function [datafusion]

Posted by "kumarlokesh (via GitHub)" <gi...@apache.org>.
kumarlokesh commented on issue #13721:
URL: https://github.com/apache/datafusion/issues/13721#issuecomment-2816793993

   @2010YOUY01 made an attempt to address this requirement here: https://github.com/apache/datafusion/pull/15776. Please have a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org