[GitHub] [iceberg] rdblue commented on a diff in pull request #7270: AWS: Prevent token refresh scheduling on every sign request

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #7270:
URL: https://github.com/apache/iceberg/pull/7270#discussion_r1156108842


##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -131,6 +135,26 @@ private ScheduledExecutorService tokenRefreshExecutor() {
     return tokenRefreshExecutor;
   }
 
+  @Value.Lazy
+  Cache<String, AuthSession> authSessionCache() {
+    long expirationIntervalMs =
+        PropertyUtil.propertyAsLong(
+            properties(),
+            CatalogProperties.AUTH_SESSION_TIMEOUT_MS,
+            CatalogProperties.AUTH_SESSION_TIMEOUT_MS_DEFAULT);

Review Comment:
   This is 1 hour by default. Are we sure that's a reasonable timeout?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org