You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Aleksey Ignatenko (JIRA)" <ji...@apache.org> on 2007/03/16 11:53:09 UTC
[jira] Created: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
[drlvm][classloader] dead code cleanup in classloader
-----------------------------------------------------
Key: HARMONY-3411
URL: https://issues.apache.org/jira/browse/HARMONY-3411
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Aleksey Ignatenko
Attachments: cl_unloading_cleanup_v2.patch
Dead code cleanup in classloader.
Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reassigned HARMONY-3411:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Assigned To: Gregory Shimansky
> Attachments: cl_unloading_cleanup_v2.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Aleksey Ignatenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482301 ]
Aleksey Ignatenko commented on HARMONY-3411:
--------------------------------------------
I would really apreciate if you state all places where you see it was not cleaned completely.
I see the only one place which is class_unloading_clear_mark_bits function.
My opinion is that this function is to be reused. I intended to add the second version of patch in H-3402 for this. The main idea of H-3402 is that classloaders for methods of active frames are to be enumerated as strong references. If you look at patch in H-3402 there are comments "// force cl classloader to be enumerated as strong reference" - it is the same as cl->Mark(); functionality. So then you can see that class_unloading_clear_mark_bits fucntion is still required to clean mark bits before enumeration(Classloader::m_markBit will state strong enumeration for classloaders from now) and therefore left as is.
This jira and H-3402 are tied actually, and I've not had anough time yet to synchronize them.
So if you think that the old prototype is to be cleaned completely - I understand and can do that (not to mix different parts) and will move this functionality to H-3402. Another way is to make dependency from H-3402 on this jira and use this functionality.
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Assigned To: Gregory Shimansky
> Attachments: cl_unloading_cleanup_v2.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486353 ]
Pavel Pervov commented on HARMONY-3411:
---------------------------------------
The patch is ready for commit.
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Assigned To: Gregory Shimansky
> Attachments: cl_unloading_cleanup_v2.patch, cl_unloading_cleanup_v3.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-3411.
----------------------------------------
Resolution: Fixed
Patch applied at 526221. Please check that it was applied as expected.
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Assigned To: Gregory Shimansky
> Attachments: cl_unloading_cleanup_v2.patch, cl_unloading_cleanup_v3.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-3411.
--------------------------------------
VERIFIED
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Assigned To: Gregory Shimansky
> Attachments: cl_unloading_cleanup_v2.patch, cl_unloading_cleanup_v3.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Aleksey Ignatenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482673 ]
Aleksey Ignatenko commented on HARMONY-3411:
--------------------------------------------
ok, I'll do it this week.
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Assigned To: Gregory Shimansky
> Attachments: cl_unloading_cleanup_v2.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482153 ]
Pavel Pervov commented on HARMONY-3411:
---------------------------------------
AFAIS, not all of the prototype code is removed. Aleksey, could you please explain your point?
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Assigned To: Gregory Shimansky
> Attachments: cl_unloading_cleanup_v2.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482377 ]
Pavel Pervov commented on HARMONY-3411:
---------------------------------------
If it not too much work, I would like to see cleaning up old functionality and adding a new one separated. :)
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Assigned To: Gregory Shimansky
> Attachments: cl_unloading_cleanup_v2.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Aleksey Ignatenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Ignatenko updated HARMONY-3411:
---------------------------------------
Attachment: cl_unloading_cleanup_v2.patch
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Attachments: cl_unloading_cleanup_v2.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Aleksey Ignatenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487499 ]
Aleksey Ignatenko commented on HARMONY-3411:
--------------------------------------------
commited OK, thanks.
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Assigned To: Gregory Shimansky
> Attachments: cl_unloading_cleanup_v2.patch, cl_unloading_cleanup_v3.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Aleksey Ignatenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Ignatenko updated HARMONY-3411:
---------------------------------------
Attachment: cl_unloading_cleanup_v3.patch
updated patch: all old class unloading functionality is cleaned now.
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Assigned To: Gregory Shimansky
> Attachments: cl_unloading_cleanup_v2.patch, cl_unloading_cleanup_v3.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3411) [drlvm][classloader] dead code
cleanup in classloader
Posted by "Aleksey Ignatenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483102 ]
Aleksey Ignatenko commented on HARMONY-3411:
--------------------------------------------
smoke tests passed for with cl_unloading_cleanup_v3.patch on win/lnx IA32.
> [drlvm][classloader] dead code cleanup in classloader
> -----------------------------------------------------
>
> Key: HARMONY-3411
> URL: https://issues.apache.org/jira/browse/HARMONY-3411
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Aleksey Ignatenko
> Assigned To: Gregory Shimansky
> Attachments: cl_unloading_cleanup_v2.patch, cl_unloading_cleanup_v3.patch
>
>
> Dead code cleanup in classloader.
> Classloader contains dead code of the old prototype of class unloading. It is to be removed from drlvm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.