You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cloudstack.apache.org by "ahmedali6 (via GitHub)" <gi...@apache.org> on 2024/06/11 13:48:14 UTC
[PR] fix createVMSchedule action name [cloudstack-www]
ahmedali6 opened a new pull request, #215:
URL: https://github.com/apache/cloudstack-www/pull/215
The action is reboot not restart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix createVMSchedule action name [cloudstack-www]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on code in PR #215:
URL: https://github.com/apache/cloudstack-www/pull/215#discussion_r1634985739
##########
static/api/apidocs-4.19/apis/createVMSchedule.html:
##########
@@ -43,7 +43,7 @@ <h2>Request parameters</h2>
<td style="width:200px;"><strong>Parameter Name</strong></td><td style="width:500px;">Description</td><td style="width:180px;">Required</td>
</tr>
<tr>
- <td style="width:200px;"><strong>action</strong></td><td style="width:500px;"><strong>Action to take on the VM (start/stop/restart/force_stop/force_reboot).</strong></td><td style="width:180px;"><strong>true</strong></td>
+ <td style="width:200px;"><strong>action</strong></td><td style="width:500px;"><strong>Action to take on the VM (start/stop/reboot/force_stop/force_reboot).</strong></td><td style="width:180px;"><strong>true</strong></td>
Review Comment:
I believe to have this change in future releases as well, you may want to raise a PR against the apache/cloudstack repo - https://github.com/apache/cloudstack/blob/main/api/src/main/java/org/apache/cloudstack/api/command/user/vm/CreateVMScheduleCmd.java#L68-L71
which is where this documentation is originally created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix createVMSchedule action name [cloudstack-www]
Posted by "ahmedali6 (via GitHub)" <gi...@apache.org>.
ahmedali6 commented on code in PR #215:
URL: https://github.com/apache/cloudstack-www/pull/215#discussion_r1635334408
##########
static/api/apidocs-4.19/apis/createVMSchedule.html:
##########
@@ -43,7 +43,7 @@ <h2>Request parameters</h2>
<td style="width:200px;"><strong>Parameter Name</strong></td><td style="width:500px;">Description</td><td style="width:180px;">Required</td>
</tr>
<tr>
- <td style="width:200px;"><strong>action</strong></td><td style="width:500px;"><strong>Action to take on the VM (start/stop/restart/force_stop/force_reboot).</strong></td><td style="width:180px;"><strong>true</strong></td>
+ <td style="width:200px;"><strong>action</strong></td><td style="width:500px;"><strong>Action to take on the VM (start/stop/reboot/force_stop/force_reboot).</strong></td><td style="width:180px;"><strong>true</strong></td>
Review Comment:
Done https://github.com/apache/cloudstack/pull/9226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix createVMSchedule action name [cloudstack-www]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #215:
URL: https://github.com/apache/cloudstack-www/pull/215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org