[GitHub] [camel] vpaturet commented on a change in pull request #6413: CAMEL-17185 Add an option for customizing retryable PubSub server errors

[GitBox <gi...@apache.org>]

vpaturet commented on a change in pull request #6413:
URL: https://github.com/apache/camel/pull/6413#discussion_r746485712



##########
File path: components/camel-google/camel-google-pubsub/src/main/java/org/apache/camel/component/google/pubsub/GooglePubsubComponent.java
##########
@@ -87,6 +91,11 @@
               description = "How many milliseconds should a producer be allowed to terminate.")
     private int publisherTerminationTimeout = 60000;
 
+    @Metadata(
+              label = "consumer",
+              description = "Additional retryable error codes for synchronous pull. By default the PubSub client library retries ABORTED, UNAVAILABLE, UNKNOWN")
+    private StatusCode.Code[] synchronousPullRetryableCodes = new StatusCode.Code[0];

Review comment:
       What would be the appropriate Camel exception to throw in case the provided strings cannot be converted to the Enum?
   Since the default error codes and the custom codes are both known at start-up, does it make sense to generate the list of retryable codes at component initialization time? Possibly in the init() method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org