You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jeremy Thomerson (JIRA)" <ji...@apache.org> on 2010/08/06 21:37:17 UTC
[jira] Created: (WICKET-2974) IFeedback that is child of IFeedback
gets added to the FEEDBACK_LIST too late
IFeedback that is child of IFeedback gets added to the FEEDBACK_LIST too late
-----------------------------------------------------------------------------
Key: WICKET-2974
URL: https://issues.apache.org/jira/browse/WICKET-2974
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.9
Reporter: Jeremy Thomerson
Assignee: Jeremy Thomerson
Priority: Trivial
Fix For: 1.4.10
Consider the following scenario:
- I have a BasePage that I add a feedback panel to. I want it to only render feedback messages that have not been rendered by any other feedback panels
- I have a feedback border that implements IFeedback, and inside it, I also have a FeedbackPanel. I want the feedback panel to only render the messages pertaining to the components within the border.
To accomplish this, I put the creation of the feedback panel in the BasePage in onBeforeRender so that my component hierarchy (including the border and it's child feedback panel) is created before I add myself to the hierarchy. By doing this, I expect my page to be the last IFeedback to appear in the feedback list.
But alas, when Component#beforeRender creates the list of IFeedback components, it effectively stops the traversal of any IFeedback#beforeRender calls because it does not call internalBeforeRender().
The attached quickstart demonstrates the problem, and the patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2974) IFeedback that is child of
IFeedback gets added to the FEEDBACK_LIST too late
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896241#action_12896241 ]
Martin Grigorov commented on WICKET-2974:
-----------------------------------------
Merged to 1.5 with r983186
> IFeedback that is child of IFeedback gets added to the FEEDBACK_LIST too late
> -----------------------------------------------------------------------------
>
> Key: WICKET-2974
> URL: https://issues.apache.org/jira/browse/WICKET-2974
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.9
> Reporter: Jeremy Thomerson
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Fix For: 1.4.11
>
> Attachments: quickstart.tar.gz, WICKET-2974.patch
>
>
> Consider the following scenario:
> - I have a BasePage that I add a feedback panel to. I want it to only render feedback messages that have not been rendered by any other feedback panels
> - I have a feedback border that implements IFeedback, and inside it, I also have a FeedbackPanel. I want the feedback panel to only render the messages pertaining to the components within the border.
> To accomplish this, I put the creation of the feedback panel in the BasePage in onBeforeRender so that my component hierarchy (including the border and it's child feedback panel) is created before I add myself to the hierarchy. By doing this, I expect my page to be the last IFeedback to appear in the feedback list.
> But alas, when Component#beforeRender creates the list of IFeedback components, it effectively stops the traversal of any IFeedback#beforeRender calls because it does not call internalBeforeRender().
> The attached quickstart demonstrates the problem, and the patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2974) IFeedback that is child of IFeedback
gets added to the FEEDBACK_LIST too late
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2974.
-----------------------------------
Assignee: Igor Vaynberg (was: Jeremy Thomerson)
Fix Version/s: 1.5-M2
Resolution: Fixed
> IFeedback that is child of IFeedback gets added to the FEEDBACK_LIST too late
> -----------------------------------------------------------------------------
>
> Key: WICKET-2974
> URL: https://issues.apache.org/jira/browse/WICKET-2974
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.9
> Reporter: Jeremy Thomerson
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.4.11, 1.5-M2
>
> Attachments: quickstart.tar.gz, WICKET-2974.patch
>
>
> Consider the following scenario:
> - I have a BasePage that I add a feedback panel to. I want it to only render feedback messages that have not been rendered by any other feedback panels
> - I have a feedback border that implements IFeedback, and inside it, I also have a FeedbackPanel. I want the feedback panel to only render the messages pertaining to the components within the border.
> To accomplish this, I put the creation of the feedback panel in the BasePage in onBeforeRender so that my component hierarchy (including the border and it's child feedback panel) is created before I add myself to the hierarchy. By doing this, I expect my page to be the last IFeedback to appear in the feedback list.
> But alas, when Component#beforeRender creates the list of IFeedback components, it effectively stops the traversal of any IFeedback#beforeRender calls because it does not call internalBeforeRender().
> The attached quickstart demonstrates the problem, and the patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2974) IFeedback that is child of IFeedback
gets added to the FEEDBACK_LIST too late
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-2974:
-------------------------------------
Attachment: quickstart.tar.gz
WICKET-2974.patch
> IFeedback that is child of IFeedback gets added to the FEEDBACK_LIST too late
> -----------------------------------------------------------------------------
>
> Key: WICKET-2974
> URL: https://issues.apache.org/jira/browse/WICKET-2974
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.9
> Reporter: Jeremy Thomerson
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Fix For: 1.4.10
>
> Attachments: quickstart.tar.gz, WICKET-2974.patch
>
>
> Consider the following scenario:
> - I have a BasePage that I add a feedback panel to. I want it to only render feedback messages that have not been rendered by any other feedback panels
> - I have a feedback border that implements IFeedback, and inside it, I also have a FeedbackPanel. I want the feedback panel to only render the messages pertaining to the components within the border.
> To accomplish this, I put the creation of the feedback panel in the BasePage in onBeforeRender so that my component hierarchy (including the border and it's child feedback panel) is created before I add myself to the hierarchy. By doing this, I expect my page to be the last IFeedback to appear in the feedback list.
> But alas, when Component#beforeRender creates the list of IFeedback components, it effectively stops the traversal of any IFeedback#beforeRender calls because it does not call internalBeforeRender().
> The attached quickstart demonstrates the problem, and the patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2974) IFeedback that is child of
IFeedback gets added to the FEEDBACK_LIST too late
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897096#action_12897096 ]
Hudson commented on WICKET-2974:
--------------------------------
Integrated in Apache Wicket 1.5.x #217 (See [http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.5.x/217/])
> IFeedback that is child of IFeedback gets added to the FEEDBACK_LIST too late
> -----------------------------------------------------------------------------
>
> Key: WICKET-2974
> URL: https://issues.apache.org/jira/browse/WICKET-2974
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.9
> Reporter: Jeremy Thomerson
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Fix For: 1.4.11
>
> Attachments: quickstart.tar.gz, WICKET-2974.patch
>
>
> Consider the following scenario:
> - I have a BasePage that I add a feedback panel to. I want it to only render feedback messages that have not been rendered by any other feedback panels
> - I have a feedback border that implements IFeedback, and inside it, I also have a FeedbackPanel. I want the feedback panel to only render the messages pertaining to the components within the border.
> To accomplish this, I put the creation of the feedback panel in the BasePage in onBeforeRender so that my component hierarchy (including the border and it's child feedback panel) is created before I add myself to the hierarchy. By doing this, I expect my page to be the last IFeedback to appear in the feedback list.
> But alas, when Component#beforeRender creates the list of IFeedback components, it effectively stops the traversal of any IFeedback#beforeRender calls because it does not call internalBeforeRender().
> The attached quickstart demonstrates the problem, and the patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2974) IFeedback that is child of
IFeedback gets added to the FEEDBACK_LIST too late
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896137#action_12896137 ]
Jeremy Thomerson commented on WICKET-2974:
------------------------------------------
this is fixed in 1.4.x - not sure if the same problem exists in 1.5 - need to look at some point
> IFeedback that is child of IFeedback gets added to the FEEDBACK_LIST too late
> -----------------------------------------------------------------------------
>
> Key: WICKET-2974
> URL: https://issues.apache.org/jira/browse/WICKET-2974
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.9
> Reporter: Jeremy Thomerson
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Fix For: 1.4.10
>
> Attachments: quickstart.tar.gz, WICKET-2974.patch
>
>
> Consider the following scenario:
> - I have a BasePage that I add a feedback panel to. I want it to only render feedback messages that have not been rendered by any other feedback panels
> - I have a feedback border that implements IFeedback, and inside it, I also have a FeedbackPanel. I want the feedback panel to only render the messages pertaining to the components within the border.
> To accomplish this, I put the creation of the feedback panel in the BasePage in onBeforeRender so that my component hierarchy (including the border and it's child feedback panel) is created before I add myself to the hierarchy. By doing this, I expect my page to be the last IFeedback to appear in the feedback list.
> But alas, when Component#beforeRender creates the list of IFeedback components, it effectively stops the traversal of any IFeedback#beforeRender calls because it does not call internalBeforeRender().
> The attached quickstart demonstrates the problem, and the patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2974) IFeedback that is child of IFeedback
gets added to the FEEDBACK_LIST too late
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2974:
----------------------------------
Fix Version/s: 1.4.11
(was: 1.4.10)
> IFeedback that is child of IFeedback gets added to the FEEDBACK_LIST too late
> -----------------------------------------------------------------------------
>
> Key: WICKET-2974
> URL: https://issues.apache.org/jira/browse/WICKET-2974
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.9
> Reporter: Jeremy Thomerson
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Fix For: 1.4.11
>
> Attachments: quickstart.tar.gz, WICKET-2974.patch
>
>
> Consider the following scenario:
> - I have a BasePage that I add a feedback panel to. I want it to only render feedback messages that have not been rendered by any other feedback panels
> - I have a feedback border that implements IFeedback, and inside it, I also have a FeedbackPanel. I want the feedback panel to only render the messages pertaining to the components within the border.
> To accomplish this, I put the creation of the feedback panel in the BasePage in onBeforeRender so that my component hierarchy (including the border and it's child feedback panel) is created before I add myself to the hierarchy. By doing this, I expect my page to be the last IFeedback to appear in the feedback list.
> But alas, when Component#beforeRender creates the list of IFeedback components, it effectively stops the traversal of any IFeedback#beforeRender calls because it does not call internalBeforeRender().
> The attached quickstart demonstrates the problem, and the patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2974) IFeedback that is child of
IFeedback gets added to the FEEDBACK_LIST too late
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896431#action_12896431 ]
Hudson commented on WICKET-2974:
--------------------------------
Integrated in Apache Wicket 1.4.x #82 (See [http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.4.x/82/])
> IFeedback that is child of IFeedback gets added to the FEEDBACK_LIST too late
> -----------------------------------------------------------------------------
>
> Key: WICKET-2974
> URL: https://issues.apache.org/jira/browse/WICKET-2974
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.9
> Reporter: Jeremy Thomerson
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Fix For: 1.4.11
>
> Attachments: quickstart.tar.gz, WICKET-2974.patch
>
>
> Consider the following scenario:
> - I have a BasePage that I add a feedback panel to. I want it to only render feedback messages that have not been rendered by any other feedback panels
> - I have a feedback border that implements IFeedback, and inside it, I also have a FeedbackPanel. I want the feedback panel to only render the messages pertaining to the components within the border.
> To accomplish this, I put the creation of the feedback panel in the BasePage in onBeforeRender so that my component hierarchy (including the border and it's child feedback panel) is created before I add myself to the hierarchy. By doing this, I expect my page to be the last IFeedback to appear in the feedback list.
> But alas, when Component#beforeRender creates the list of IFeedback components, it effectively stops the traversal of any IFeedback#beforeRender calls because it does not call internalBeforeRender().
> The attached quickstart demonstrates the problem, and the patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2974) IFeedback that is child of
IFeedback gets added to the FEEDBACK_LIST too late
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905691#action_12905691 ]
Hudson commented on WICKET-2974:
--------------------------------
Integrated in Apache Wicket 1.4.x #140 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/140/])
tests for WICKET-2974
these tests were created by mgrigorov in trunk. I'm just porting them to 1.4.x
> IFeedback that is child of IFeedback gets added to the FEEDBACK_LIST too late
> -----------------------------------------------------------------------------
>
> Key: WICKET-2974
> URL: https://issues.apache.org/jira/browse/WICKET-2974
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.9
> Reporter: Jeremy Thomerson
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.4.11, 1.5-M2
>
> Attachments: quickstart.tar.gz, WICKET-2974.patch
>
>
> Consider the following scenario:
> - I have a BasePage that I add a feedback panel to. I want it to only render feedback messages that have not been rendered by any other feedback panels
> - I have a feedback border that implements IFeedback, and inside it, I also have a FeedbackPanel. I want the feedback panel to only render the messages pertaining to the components within the border.
> To accomplish this, I put the creation of the feedback panel in the BasePage in onBeforeRender so that my component hierarchy (including the border and it's child feedback panel) is created before I add myself to the hierarchy. By doing this, I expect my page to be the last IFeedback to appear in the feedback list.
> But alas, when Component#beforeRender creates the list of IFeedback components, it effectively stops the traversal of any IFeedback#beforeRender calls because it does not call internalBeforeRender().
> The attached quickstart demonstrates the problem, and the patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.