[GitHub] [couchdb] rnewson edited a comment on pull request #3795: fix case_clause when HitId and DocId do not match when include_docs=true

[GitBox <gi...@apache.org>]

rnewson edited a comment on pull request #3795:
URL: https://github.com/apache/couchdb/pull/3795#issuecomment-948409540


   I'm worried about any code that tries to mask situations that should not occur.
   
   ``` a clouseau index may become out of sync with the db or
   become corrupt under certain conditions (heap exhaustion, garbage collection).
   ```
   
   The index should only ever be either current or stale. I don't recognise "out of sync" or "corrupt", can you describe this more? If the jvm died for some reason, the index would simply be stale (behind) relative to the database, and the next query, once the jvm has restarted, should update the index as it was before.
   
   I would expect the doc to be missing for an include_docs=true if the doc were deleted between the start of the _search request and its completion, but I'm inferring this PR is not about addressing that known case?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org