[GitHub] [ozone] dombizita commented on a diff in pull request #3736: HDDS-7144. Recon: Make only hostname fixed in Datanodes page.

[GitBox <gi...@apache.org>]

dombizita commented on code in PR #3736:
URL: https://github.com/apache/ozone/pull/3736#discussion_r964594814


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx:
##########
@@ -120,40 +120,43 @@ const renderDatanodeOpState = (opState: DatanodeOpState) => {
 };
 
 const COLUMNS = [
+  {
+    title: 'Hostname',
+    dataIndex: 'hostname',
+    key: 'hostname',
+    isVisible: true,
+    isSearchable: true,
+    sorter: (a: IDatanode, b: IDatanode) => a.hostname.localeCompare(b.hostname),
+    defaultSortOrder: 'ascend' as const,
+    fixed: 'left'
+  },
   {
     title: 'State',
     dataIndex: 'state',
     key: 'state',
     isVisible: true,
+    isSearchable: true,
     filterMultiple: true,
     filters: DatanodeStateList.map(state => ({text: state, value: state})),
     onFilter: (value: DatanodeState, record: IDatanode) => record.state === value,
     render: (text: DatanodeState) => renderDatanodeState(text),
     sorter: (a: IDatanode, b: IDatanode) => a.state.localeCompare(b.state),
-    fixed: 'left'
+    //fixed: 'left'

Review Comment:
   Could you remove this line instead of commenting it out? 
   ```suggestion
   ```



##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx:
##########
@@ -120,40 +120,43 @@ const renderDatanodeOpState = (opState: DatanodeOpState) => {
 };
 
 const COLUMNS = [
+  {
+    title: 'Hostname',
+    dataIndex: 'hostname',
+    key: 'hostname',
+    isVisible: true,
+    isSearchable: true,
+    sorter: (a: IDatanode, b: IDatanode) => a.hostname.localeCompare(b.hostname),
+    defaultSortOrder: 'ascend' as const,
+    fixed: 'left'
+  },
   {
     title: 'State',
     dataIndex: 'state',
     key: 'state',
     isVisible: true,
+    isSearchable: true,
     filterMultiple: true,
     filters: DatanodeStateList.map(state => ({text: state, value: state})),
     onFilter: (value: DatanodeState, record: IDatanode) => record.state === value,
     render: (text: DatanodeState) => renderDatanodeState(text),
     sorter: (a: IDatanode, b: IDatanode) => a.state.localeCompare(b.state),
-    fixed: 'left'
+    //fixed: 'left'
   },
   {
     title: 'Operational State',
     dataIndex: 'opState',
     key: 'opState',
     isVisible: true,
+    isSearchable: true,
     filterMultiple: true,
     filters: DatanodeOpStateList.map(state => ({text: state, value: state})),
     onFilter: (value: DatanodeOpState, record: IDatanode) => record.opState === value,
     render: (text: DatanodeOpState) => renderDatanodeOpState(text),
     sorter: (a: IDatanode, b: IDatanode) => a.opState.localeCompare(b.opState),
-    fixed: 'left'
-  },
-  {
-    title: 'Hostname',
-    dataIndex: 'hostname',
-    key: 'hostname',
-    isVisible: true,
-    isSearchable: true,
-    sorter: (a: IDatanode, b: IDatanode) => a.hostname.localeCompare(b.hostname),
-    defaultSortOrder: 'ascend' as const,
-    fixed: 'left'
+    //fixed: 'left'

Review Comment:
   Same here
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org