You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Kevin Klues (JIRA)" <ji...@apache.org> on 2017/10/05 14:10:00 UTC
[jira] [Commented] (MESOS-6390) Ensure Python support scripts are
linted
[ https://issues.apache.org/jira/browse/MESOS-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192922#comment-16192922 ]
Kevin Klues commented on MESOS-6390:
------------------------------------
{noformat}
commit 38af943ad6a2f8e7a47148ab6637692978545500
Author: Armand Grillet <ag...@mesosphere.io>
Date: Thu Oct 5 16:03:51 2017 +0200
Added support/ to the list of the linted directories.
By adding the support directory to 'mesos-style.py', we make sure
that all our support scripts follow the same coding style that the
rest of our Python codebase uses.
We also added invalid-name to 'pylint.config' as all the Python files
in support/ use dashes instead of underscores and we also added
'file-ignored' as we do not lint 'support/post-reviews.py' yet.
Review: https://reviews.apache.org/r/62788/
{noformat}
> Ensure Python support scripts are linted
> ----------------------------------------
>
> Key: MESOS-6390
> URL: https://issues.apache.org/jira/browse/MESOS-6390
> Project: Mesos
> Issue Type: Improvement
> Reporter: Benjamin Bannier
> Assignee: Armand Grillet
> Labels: newbie, python
> Fix For: 1.5.0
>
>
> Currently {{support/mesos-style.py}} does not lint files under {{support/}}. This is mostly due to the fact that these scripts are too inconsistent style-wise that they wouldn't even pass the linter now.
> We should clean up all Python scripts under {{support/}} so they pass the Python linter, and activate that directory in the linter for future additions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)