You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by m-hogue <gi...@git.apache.org> on 2017/09/06 18:34:00 UTC
[GitHub] nifi pull request #2131: NIFI-4335: Changed SSL Context Service implementati...
GitHub user m-hogue opened a pull request:
https://github.com/apache/nifi/pull/2131
NIFI-4335: Changed SSL Context Service implementations to RestrictedS…
…SLContextService for all Listen* processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/m-hogue/nifi NIFI-4335
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2131.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2131
----
commit f89fb4fcd37f474150d426c3446e16fe532dd9e7
Author: m-hogue <ho...@gmail.com>
Date: 2017-09-06T18:33:11Z
NIFI-4335: Changed SSL Context Service implementations to RestrictedSSLContextService for all Listen* processors
----
---
[GitHub] nifi pull request #2131: NIFI-4335: Changed SSL Context Service interfaces t...
Posted by m-hogue <gi...@git.apache.org>.
Github user m-hogue commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2131#discussion_r137437479
--- Diff: nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-processors/src/main/java/org/apache/nifi/processors/grpc/ListenGRPC.java ---
@@ -82,25 +83,29 @@
// properties
public static final PropertyDescriptor PROP_SERVICE_PORT = new PropertyDescriptor.Builder()
.name("Local gRPC service port")
+ .displayName("Local gRPC Service Port")
.description("The local port that the gRPC service will listen on.")
.required(true)
.addValidator(StandardValidators.PORT_VALIDATOR)
.build();
public static final PropertyDescriptor PROP_USE_SECURE = new PropertyDescriptor.Builder()
- .name("Use SSL/TLS")
- .description("Whether or not to use SSL/TLS to send the contents of the gRPC messages.")
+ .name("Use TLS")
--- End diff --
My rationale on that name change was that `ListenGRPC` hasn't appeared in a formal nifi release yet (I added it in the current baseline), so i went with the name change. However, i'm good with whichever way you decide.
---
[GitHub] nifi pull request #2131: NIFI-4335: Changed SSL Context Service interfaces t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2131
---
[GitHub] nifi pull request #2131: NIFI-4335: Changed SSL Context Service interfaces t...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2131#discussion_r137440662
--- Diff: nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-processors/src/main/java/org/apache/nifi/processors/grpc/ListenGRPC.java ---
@@ -82,25 +83,29 @@
// properties
public static final PropertyDescriptor PROP_SERVICE_PORT = new PropertyDescriptor.Builder()
.name("Local gRPC service port")
+ .displayName("Local gRPC Service Port")
.description("The local port that the gRPC service will listen on.")
.required(true)
.addValidator(StandardValidators.PORT_VALIDATOR)
.build();
public static final PropertyDescriptor PROP_USE_SECURE = new PropertyDescriptor.Builder()
- .name("Use SSL/TLS")
- .description("Whether or not to use SSL/TLS to send the contents of the gRPC messages.")
+ .name("Use TLS")
--- End diff --
The name change is entirely fair game since it hasn't been in a release yet.
---
[GitHub] nifi pull request #2131: NIFI-4335: Changed SSL Context Service interfaces t...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2131#discussion_r137413455
--- Diff: nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-processors/src/main/java/org/apache/nifi/processors/grpc/ListenGRPC.java ---
@@ -82,25 +83,29 @@
// properties
public static final PropertyDescriptor PROP_SERVICE_PORT = new PropertyDescriptor.Builder()
.name("Local gRPC service port")
+ .displayName("Local gRPC Service Port")
.description("The local port that the gRPC service will listen on.")
.required(true)
.addValidator(StandardValidators.PORT_VALIDATOR)
.build();
public static final PropertyDescriptor PROP_USE_SECURE = new PropertyDescriptor.Builder()
- .name("Use SSL/TLS")
- .description("Whether or not to use SSL/TLS to send the contents of the gRPC messages.")
+ .name("Use TLS")
--- End diff --
The `name` value needs to stay the same so that templates and flows which referenced the previous version will continue to work. If this value changes, existing templates and flows will not be read correctly and these values will be lost. This is why `displayName` was introduced.
---
[GitHub] nifi pull request #2131: NIFI-4335: Changed SSL Context Service interfaces t...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2131#discussion_r137439696
--- Diff: nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-processors/src/main/java/org/apache/nifi/processors/grpc/ListenGRPC.java ---
@@ -82,25 +83,29 @@
// properties
public static final PropertyDescriptor PROP_SERVICE_PORT = new PropertyDescriptor.Builder()
.name("Local gRPC service port")
+ .displayName("Local gRPC Service Port")
.description("The local port that the gRPC service will listen on.")
.required(true)
.addValidator(StandardValidators.PORT_VALIDATOR)
.build();
public static final PropertyDescriptor PROP_USE_SECURE = new PropertyDescriptor.Builder()
- .name("Use SSL/TLS")
- .description("Whether or not to use SSL/TLS to send the contents of the gRPC messages.")
+ .name("Use TLS")
--- End diff --
I will sign off on this because I agree with your reasoning, but I would appreciate "Apache" guidance from @joewitt on this. I know some people do run "bleeding-edge"/`master` releases (ideally not in production, but still...).
---
[GitHub] nifi issue #2131: NIFI-4335: Changed SSL Context Service interfaces to Restr...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2131
Ran `contrib-check` and all tests pass. Manually verified some of the components in a running environment. +1, merging.
---
[GitHub] nifi issue #2131: NIFI-4335: Changed SSL Context Service interfaces to Restr...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2131
@m-hogue I made one comment on `name` changes, other than that I will check this out and verify it after I finish working on a couple other PRs.
---