You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jerryshao <gi...@git.apache.org> on 2015/04/16 08:06:17 UTC
[GitHub] spark pull request: [Streaming][minor] Remove additional quote and...
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/5540
[Streaming][minor] Remove additional quote and unneeded imports
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerryshao/apache-spark minor-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5540
----
commit ebaa6463e26586db9d51721e41edb9958166d1df
Author: jerryshao <sa...@intel.com>
Date: 2015-04-16T06:09:11Z
Minor fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Streaming][minor] Remove additional quote and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5540
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Streaming][minor] Remove additional quote and...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5540#issuecomment-93666603
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30399/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Streaming][minor] Remove additional quote and...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5540#issuecomment-93652180
[Test build #30399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30399/consoleFull) for PR 5540 at commit [`ebaa646`](https://github.com/apache/spark/commit/ebaa6463e26586db9d51721e41edb9958166d1df).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Streaming][minor] Remove additional quote and...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5540#issuecomment-93666578
[Test build #30399 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30399/consoleFull) for PR 5540 at commit [`ebaa646`](https://github.com/apache/spark/commit/ebaa6463e26586db9d51721e41edb9958166d1df).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Streaming][minor] Remove additional quote and...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5540#issuecomment-93691415
That's fine. I think this is below the threshold of being worth opening a PR, since it is a trivial improvement, and still takes, you know, probably half an hour of time added up over all the people that will look at this, Jenkins cycles, commit in the commit log, etc. Tiny cost but doesn't seem worth it given how incredibly busy this is. Your time would be better spent reviewing PRs or working on larger issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org