You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/05/15 13:49:07 UTC
[Impala-ASF-CR] IMPALA-14060: Remove ImpalaConnection.get default configuration()
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22903
Change subject: IMPALA-14060: Remove ImpalaConnection.get_default_configuration()
......................................................................
IMPALA-14060: Remove ImpalaConnection.get_default_configuration()
This patch remove ImpalaConnection.get_default_configuration() after
refactoring done in IMPALA-14039.
Testing:
Run and pass test_queries.py::TestQueries.
Change-Id: Idf2a3a5b7b427a46ddd288bb7fbb16ba2803735d
---
M tests/common/impala_connection.py
1 file changed, 0 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/22903/1
--
To view, visit http://gerrit.cloudera.org:8080/22903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf2a3a5b7b427a46ddd288bb7fbb16ba2803735d
Gerrit-Change-Number: 22903
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14060: Remove ImpalaConnection.get default configuration()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22903 )
Change subject: IMPALA-14060: Remove ImpalaConnection.get_default_configuration()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf2a3a5b7b427a46ddd288bb7fbb16ba2803735d
Gerrit-Change-Number: 22903
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 May 2025 19:05:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14060: Remove ImpalaConnection.get default configuration()
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22903 )
Change subject: IMPALA-14060: Remove ImpalaConnection.get_default_configuration()
......................................................................
Patch Set 1: Code-Review+2
This looks good to me
--
To view, visit http://gerrit.cloudera.org:8080/22903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf2a3a5b7b427a46ddd288bb7fbb16ba2803735d
Gerrit-Change-Number: 22903
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 May 2025 19:04:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14060: Remove ImpalaConnection.get default configuration()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22903 )
Change subject: IMPALA-14060: Remove ImpalaConnection.get_default_configuration()
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf2a3a5b7b427a46ddd288bb7fbb16ba2803735d
Gerrit-Change-Number: 22903
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 May 2025 01:19:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14060: Remove ImpalaConnection.get default configuration()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22903 )
Change subject: IMPALA-14060: Remove ImpalaConnection.get_default_configuration()
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11889/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf2a3a5b7b427a46ddd288bb7fbb16ba2803735d
Gerrit-Change-Number: 22903
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 May 2025 19:05:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14060: Remove ImpalaConnection.get default configuration()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22903 )
Change subject: IMPALA-14060: Remove ImpalaConnection.get_default_configuration()
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19222/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf2a3a5b7b427a46ddd288bb7fbb16ba2803735d
Gerrit-Change-Number: 22903
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 May 2025 14:16:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14060: Remove ImpalaConnection.get default configuration()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22903 )
Change subject: IMPALA-14060: Remove ImpalaConnection.get_default_configuration()
......................................................................
IMPALA-14060: Remove ImpalaConnection.get_default_configuration()
This patch remove ImpalaConnection.get_default_configuration() after
refactoring done in IMPALA-14039.
Testing:
Run and pass test_queries.py::TestQueries.
Change-Id: Idf2a3a5b7b427a46ddd288bb7fbb16ba2803735d
Reviewed-on: http://gerrit.cloudera.org:8080/22903
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/impala_connection.py
1 file changed, 0 insertions(+), 50 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf2a3a5b7b427a46ddd288bb7fbb16ba2803735d
Gerrit-Change-Number: 22903
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>