You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "timsaucer (via GitHub)" <gi...@apache.org> on 2025/03/29 13:23:43 UTC
[PR] Allow type coersion of zero input arrays to nullary [datafusion]
timsaucer opened a new pull request, #15487:
URL: https://github.com/apache/datafusion/pull/15487
## Which issue does this PR close?
None
## Rationale for this change
During testing for aggregate UDFs via FFI I discovered that if we have a UDF with a nullary type signature, it cannot use the coercion functions with arguments of zero lenght. This PR adjusts for that fact.
Additional testing showed that we need to implement `return_type_from_args` or some UDFs would fail. This PR implements it.
## What changes are included in this PR?
In addition to the two changes above, there are some moving around of the FFI integration tests now that they're getting larger. Basically I split them into a couple of files.
## Are these changes tested?
Unit test added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Allow type coersion of zero input arrays to nullary [datafusion]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer merged PR #15487:
URL: https://github.com/apache/datafusion/pull/15487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Allow type coersion of zero input arrays to nullary [datafusion]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer commented on PR #15487:
URL: https://github.com/apache/datafusion/pull/15487#issuecomment-2764095858
@jayzhan211 Would you mind reviewing, specifically the part in `datafusion/expr/src/type_coercion/functions.rs` since you were the prior author?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org