You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by Joe Witt <jo...@gmail.com> on 2020/07/10 17:36:50 UTC
Please fix the broken main build
MikeT,
Can you please fix main which is failing in Github CI due to a
contrib-check issue.
Appears to be introduced by merging
https://github.com/apache/nifi/commit/ee91341ec3ce6009b6632d624defe00bd9b082ea
Thanks
Re: Please fix the broken main build
Posted by Joe Witt <jo...@gmail.com>.
That probably was before contrib check was running again. Had been broken
a long time
Thanks
On Fri, Jul 10, 2020 at 1:02 PM Mike Thomsen <mi...@gmail.com> wrote:
> Ok. PR is up. Going to let the build run.
>
> Weird part is that if you look at the PR I merged, 3/4 builds ran!
>
> https://github.com/apache/nifi/pull/4309/checks
>
> On Fri, Jul 10, 2020 at 3:34 PM Joe Witt <jo...@gmail.com> wrote:
>
> > It is a checkstyle issue so pls just fix/merge if thats all +1
> >
> > thanks
> >
> > On Fri, Jul 10, 2020 at 12:21 PM Mike Thomsen <mi...@gmail.com>
> > wrote:
> >
> > > It's a style check error. Do you want me to just merge when I get some
> > time
> > > or do a PR?
> > >
> > > On Fri, Jul 10, 2020 at 1:37 PM Joe Witt <jo...@gmail.com> wrote:
> > >
> > > > MikeT,
> > > >
> > > > Can you please fix main which is failing in Github CI due to a
> > > > contrib-check issue.
> > > >
> > > > Appears to be introduced by merging
> > > >
> > > >
> > >
> >
> https://github.com/apache/nifi/commit/ee91341ec3ce6009b6632d624defe00bd9b082ea
> > > >
> > > > Thanks
> > > >
> > >
> >
>
Re: Please fix the broken main build
Posted by Mike Thomsen <mi...@gmail.com>.
Ok. PR is up. Going to let the build run.
Weird part is that if you look at the PR I merged, 3/4 builds ran!
https://github.com/apache/nifi/pull/4309/checks
On Fri, Jul 10, 2020 at 3:34 PM Joe Witt <jo...@gmail.com> wrote:
> It is a checkstyle issue so pls just fix/merge if thats all +1
>
> thanks
>
> On Fri, Jul 10, 2020 at 12:21 PM Mike Thomsen <mi...@gmail.com>
> wrote:
>
> > It's a style check error. Do you want me to just merge when I get some
> time
> > or do a PR?
> >
> > On Fri, Jul 10, 2020 at 1:37 PM Joe Witt <jo...@gmail.com> wrote:
> >
> > > MikeT,
> > >
> > > Can you please fix main which is failing in Github CI due to a
> > > contrib-check issue.
> > >
> > > Appears to be introduced by merging
> > >
> > >
> >
> https://github.com/apache/nifi/commit/ee91341ec3ce6009b6632d624defe00bd9b082ea
> > >
> > > Thanks
> > >
> >
>
Re: Please fix the broken main build
Posted by Joe Witt <jo...@gmail.com>.
It is a checkstyle issue so pls just fix/merge if thats all +1
thanks
On Fri, Jul 10, 2020 at 12:21 PM Mike Thomsen <mi...@gmail.com>
wrote:
> It's a style check error. Do you want me to just merge when I get some time
> or do a PR?
>
> On Fri, Jul 10, 2020 at 1:37 PM Joe Witt <jo...@gmail.com> wrote:
>
> > MikeT,
> >
> > Can you please fix main which is failing in Github CI due to a
> > contrib-check issue.
> >
> > Appears to be introduced by merging
> >
> >
> https://github.com/apache/nifi/commit/ee91341ec3ce6009b6632d624defe00bd9b082ea
> >
> > Thanks
> >
>
Re: Please fix the broken main build
Posted by Mike Thomsen <mi...@gmail.com>.
It's a style check error. Do you want me to just merge when I get some time
or do a PR?
On Fri, Jul 10, 2020 at 1:37 PM Joe Witt <jo...@gmail.com> wrote:
> MikeT,
>
> Can you please fix main which is failing in Github CI due to a
> contrib-check issue.
>
> Appears to be introduced by merging
>
> https://github.com/apache/nifi/commit/ee91341ec3ce6009b6632d624defe00bd9b082ea
>
> Thanks
>