[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4695: [Resource Assignment] Plug in resource assignment to LLC REALTIME table

[GitBox <gi...@apache.org>]

Jackie-Jiang opened a new pull request #4695: [Resource Assignment] Plug in resource assignment to LLC REALTIME table
URL: https://github.com/apache/incubator-pinot/pull/4695
 
 
   This is the last PR to plug in the new resource assignment, after this PR, all the segment assignment/rebalance will use the new strategy.
   For LLC REALTIME table, to keep it backward-compatible, allow assigning new segment to disabled instances
   
   Re-write most of the PinotLLCRealtimeSegmentManager to use the new assignment strategy:
   - Remove the boolean return and change it to throw exception when operation failed (old code can throw exception and also return false, which is hard to manage)
   - Remove the controller leadership check inside the PinotLLCRealtimeSegmentManager to prevent responding FAILED in case of NOT_LEADER. The check is already performed in SegmentCompletionManager.
   - Enhance the segment repair logic to correctly skip OFFLINE segments
   - Introduce the LLC_ZOOKEEPER_FETCH_FAILURES in controller metrics to track ZK exceptions
   
   Re-write the PinotLLCRealtimeSegmentManagerTest to test all the changes:
   - testCommittingSegmentIfDisconnected is removed because we don't explicitly check disconnection but fail with the ZK exception
   - testIdealStateAlreadyUpdated is covered by testCommitSegment committing the segment again

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org