You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Aki Yoshida <ay...@apache.org> on 2014/12/01 10:08:11 UTC

Re: cxf git commit: Including Ekstazi (www.ekstazi.org) profile to optimize execution of the tests

@Milos,
this file usually gets deleted after the test completes, right?
And even when the test gets aborted and leaves this file, this will be
be deleted in the next test.

In that case, this file is currently doing not much harm to the build.
We can keep the current pom setting for now and wait for Milo's update
(either not using such temp file or having the reasonable location so
it doesn't need to be explicitly set in the pom).



2014-11-30 4:19 GMT+01:00 Milos Gligoric <mi...@gmail.com>:
> Hi Dan,
>
> Good point.  Currently "excludesFile" is needed, but the value can be
> any (including target, as you suggested).
>
> I am working on a new version of Ekstazi, which will not use
> "excludesFile". Actually, the new version will not require any changes
> in pom.xml except including Ekstazi plugin.  Due to some other work, I
> cannot say the exact date, but new version should be soon (say in a
> week).  I will announce the new version on
> https://groups.google.com/forum/#!forum/ekstazi.  Also, I will notify
> a CXF developer to remove the line that you mentioned.
>
> Thanks for the comment,
> Milos
>
> On Sat, Nov 29, 2014 at 3:50 AM, Daniel Kulp <dk...@apache.org> wrote:
>>> +                            </excludes>
>>> +                            <excludesFile>${java.io.tmpdir}/${user.name}EkstaziExcludes</excludesFile>
>>> +                        </configuration>
>>
>> Does that need to go there?   Can that just be set to the target directory?
>>
>> It's really a  bad idea to have it generate and leave things in the tmp dir and I want to make sure a clean really does clean everything related to it.
>>
>> Dan
>>
>>
>>
>>> On Nov 28, 2014, at 4:27 AM, ay@apache.org wrote:
>>>
>>> Repository: cxf
>>> Updated Branches:
>>>  refs/heads/master c29f64a42 -> 9dfb278c7
>>>
>>>
>>> Including Ekstazi (www.ekstazi.org) profile to optimize execution of the tests
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/9dfb278c
>>> Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/9dfb278c
>>> Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/9dfb278c
>>>
>>> Branch: refs/heads/master
>>> Commit: 9dfb278c7739b9f4621f43b8146d057e21fafb64
>>> Parents: c29f64a
>>> Author: Milos Gligoric <mi...@gmail.com>
>>> Authored: Thu Nov 13 09:25:26 2014 -0600
>>> Committer: Akitoshi Yoshida <ay...@apache.org>
>>> Committed: Fri Nov 28 10:25:35 2014 +0100
>>>
>>> ----------------------------------------------------------------------
>>> .gitignore     |  1 +
>>> parent/pom.xml | 45 +++++++++++++++++++++++++++++++++++++++++++++
>>> 2 files changed, 46 insertions(+)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/cxf/blob/9dfb278c/.gitignore
>>> ----------------------------------------------------------------------
>>> diff --git a/.gitignore b/.gitignore
>>> index dbf1353..9810ca4 100644
>>> --- a/.gitignore
>>> +++ b/.gitignore
>>> @@ -5,6 +5,7 @@
>>> .DS_Store
>>> .checkstyle
>>> .classpath
>>> +.ekstazi
>>> .pmd
>>> .pmdruleset
>>> .pmdruleset.xml
>>>
>>> http://git-wip-us.apache.org/repos/asf/cxf/blob/9dfb278c/parent/pom.xml
>>> ----------------------------------------------------------------------
>>> diff --git a/parent/pom.xml b/parent/pom.xml
>>> index 87e2002..a9de550 100644
>>> --- a/parent/pom.xml
>>> +++ b/parent/pom.xml
>>> @@ -1986,5 +1986,50 @@
>>>                 <defaultGoal>clean</defaultGoal>
>>>             </build>
>>>         </profile>
>>> +
>>> +        <!-- experimental profile to activate ekstazi http://www.ekstazi.org -->
>>> +        <profile>
>>> +            <id>ekstazi</id>
>>> +            <activation>
>>> +                <property>
>>> +                    <name>ekstazi</name>
>>> +                </property>
>>> +            </activation>
>>> +
>>> +            <build>
>>> +                <plugins>
>>> +                    <plugin>
>>> +                        <groupId>org.ekstazi</groupId>
>>> +                        <artifactId>ekstazi-maven-plugin</artifactId>
>>> +                        <version>4.3.0</version>
>>> +                        <configuration>
>>> +                            <!-- always run tests that failed in prevoius run -->
>>> +                            <forcefailing>true</forcefailing>
>>> +                        </configuration>
>>> +                        <executions>
>>> +                            <execution>
>>> +                                <id>doit</id>
>>> +                                <goals>
>>> +                                    <goal>select</goal>
>>> +                                    <goal>restore</goal>
>>> +                                </goals>
>>> +                            </execution>
>>> +                        </executions>
>>> +                    </plugin>
>>> +
>>> +                    <plugin>
>>> +                        <artifactId>maven-surefire-plugin</artifactId>
>>> +                        <configuration>
>>> +                            <argLine>${argLine} ${cxf.surefire.fork.vmargs}</argLine>
>>> +                            <excludes>
>>> +                                <exclude>**/*NoAriesBlueprintTest.java</exclude>
>>> +                                <exclude>**/*JAXRSDataBindingTest.java</exclude>
>>> +                            </excludes>
>>> +                            <excludesFile>${java.io.tmpdir}/${user.name}EkstaziExcludes</excludesFile>
>>> +                        </configuration>
>>> +                    </plugin>
>>> +                </plugins>
>>> +            </build>
>>> +        </profile>
>>>     </profiles>
>>> </project>
>>>
>>
>> --
>> Daniel Kulp
>> dkulp@apache.org - http://dankulp.com/blog
>> Talend Community Coder - http://coders.talend.com
>>

Re: cxf git commit: Including Ekstazi (www.ekstazi.org) profile to optimize execution of the tests

Posted by Milos Gligoric <mi...@gmail.com>.
Aki,

As you said, the file gets deleted at the end of the build (as long as
VM that executes the build process does not crash).  In addition,
Ekstazi checks if the file was deleted in the previous run and deletes
the file if it exists.  The next version of Ekstazi will completely
remove the need for this file.  Stay tuned.

Thanks,
Milos


On Mon, Dec 1, 2014 at 3:08 AM, Aki Yoshida <ay...@apache.org> wrote:
> @Milos,
> this file usually gets deleted after the test completes, right?
> And even when the test gets aborted and leaves this file, this will be
> be deleted in the next test.
>
> In that case, this file is currently doing not much harm to the build.
> We can keep the current pom setting for now and wait for Milo's update
> (either not using such temp file or having the reasonable location so
> it doesn't need to be explicitly set in the pom).
>
>
>
> 2014-11-30 4:19 GMT+01:00 Milos Gligoric <mi...@gmail.com>:
>> Hi Dan,
>>
>> Good point.  Currently "excludesFile" is needed, but the value can be
>> any (including target, as you suggested).
>>
>> I am working on a new version of Ekstazi, which will not use
>> "excludesFile". Actually, the new version will not require any changes
>> in pom.xml except including Ekstazi plugin.  Due to some other work, I
>> cannot say the exact date, but new version should be soon (say in a
>> week).  I will announce the new version on
>> https://groups.google.com/forum/#!forum/ekstazi.  Also, I will notify
>> a CXF developer to remove the line that you mentioned.
>>
>> Thanks for the comment,
>> Milos
>>
>> On Sat, Nov 29, 2014 at 3:50 AM, Daniel Kulp <dk...@apache.org> wrote:
>>>> +                            </excludes>
>>>> +                            <excludesFile>${java.io.tmpdir}/${user.name}EkstaziExcludes</excludesFile>
>>>> +                        </configuration>
>>>
>>> Does that need to go there?   Can that just be set to the target directory?
>>>
>>> It's really a  bad idea to have it generate and leave things in the tmp dir and I want to make sure a clean really does clean everything related to it.
>>>
>>> Dan
>>>
>>>
>>>
>>>> On Nov 28, 2014, at 4:27 AM, ay@apache.org wrote:
>>>>
>>>> Repository: cxf
>>>> Updated Branches:
>>>>  refs/heads/master c29f64a42 -> 9dfb278c7
>>>>
>>>>
>>>> Including Ekstazi (www.ekstazi.org) profile to optimize execution of the tests
>>>>
>>>>
>>>> Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
>>>> Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/9dfb278c
>>>> Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/9dfb278c
>>>> Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/9dfb278c
>>>>
>>>> Branch: refs/heads/master
>>>> Commit: 9dfb278c7739b9f4621f43b8146d057e21fafb64
>>>> Parents: c29f64a
>>>> Author: Milos Gligoric <mi...@gmail.com>
>>>> Authored: Thu Nov 13 09:25:26 2014 -0600
>>>> Committer: Akitoshi Yoshida <ay...@apache.org>
>>>> Committed: Fri Nov 28 10:25:35 2014 +0100
>>>>
>>>> ----------------------------------------------------------------------
>>>> .gitignore     |  1 +
>>>> parent/pom.xml | 45 +++++++++++++++++++++++++++++++++++++++++++++
>>>> 2 files changed, 46 insertions(+)
>>>> ----------------------------------------------------------------------
>>>>
>>>>
>>>> http://git-wip-us.apache.org/repos/asf/cxf/blob/9dfb278c/.gitignore
>>>> ----------------------------------------------------------------------
>>>> diff --git a/.gitignore b/.gitignore
>>>> index dbf1353..9810ca4 100644
>>>> --- a/.gitignore
>>>> +++ b/.gitignore
>>>> @@ -5,6 +5,7 @@
>>>> .DS_Store
>>>> .checkstyle
>>>> .classpath
>>>> +.ekstazi
>>>> .pmd
>>>> .pmdruleset
>>>> .pmdruleset.xml
>>>>
>>>> http://git-wip-us.apache.org/repos/asf/cxf/blob/9dfb278c/parent/pom.xml
>>>> ----------------------------------------------------------------------
>>>> diff --git a/parent/pom.xml b/parent/pom.xml
>>>> index 87e2002..a9de550 100644
>>>> --- a/parent/pom.xml
>>>> +++ b/parent/pom.xml
>>>> @@ -1986,5 +1986,50 @@
>>>>                 <defaultGoal>clean</defaultGoal>
>>>>             </build>
>>>>         </profile>
>>>> +
>>>> +        <!-- experimental profile to activate ekstazi http://www.ekstazi.org -->
>>>> +        <profile>
>>>> +            <id>ekstazi</id>
>>>> +            <activation>
>>>> +                <property>
>>>> +                    <name>ekstazi</name>
>>>> +                </property>
>>>> +            </activation>
>>>> +
>>>> +            <build>
>>>> +                <plugins>
>>>> +                    <plugin>
>>>> +                        <groupId>org.ekstazi</groupId>
>>>> +                        <artifactId>ekstazi-maven-plugin</artifactId>
>>>> +                        <version>4.3.0</version>
>>>> +                        <configuration>
>>>> +                            <!-- always run tests that failed in prevoius run -->
>>>> +                            <forcefailing>true</forcefailing>
>>>> +                        </configuration>
>>>> +                        <executions>
>>>> +                            <execution>
>>>> +                                <id>doit</id>
>>>> +                                <goals>
>>>> +                                    <goal>select</goal>
>>>> +                                    <goal>restore</goal>
>>>> +                                </goals>
>>>> +                            </execution>
>>>> +                        </executions>
>>>> +                    </plugin>
>>>> +
>>>> +                    <plugin>
>>>> +                        <artifactId>maven-surefire-plugin</artifactId>
>>>> +                        <configuration>
>>>> +                            <argLine>${argLine} ${cxf.surefire.fork.vmargs}</argLine>
>>>> +                            <excludes>
>>>> +                                <exclude>**/*NoAriesBlueprintTest.java</exclude>
>>>> +                                <exclude>**/*JAXRSDataBindingTest.java</exclude>
>>>> +                            </excludes>
>>>> +                            <excludesFile>${java.io.tmpdir}/${user.name}EkstaziExcludes</excludesFile>
>>>> +                        </configuration>
>>>> +                    </plugin>
>>>> +                </plugins>
>>>> +            </build>
>>>> +        </profile>
>>>>     </profiles>
>>>> </project>
>>>>
>>>
>>> --
>>> Daniel Kulp
>>> dkulp@apache.org - http://dankulp.com/blog
>>> Talend Community Coder - http://coders.talend.com
>>>