You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2016/02/05 16:29:38 UTC
Review Request 43254: [Patch upgrade ] Remove old unused component
version/status staff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43254/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-14944
https://issues.apache.org/jira/browse/AMBARI-14944
Repository: ambari
Description
-------
Decided to start implementing new component version reporting from an agent side.
Started with removing outdated/unused code that was responsible for handling component versions
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py a4c433d
ambari-agent/src/main/python/ambari_agent/LiveStatus.py 0354225
ambari-agent/src/main/python/ambari_agent/StackVersionsFileHandler.py 8afb140
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 715a60c
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 5fc1fc8
ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 51a2270
ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py ca1100c
ambari-agent/src/test/python/ambari_agent/TestStackVersionsFileHandler.py f01fd3e
Diff: https://reviews.apache.org/r/43254/diff/
Testing
-------
mvn clean test
Pending final E2E check on live cluster
Thanks,
Dmitro Lisnichenko
Re: Review Request 43254: [Patch upgrade ] Remove old unused component
version/status staff
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Feb. 17, 2016, 6:49 p.m., Nate Cole wrote:
> > May as well abort this review - we aren't going to make this change any time soon.
I'm going to commit it to trunk after testing at spare time. It's just a cleanup of old/unused staff on agent side
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43254/#review119478
-----------------------------------------------------------
On Feb. 5, 2016, 5:29 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43254/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 5:29 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14944
> https://issues.apache.org/jira/browse/AMBARI-14944
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Decided to start implementing new component version reporting from an agent side.
> Started with removing outdated/unused code that was responsible for handling component versions
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py a4c433d
> ambari-agent/src/main/python/ambari_agent/LiveStatus.py 0354225
> ambari-agent/src/main/python/ambari_agent/StackVersionsFileHandler.py 8afb140
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 715a60c
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 5fc1fc8
> ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 51a2270
> ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py ca1100c
> ambari-agent/src/test/python/ambari_agent/TestStackVersionsFileHandler.py f01fd3e
>
> Diff: https://reviews.apache.org/r/43254/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Pending final E2E check on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43254: [Patch upgrade ] Remove old unused component
version/status staff
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43254/#review119478
-----------------------------------------------------------
May as well abort this review - we aren't going to make this change any time soon.
- Nate Cole
On Feb. 5, 2016, 10:29 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43254/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 10:29 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14944
> https://issues.apache.org/jira/browse/AMBARI-14944
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Decided to start implementing new component version reporting from an agent side.
> Started with removing outdated/unused code that was responsible for handling component versions
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py a4c433d
> ambari-agent/src/main/python/ambari_agent/LiveStatus.py 0354225
> ambari-agent/src/main/python/ambari_agent/StackVersionsFileHandler.py 8afb140
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 715a60c
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 5fc1fc8
> ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 51a2270
> ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py ca1100c
> ambari-agent/src/test/python/ambari_agent/TestStackVersionsFileHandler.py f01fd3e
>
> Diff: https://reviews.apache.org/r/43254/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Pending final E2E check on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43254: [Patch upgrade ] Remove old unused component
version/status staff
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43254/#review118081
-----------------------------------------------------------
-1 for now. It's still a bit early to work on the agent side when the server side needs help with component version specific.
- Nate Cole
On Feb. 5, 2016, 10:29 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43254/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 10:29 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14944
> https://issues.apache.org/jira/browse/AMBARI-14944
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Decided to start implementing new component version reporting from an agent side.
> Started with removing outdated/unused code that was responsible for handling component versions
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py a4c433d
> ambari-agent/src/main/python/ambari_agent/LiveStatus.py 0354225
> ambari-agent/src/main/python/ambari_agent/StackVersionsFileHandler.py 8afb140
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 715a60c
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 5fc1fc8
> ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 51a2270
> ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py ca1100c
> ambari-agent/src/test/python/ambari_agent/TestStackVersionsFileHandler.py f01fd3e
>
> Diff: https://reviews.apache.org/r/43254/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Pending final E2E check on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43254: [cleanup] Remove old unused component
version/status staff from agent
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43254/#review121688
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 2, 2016, 5:31 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43254/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 5:31 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14944
> https://issues.apache.org/jira/browse/AMBARI-14944
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Removed outdated/unused agent code that was responsible for handling component versions
>
> Checked patch on cluster, all green
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py bf7b5d9
> ambari-agent/src/main/python/ambari_agent/LiveStatus.py 0354225
> ambari-agent/src/main/python/ambari_agent/StackVersionsFileHandler.py 8afb140
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 3d7acbc
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 5fc1fc8
> ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 51a2270
> ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py ca1100c
> ambari-agent/src/test/python/ambari_agent/TestStackVersionsFileHandler.py f01fd3e
>
> Diff: https://reviews.apache.org/r/43254/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43254: [cleanup] Remove old unused component
version/status staff from agent
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43254/
-----------------------------------------------------------
(Updated March 2, 2016, 7:31 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-14944
https://issues.apache.org/jira/browse/AMBARI-14944
Repository: ambari
Description (updated)
-------
Removed outdated/unused agent code that was responsible for handling component versions
Checked patch on cluster, all green
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py bf7b5d9
ambari-agent/src/main/python/ambari_agent/LiveStatus.py 0354225
ambari-agent/src/main/python/ambari_agent/StackVersionsFileHandler.py 8afb140
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 3d7acbc
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 5fc1fc8
ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 51a2270
ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py ca1100c
ambari-agent/src/test/python/ambari_agent/TestStackVersionsFileHandler.py f01fd3e
Diff: https://reviews.apache.org/r/43254/diff/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
Re: Review Request 43254: [cleanup] Remove old unused component
version/status staff from agent
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43254/
-----------------------------------------------------------
(Updated March 2, 2016, 7:30 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-14944
https://issues.apache.org/jira/browse/AMBARI-14944
Repository: ambari
Description
-------
Removed outdated/unused agent code that was responsible for handling component versions
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py bf7b5d9
ambari-agent/src/main/python/ambari_agent/LiveStatus.py 0354225
ambari-agent/src/main/python/ambari_agent/StackVersionsFileHandler.py 8afb140
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 3d7acbc
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 5fc1fc8
ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 51a2270
ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py ca1100c
ambari-agent/src/test/python/ambari_agent/TestStackVersionsFileHandler.py f01fd3e
Diff: https://reviews.apache.org/r/43254/diff/
Testing (updated)
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
Re: Review Request 43254: [cleanup] Remove old unused component
version/status staff from agent
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43254/
-----------------------------------------------------------
(Updated March 2, 2016, 7:30 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Summary (updated)
-----------------
[cleanup] Remove old unused component version/status staff from agent
Bugs: AMBARI-14944
https://issues.apache.org/jira/browse/AMBARI-14944
Repository: ambari
Description (updated)
-------
Removed outdated/unused agent code that was responsible for handling component versions
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py bf7b5d9
ambari-agent/src/main/python/ambari_agent/LiveStatus.py 0354225
ambari-agent/src/main/python/ambari_agent/StackVersionsFileHandler.py 8afb140
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 3d7acbc
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 5fc1fc8
ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 51a2270
ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py ca1100c
ambari-agent/src/test/python/ambari_agent/TestStackVersionsFileHandler.py f01fd3e
Diff: https://reviews.apache.org/r/43254/diff/
Testing
-------
mvn clean test
Pending final E2E check on live cluster
Thanks,
Dmitro Lisnichenko
Re: Review Request 43254: [Patch upgrade ] Remove old unused component
version/status staff
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43254/
-----------------------------------------------------------
(Updated March 2, 2016, 7:29 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Checked patch on cluster, all green
Bugs: AMBARI-14944
https://issues.apache.org/jira/browse/AMBARI-14944
Repository: ambari
Description
-------
Decided to start implementing new component version reporting from an agent side.
Started with removing outdated/unused code that was responsible for handling component versions
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py bf7b5d9
ambari-agent/src/main/python/ambari_agent/LiveStatus.py 0354225
ambari-agent/src/main/python/ambari_agent/StackVersionsFileHandler.py 8afb140
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 3d7acbc
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 5fc1fc8
ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 51a2270
ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py ca1100c
ambari-agent/src/test/python/ambari_agent/TestStackVersionsFileHandler.py f01fd3e
Diff: https://reviews.apache.org/r/43254/diff/
Testing
-------
mvn clean test
Pending final E2E check on live cluster
Thanks,
Dmitro Lisnichenko