You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/30 04:59:39 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4436: CKS CoreOS EOL update

sureshanaparti commented on a change in pull request #4436:
URL: https://github.com/apache/cloudstack/pull/4436#discussion_r514862732



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -833,3 +833,7 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
 
 -- Fix OS category for Guest OS 'Other PV Virtio-SCSI (64-bit)'
 UPDATE `cloud`.`guest_os` SET category_id = 7 WHERE id = 275 AND display_name = 'Other PV Virtio-SCSI (64-bit)';
+
+ALTER TABLE `cloud`.`user_vm` ADD COLUMN `user_vm_type` varchar(255) DEFAULT "UserVM" COMMENT 'Defines the type of UserVM';

Review comment:
       @Pearl1594 is this not redundant of _Type_ column in _vm_instance_ table? This _type_ column already used to persist different system VMs  (ConsoleProxy, SecondaryStorageVm, DomainRouter), may be you can use this for different user VMs as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org