[GitHub] keith-turner commented on a change in pull request #752: Fixes #747 - Shorten method names in AccumuloClient builder

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #752: Fixes #747 - Shorten method names in AccumuloClient builder
URL: https://github.com/apache/accumulo/pull/752#discussion_r233502089
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/AccumuloClient.java
 ##########
 @@ -363,14 +364,24 @@ AccumuloClient changeUser(String principal, AuthenticationToken token)
    * Builder method for setting Accumulo instance and zookeepers
    */
   interface InstanceArgs {
-    AuthenticationArgs forInstance(String instanceName, String zookeepers);
+    AuthenticationArgs to(CharSequence instanceName, CharSequence zookeepers);
   }
 
   /**
    * Builder methods for creating AccumuloClient using properties
    */
 
 Review comment:
   I think all of these inner interfaces need a since tag

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services