You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@turbine.apache.org by gk...@apache.org on 2018/10/17 10:37:41 UTC

svn commit: r1844084 - in /turbine/fulcrum/trunk/json/dist/src/assembly: bin.xml src.xml

Author: gk
Date: Wed Oct 17 10:37:41 2018
New Revision: 1844084

URL: http://svn.apache.org/viewvc?rev=1844084&view=rev
Log:
- fix maven build error: Windows OS=Windows and the assembly descriptor contains a *nix-specific root-relative-reference

Modified:
    turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml
    turbine/fulcrum/trunk/json/dist/src/assembly/src.xml

Modified: turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml
URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml?rev=1844084&r1=1844083&r2=1844084&view=diff
==============================================================================
--- turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml (original)
+++ turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml Wed Oct 17 10:37:41 2018
@@ -45,7 +45,7 @@
   <fileSets>
     <fileSet>
       <directory>${project.build.directory}/maven-shared-archive-resources/META-INF</directory>
-      <outputDirectory>/</outputDirectory>
+      <outputDirectory>${file.separator}</outputDirectory>
       <includes>
         <include>LICENSE*</include>
         <include>NOTICE*</include>

Modified: turbine/fulcrum/trunk/json/dist/src/assembly/src.xml
URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/json/dist/src/assembly/src.xml?rev=1844084&r1=1844083&r2=1844084&view=diff
==============================================================================
--- turbine/fulcrum/trunk/json/dist/src/assembly/src.xml (original)
+++ turbine/fulcrum/trunk/json/dist/src/assembly/src.xml Wed Oct 17 10:37:41 2018
@@ -53,7 +53,7 @@
   <fileSets>
     <fileSet>
       <directory>${project.build.directory}/maven-shared-archive-resources/META-INF</directory>
-      <outputDirectory>/</outputDirectory>
+      <outputDirectory>${file.separator}</outputDirectory>
       <includes>
         <include>LICENSE*</include>
         <include>NOTICE*</include>
@@ -61,7 +61,7 @@
     </fileSet>
     <fileSet>
       <directory>${project.parent.basedir}</directory>
-      <outputDirectory></outputDirectory>
+      <outputDirectory>${file.separator}</outputDirectory>
       <includes>
         <include>README*</include>
         <include>pom.xml</include>



Antwort: Re: svn commit: r1844084 - in /turbine/fulcrum/trunk/json/dist/src/assembly: bin.xml src.xml

Posted by Georg Kallidis <ge...@cedis.fu-berlin.de>.
yes, I forgot that! May be we should check dependencies beforehand...
-Georg



Von:    Jeffery Painter <je...@jivecast.com>
An:     dev@turbine.apache.org
Datum:  17.10.2018 14:20
Betreff:        Re: svn commit: r1844084 - in 
/turbine/fulcrum/trunk/json/dist/src/assembly: bin.xml src.xml



Hi Georg,

I haven't looked closely yet, but everything builds fine on my end after
your latest code checkins.

There is one update that seems to be missing though.  Should we point
the fulcrum-json-gson pom to the 2.0.0-SNAPSHOT parent pom now?

Thanks!
Jeff


On 10/17/2018 06:37 AM, gk@apache.org wrote:
> Author: gk
> Date: Wed Oct 17 10:37:41 2018
> New Revision: 1844084
>
> URL: http://svn.apache.org/viewvc?rev=1844084&view=rev
> Log:
> - fix maven build error: Windows OS=Windows and the assembly descriptor 
contains a *nix-specific root-relative-reference
>
> Modified:
>     turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml
>     turbine/fulcrum/trunk/json/dist/src/assembly/src.xml
>
> Modified: turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml
> URL: 
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml?rev=1844084&r1=1844083&r2=1844084&view=diff

> 
==============================================================================
> --- turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml (original)
> +++ turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml Wed Oct 17 
10:37:41 2018
> @@ -45,7 +45,7 @@
>    <fileSets>
>      <fileSet>
> 
<directory>${project.build.directory}/maven-shared-archive-resources/META-INF</directory>
> -      <outputDirectory>/</outputDirectory>
> +      <outputDirectory>${file.separator}</outputDirectory>
>        <includes>
>          <include>LICENSE*</include>
>          <include>NOTICE*</include>
>
> Modified: turbine/fulcrum/trunk/json/dist/src/assembly/src.xml
> URL: 
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/json/dist/src/assembly/src.xml?rev=1844084&r1=1844083&r2=1844084&view=diff

> 
==============================================================================
> --- turbine/fulcrum/trunk/json/dist/src/assembly/src.xml (original)
> +++ turbine/fulcrum/trunk/json/dist/src/assembly/src.xml Wed Oct 17 
10:37:41 2018
> @@ -53,7 +53,7 @@
>    <fileSets>
>      <fileSet>
> 
<directory>${project.build.directory}/maven-shared-archive-resources/META-INF</directory>
> -      <outputDirectory>/</outputDirectory>
> +      <outputDirectory>${file.separator}</outputDirectory>
>        <includes>
>          <include>LICENSE*</include>
>          <include>NOTICE*</include>
> @@ -61,7 +61,7 @@
>      </fileSet>
>      <fileSet>
>        <directory>${project.parent.basedir}</directory>
> -      <outputDirectory></outputDirectory>
> +      <outputDirectory>${file.separator}</outputDirectory>
>        <includes>
>          <include>README*</include>
>          <include>pom.xml</include>
>
>


[Anhang "signature.asc" gelöscht von Georg Kallidis/CeDiS/FU-Berlin/DE] 


Re: svn commit: r1844084 - in /turbine/fulcrum/trunk/json/dist/src/assembly: bin.xml src.xml

Posted by Jeffery Painter <je...@jivecast.com>.
Hi Georg,

I haven't looked closely yet, but everything builds fine on my end after
your latest code checkins.

There is one update that seems to be missing though.  Should we point
the fulcrum-json-gson pom to the 2.0.0-SNAPSHOT parent pom now?

Thanks!
Jeff


On 10/17/2018 06:37 AM, gk@apache.org wrote:
> Author: gk
> Date: Wed Oct 17 10:37:41 2018
> New Revision: 1844084
>
> URL: http://svn.apache.org/viewvc?rev=1844084&view=rev
> Log:
> - fix maven build error: Windows OS=Windows and the assembly descriptor contains a *nix-specific root-relative-reference
>
> Modified:
>     turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml
>     turbine/fulcrum/trunk/json/dist/src/assembly/src.xml
>
> Modified: turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml
> URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml?rev=1844084&r1=1844083&r2=1844084&view=diff
> ==============================================================================
> --- turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml (original)
> +++ turbine/fulcrum/trunk/json/dist/src/assembly/bin.xml Wed Oct 17 10:37:41 2018
> @@ -45,7 +45,7 @@
>    <fileSets>
>      <fileSet>
>        <directory>${project.build.directory}/maven-shared-archive-resources/META-INF</directory>
> -      <outputDirectory>/</outputDirectory>
> +      <outputDirectory>${file.separator}</outputDirectory>
>        <includes>
>          <include>LICENSE*</include>
>          <include>NOTICE*</include>
>
> Modified: turbine/fulcrum/trunk/json/dist/src/assembly/src.xml
> URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/json/dist/src/assembly/src.xml?rev=1844084&r1=1844083&r2=1844084&view=diff
> ==============================================================================
> --- turbine/fulcrum/trunk/json/dist/src/assembly/src.xml (original)
> +++ turbine/fulcrum/trunk/json/dist/src/assembly/src.xml Wed Oct 17 10:37:41 2018
> @@ -53,7 +53,7 @@
>    <fileSets>
>      <fileSet>
>        <directory>${project.build.directory}/maven-shared-archive-resources/META-INF</directory>
> -      <outputDirectory>/</outputDirectory>
> +      <outputDirectory>${file.separator}</outputDirectory>
>        <includes>
>          <include>LICENSE*</include>
>          <include>NOTICE*</include>
> @@ -61,7 +61,7 @@
>      </fileSet>
>      <fileSet>
>        <directory>${project.parent.basedir}</directory>
> -      <outputDirectory></outputDirectory>
> +      <outputDirectory>${file.separator}</outputDirectory>
>        <includes>
>          <include>README*</include>
>          <include>pom.xml</include>
>
>