You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/10/20 13:10:20 UTC
[GitHub] cordova-windows pull request #204: CB-12042 Copy base.js to www directory at...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/204
CB-12042 Copy base.js to www directory at create
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### What does this PR do?
Fixes missing `base.js` in `www` folder when project is created without Cordova CLI
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [-] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-windows CB-12042
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #204
----
commit 7d9b24cecd05cd4392824a465b8f447931d5817f
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-10-20T13:03:22Z
CB-12042 Copy base.js to www directory at create
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request #204: CB-12042 Copy base.js to www directory in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/204
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #204: CB-12042 Copy base.js to www directory in 'creat...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/204
## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/204?src=pr) is 74.64% (diff: 100%)
> Merging [#204](https://codecov.io/gh/apache/cordova-windows/pull/204?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will not change coverage
```diff
@@ master #204 diff @@
==========================================
Files 15 15
Lines 2067 2067
Methods 390 390
Messages 0 0
Branches 403 403
==========================================
Hits 1543 1543
Misses 524 524
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [bcc0a11...7d9b24c](https://codecov.io/gh/apache/cordova-windows/compare/bcc0a11cd62c7c59185c6db1d474665747b92f2b...7d9b24cecd05cd4392824a465b8f447931d5817f?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org