You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/05/03 22:24:00 UTC
[jira] [Commented] (KAFKA-8320) Connect Error handling is using the
RetriableException from common package
[ https://issues.apache.org/jira/browse/KAFKA-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832886#comment-16832886 ]
ASF GitHub Bot commented on KAFKA-8320:
---------------------------------------
mageshn commented on pull request #6675: KAFKA-8320 : fix retriable exception package for source connectors
URL: https://github.com/apache/kafka/pull/6675
WorkerSourceTask is catching the exception from wrong package `org.apache.kafka.common.errors`. It is not clear from the API standpoint as to which package the connect framework supports - the one from common or connect. The safest thing would be to support both the packages even though it's less desirable.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Connect Error handling is using the RetriableException from common package
> --------------------------------------------------------------------------
>
> Key: KAFKA-8320
> URL: https://issues.apache.org/jira/browse/KAFKA-8320
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 2.0.0
> Reporter: Magesh kumar Nandakumar
> Assignee: Magesh kumar Nandakumar
> Priority: Major
>
> When a SourceConnector throws
> org.apache.kafka.connect.errors.RetriableException during the poll, connect runtime is supposed to ignore the error and retry per [https://cwiki.apache.org/confluence/display/KAFKA/KIP-298%3A+Error+Handling+in+Connect] . When the conenctors throw the execption its not handled gracefully.
> WorkerSourceTask is catching the exception from wrong package `org.apache.kafka.common.errors`. It is not clear from the API standpoint as to which package the connect framework supports. The safest thing would be to support both the packages even though it's less desirable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)