You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by M Lawindi <ml...@microsoft.com> on 2016/01/27 23:29:13 UTC

Re: Review Request 40851: Windows:[1/2] Add patch for Windows ZK version.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40851/
-----------------------------------------------------------

(Updated Jan. 27, 2016, 10:29 p.m.)


Review request for mesos, Alex Naparu, Dario Bazan, Daniel Pravat, Alex Clemmer, and M Lawindi.


Summary (updated)
-----------------

Windows:[1/2] Add patch for Windows ZK version.


Repository: mesos


Description (updated)
-------

Windows:[1/2] Add patch for Windows ZK version.


Diffs (updated)
-----

  3rdparty/zookeeper-06d3f3f.patch PRE-CREATION 

Diff: https://reviews.apache.org/r/40851/diff/


Testing
-------

- Applied patch to original zookeeper 3.4.5
- Successfully opened 2015 solution in VS2015
- Cli and Zookeeper build successfully


Thanks,

M Lawindi


Re: Review Request 40851: Windows:[1/2] Add patch for Windows ZK version.

Posted by M Lawindi <ml...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40851/
-----------------------------------------------------------

(Updated Jan. 29, 2016, 2:17 a.m.)


Review request for Alex Naparu, Dario Bazan, Daniel Pravat, Alex Clemmer, and M Lawindi.


Bugs: MESOS-4497
    https://issues.apache.org/jira/browse/MESOS-4497


Repository: mesos


Description
-------

Windows:[1/2] Add patch for Windows ZK version.


Diffs
-----

  3rdparty/zookeeper-06d3f3f.patch PRE-CREATION 

Diff: https://reviews.apache.org/r/40851/diff/


Testing
-------

- Applied patch to original zookeeper 3.4.5
- Successfully opened 2015 solution in VS2015
- Cli and Zookeeper build successfully


Thanks,

M Lawindi


Re: Review Request 40851: Windows:[1/2] Add patch for Windows ZK version.

Posted by M Lawindi <ml...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40851/
-----------------------------------------------------------

(Updated Jan. 28, 2016, 4:59 a.m.)


Review request for Alex Naparu, Dario Bazan, Daniel Pravat, Alex Clemmer, and M Lawindi.


Repository: mesos


Description
-------

Windows:[1/2] Add patch for Windows ZK version.


Diffs (updated)
-----

  3rdparty/zookeeper-06d3f3f.patch PRE-CREATION 

Diff: https://reviews.apache.org/r/40851/diff/


Testing
-------

- Applied patch to original zookeeper 3.4.5
- Successfully opened 2015 solution in VS2015
- Cli and Zookeeper build successfully


Thanks,

M Lawindi


Re: Review Request 40851: Windows:[1/2] Add patch for Windows ZK version.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40851/#review116638
-----------------------------------------------------------


Ship it!




Ship It!

- Alex Clemmer


On Jan. 27, 2016, 10:29 p.m., M Lawindi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40851/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 10:29 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Dario Bazan, Daniel Pravat, Alex Clemmer, and M Lawindi.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows:[1/2] Add patch for Windows ZK version.
> 
> 
> Diffs
> -----
> 
>   3rdparty/zookeeper-06d3f3f.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40851/diff/
> 
> 
> Testing
> -------
> 
> - Applied patch to original zookeeper 3.4.5
> - Successfully opened 2015 solution in VS2015
> - Cli and Zookeeper build successfully
> 
> 
> Thanks,
> 
> M Lawindi
> 
>