[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1668: [CELEBORN-756][WORKER] Refactor `PushDataHandler` class to utilize `while` loop

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #1668:
URL: https://github.com/apache/incubator-celeborn/pull/1668#discussion_r1247636266


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/FlushTask.scala:
##########
@@ -34,10 +34,13 @@ private[worker] class LocalFlushTask(
     notifier: FlushNotifier) extends FlushTask(buffer, notifier) {
   override def flush(): Unit = {
     val buffers = buffer.nioBuffers()
-    for (buffer <- buffers) {

Review Comment:
   have you observed the bottleneck here? the body looks like a IO heavy operation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org