You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/25 08:18:50 UTC

[GitHub] [doris] morningman opened a new pull request, #15346: [improvement](jdbc) add default jdbc driver's dir

morningman opened a new pull request, #15346:
URL: https://github.com/apache/doris/pull/15346

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Add a new config "jdbc_drivers_dir" for both FE and BE.
   User can put jdbc drivers' jar file in this dir, and only specify file name in "driver_url" properties
   when creating jdbc resource.
   And Doris will find jar files in this dir.
   
   Also modify the logic so that when the jdbc resource is modified, the corresponding jdbc table
   will get the latest properties.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #15346: [improvement](jdbc) add default jdbc driver's dir

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15346:
URL: https://github.com/apache/doris/pull/15346#issuecomment-1364651774

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 34.4 seconds
    load time: 646 seconds
    storage size: 17123651615 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221225092629_clickbench_pr_68394.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #15346: [improvement](jdbc) add default jdbc driver's dir

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15346:
URL: https://github.com/apache/doris/pull/15346#issuecomment-1364685063

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #15346: [improvement](jdbc) add default jdbc driver's dir

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15346:
URL: https://github.com/apache/doris/pull/15346


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #15346: [improvement](jdbc) add default jdbc driver's dir

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15346:
URL: https://github.com/apache/doris/pull/15346#issuecomment-1364648912

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #15346: [improvement](jdbc) add default jdbc driver's dir

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15346:
URL: https://github.com/apache/doris/pull/15346#issuecomment-1364643802

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org