You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2015/04/13 19:55:04 UTC
[1/2] incubator-tinkerpop git commit: Finalize some local variables
in CoreTraversalTest.
Repository: incubator-tinkerpop
Updated Branches:
refs/heads/master 975004cc4 -> 8d968fdab
Finalize some local variables in CoreTraversalTest.
Project: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/commit/fe65dec7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/tree/fe65dec7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/diff/fe65dec7
Branch: refs/heads/master
Commit: fe65dec76c6adcd4da7c23539da172474fb69ecd
Parents: 975004c
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Mon Apr 13 13:47:09 2015 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Mon Apr 13 13:47:09 2015 -0400
----------------------------------------------------------------------
.../process/traversal/CoreTraversalTest.java | 22 ++++++++++----------
1 file changed, 11 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/fe65dec7/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/CoreTraversalTest.java
----------------------------------------------------------------------
diff --git a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/CoreTraversalTest.java b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/CoreTraversalTest.java
index 75216a1..c98489a 100644
--- a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/CoreTraversalTest.java
+++ b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/CoreTraversalTest.java
@@ -53,9 +53,9 @@ public class CoreTraversalTest extends AbstractGremlinProcessTest {
@Test
@LoadGraphWith(MODERN)
public void shouldLoadVerticesViaIds() {
- List<Vertex> vertices = g.V().toList();
- List<Object> ids = vertices.stream().map(v->v.id()).collect(Collectors.toList());
- List<Vertex> verticesReloaded = g.V(ids.toArray()).toList();
+ final List<Vertex> vertices = g.V().toList();
+ final List<Object> ids = vertices.stream().map(v->v.id()).collect(Collectors.toList());
+ final List<Vertex> verticesReloaded = g.V(ids.toArray()).toList();
assertEquals(vertices.size(), verticesReloaded.size());
assertEquals(new HashSet<>(vertices), new HashSet<>(verticesReloaded));
}
@@ -63,9 +63,9 @@ public class CoreTraversalTest extends AbstractGremlinProcessTest {
@Test
@LoadGraphWith(MODERN)
public void shouldLoadEdgesViaIds() {
- List<Edge> edges = g.E().toList();
- List<Object> ids = edges.stream().map(e->e.id()).collect(Collectors.toList());
- List<Edge> edgesReloaded = g.E(ids.toArray()).toList();
+ final List<Edge> edges = g.E().toList();
+ final List<Object> ids = edges.stream().map(e->e.id()).collect(Collectors.toList());
+ final List<Edge> edgesReloaded = g.E(ids.toArray()).toList();
assertEquals(edges.size(), edgesReloaded.size());
assertEquals(new HashSet<>(edges), new HashSet<>(edgesReloaded));
}
@@ -73,8 +73,8 @@ public class CoreTraversalTest extends AbstractGremlinProcessTest {
@Test
@LoadGraphWith(MODERN)
public void shouldLoadVerticesViaVertices() {
- List<Vertex> vertices = g.V().toList();
- List<Vertex> verticesReloaded = g.V(vertices.toArray()).toList();
+ final List<Vertex> vertices = g.V().toList();
+ final List<Vertex> verticesReloaded = g.V(vertices.toArray()).toList();
assertEquals(vertices.size(), verticesReloaded.size());
assertEquals(new HashSet<>(vertices), new HashSet<>(verticesReloaded));
}
@@ -82,8 +82,8 @@ public class CoreTraversalTest extends AbstractGremlinProcessTest {
@Test
@LoadGraphWith(MODERN)
public void shouldLoadEdgesViaEdges() {
- List<Edge> edges = g.E().toList();
- List<Edge> edgesReloaded = g.E(edges.toArray()).toList();
+ final List<Edge> edges = g.E().toList();
+ final List<Edge> edgesReloaded = g.E(edges.toArray()).toList();
assertEquals(edges.size(), edgesReloaded.size());
assertEquals(new HashSet<>(edges), new HashSet<>(edgesReloaded));
}
@@ -91,7 +91,7 @@ public class CoreTraversalTest extends AbstractGremlinProcessTest {
@Test
@LoadGraphWith(MODERN)
public void shouldThrowExceptionWhenIdsMixed() {
- List<Vertex> vertices = g.V().toList();
+ final List<Vertex> vertices = g.V().toList();
try {
g.V(vertices.get(0), vertices.get(1).id()).toList();
} catch (Exception ex) {
[2/2] incubator-tinkerpop git commit: Finalize some variables in the
process VertexTest
Posted by sp...@apache.org.
Finalize some variables in the process VertexTest
Project: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/commit/8d968fda
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/tree/8d968fda
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/diff/8d968fda
Branch: refs/heads/master
Commit: 8d968fdabdfc7ddbb39961fe7bfe27790a5d8887
Parents: fe65dec
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Mon Apr 13 13:54:29 2015 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Mon Apr 13 13:54:29 2015 -0400
----------------------------------------------------------------------
.../process/traversal/step/map/VertexTest.java | 56 ++++++++++----------
1 file changed, 27 insertions(+), 29 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/8d968fda/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/VertexTest.java
----------------------------------------------------------------------
diff --git a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/VertexTest.java b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/VertexTest.java
index 60557cf..90a07ec 100644
--- a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/VertexTest.java
+++ b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/VertexTest.java
@@ -103,7 +103,7 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
final Traversal<Vertex, Vertex> traversal = get_g_V();
printTraversalForm(traversal);
int counter = 0;
- Set<Vertex> vertices = new HashSet<>();
+ final Set<Vertex> vertices = new HashSet<>();
while (traversal.hasNext()) {
counter++;
vertices.add(traversal.next());
@@ -122,7 +122,7 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
private void assert_g_v1_out(final Traversal<Vertex, Vertex> traversal) {
printTraversalForm(traversal);
int counter = 0;
- Set<Vertex> vertices = new HashSet<>();
+ final Set<Vertex> vertices = new HashSet<>();
while (traversal.hasNext()) {
counter++;
Vertex vertex = traversal.next();
@@ -158,10 +158,10 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
final Traversal<Vertex, Vertex> traversal = get_g_VX4X_both(convertToVertexId("josh"));
printTraversalForm(traversal);
int counter = 0;
- Set<Vertex> vertices = new HashSet<>();
+ final Set<Vertex> vertices = new HashSet<>();
while (traversal.hasNext()) {
counter++;
- Vertex vertex = traversal.next();
+ final Vertex vertex = traversal.next();
vertices.add(vertex);
assertTrue(vertex.value("name").equals("marko") ||
vertex.value("name").equals("ripple") ||
@@ -179,7 +179,7 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
final Traversal<Edge, Edge> traversal = get_g_E();
printTraversalForm(traversal);
int counter = 0;
- Set<Edge> edges = new HashSet<>();
+ final Set<Edge> edges = new HashSet<>();
while (traversal.hasNext()) {
counter++;
edges.add(traversal.next());
@@ -194,10 +194,10 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
final Traversal<Vertex, Edge> traversal = get_g_VX1X_outE(convertToVertexId("marko"));
printTraversalForm(traversal);
int counter = 0;
- Set<Edge> edges = new HashSet<>();
+ final Set<Edge> edges = new HashSet<>();
while (traversal.hasNext()) {
counter++;
- Edge edge = traversal.next();
+ final Edge edge = traversal.next();
edges.add(edge);
assertTrue(edge.label().equals("knows") || edge.label().equals("created"));
}
@@ -224,10 +224,10 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
final Traversal<Vertex, Edge> traversal = get_g_VX4X_bothEXcreatedX(convertToVertexId("josh"));
printTraversalForm(traversal);
int counter = 0;
- Set<Edge> edges = new HashSet<>();
+ final Set<Edge> edges = new HashSet<>();
while (traversal.hasNext()) {
counter++;
- Edge edge = traversal.next();
+ final Edge edge = traversal.next();
edges.add(edge);
assertTrue(edge.label().equals("created"));
assertEquals(edge.outVertex().id(), convertToVertexId("josh"));
@@ -242,10 +242,10 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
final Traversal<Vertex, Edge> traversal = get_g_VX4X_bothE(convertToVertexId("josh"));
printTraversalForm(traversal);
int counter = 0;
- Set<Edge> edges = new HashSet<>();
+ final Set<Edge> edges = new HashSet<>();
while (traversal.hasNext()) {
counter++;
- Edge edge = traversal.next();
+ final Edge edge = traversal.next();
edges.add(edge);
assertTrue(edge.label().equals("knows") || edge.label().equals("created"));
}
@@ -275,7 +275,7 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
final Traversal<Vertex, Vertex> traversal = get_g_V_outE_hasXweight_1X_outV();
printTraversalForm(traversal);
int counter = 0;
- Map<Object, Integer> counts = new HashMap<>();
+ final Map<Object, Integer> counts = new HashMap<>();
while (traversal.hasNext()) {
final Object id = traversal.next().id();
int previousCount = counts.getOrDefault(id, 0);
@@ -296,10 +296,10 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
final Traversal<Vertex, String> traversal = get_g_V_out_outE_inV_inE_inV_both_name();
printTraversalForm(traversal);
int counter = 0;
- Map<String, Integer> counts = new HashMap<>();
+ final Map<String, Integer> counts = new HashMap<>();
while (traversal.hasNext()) {
final String key = traversal.next();
- int previousCount = counts.getOrDefault(key, 0);
+ final int previousCount = counts.getOrDefault(key, 0);
counts.put(key, previousCount + 1);
counter++;
}
@@ -317,7 +317,7 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
public void g_VX1X_outEXknowsX_bothV_name() {
final Traversal<Vertex, String> traversal = get_g_VX1X_outEXknowsX_bothV_name(convertToVertexId("marko"));
printTraversalForm(traversal);
- List<String> names = traversal.toList();
+ final List<String> names = traversal.toList();
assertEquals(4, names.size());
assertTrue(names.contains("marko"));
assertTrue(names.contains("josh"));
@@ -338,10 +338,10 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
final Traversal<Vertex, Vertex> traversal = get_g_VX1X_outE_otherV(convertToVertexId("marko"));
printTraversalForm(traversal);
int counter = 0;
- Set<Vertex> vertices = new HashSet<>();
+ final Set<Vertex> vertices = new HashSet<>();
while (traversal.hasNext()) {
counter++;
- Vertex vertex = traversal.next();
+ final Vertex vertex = traversal.next();
vertices.add(vertex);
assertTrue(vertex.value("name").equals("vadas") ||
vertex.value("name").equals("josh") ||
@@ -384,13 +384,13 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
assert_g_v1_outXknowsX(traversal);
}
- private void assert_g_v1_outXknowsX(Traversal<Vertex, Vertex> traversal) {
+ private void assert_g_v1_outXknowsX(final Traversal<Vertex, Vertex> traversal) {
printTraversalForm(traversal);
int counter = 0;
- Set<Vertex> vertices = new HashSet<>();
+ final Set<Vertex> vertices = new HashSet<>();
while (traversal.hasNext()) {
counter++;
- Vertex vertex = traversal.next();
+ final Vertex vertex = traversal.next();
vertices.add(vertex);
assertTrue(vertex.value("name").equals("vadas") ||
vertex.value("name").equals("josh"));
@@ -426,10 +426,10 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
final Traversal<Vertex, Vertex> traversal = get_g_V_out_out();
printTraversalForm(traversal);
int counter = 0;
- Set<Vertex> vertices = new HashSet<>();
+ final Set<Vertex> vertices = new HashSet<>();
while (traversal.hasNext()) {
counter++;
- Vertex vertex = traversal.next();
+ final Vertex vertex = traversal.next();
vertices.add(vertex);
assertTrue(vertex.value("name").equals("lop") ||
vertex.value("name").equals("ripple"));
@@ -453,10 +453,10 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
final Traversal<Vertex, String> traversal = get_g_VX1X_out_name(convertToVertexId("marko"));
printTraversalForm(traversal);
int counter = 0;
- Set<String> names = new HashSet<>();
+ final Set<String> names = new HashSet<>();
while (traversal.hasNext()) {
counter++;
- String name = traversal.next();
+ final String name = traversal.next();
names.add(name);
assertTrue(name.equals("vadas") ||
name.equals("josh") ||
@@ -474,14 +474,12 @@ public abstract class VertexTest extends AbstractGremlinProcessTest {
int counter = 0;
while (traversal.hasNext()) {
counter++;
- Vertex vertex = traversal.next();
- String name = vertex.value("name");
- assertTrue(name.equals("vadas") ||
- name.equals("josh"));
+ final Vertex vertex = traversal.next();
+ final String name = vertex.value("name");
+ assertTrue(name.equals("vadas") || name.equals("josh"));
}
assertEquals(2, counter);
assertFalse(traversal.hasNext());
-
}
@UseEngine(TraversalEngine.Type.STANDARD)