You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/08 22:18:10 UTC
[GitHub] [airflow] malthe opened a new issue, #28242: Airflow CLI to list roles is slow
malthe opened a new issue, #28242:
URL: https://github.com/apache/airflow/issues/28242
### Apache Airflow version
2.5.0
### What happened
We're currently running a suboptimal setup where database connectivity is laggy, 125ms roundtrip.
This has interesting consequences. For example, `airflow roles list` is really slow. Turns out that it's doing a lot of individual queries.
### What you think should happen instead
Ideally, listing roles should be a single (perhaps complex) query.
### How to reproduce
We're using py-spy to sample program execution:
```bash
$ py-spy record -o spy.svg -i --rate 250 --nonblocking airflow roles list
```
Now, to see the bad behavior, the database should incur significant latency.
### Operating System
Linux
### Versions of Apache Airflow Providers
_No response_
### Deployment
Official Apache Airflow Helm Chart
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #28242: Airflow CLI to list roles is slow
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #28242:
URL: https://github.com/apache/airflow/issues/28242#issuecomment-1343455451
Correction: We could likely decrease it a bit by removing connexion (REST API) intialization- it seems it contributes to > 50% of the time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] malthe commented on issue #28242: Airflow CLI to list roles is slow
Posted by GitBox <gi...@apache.org>.
malthe commented on issue #28242:
URL: https://github.com/apache/airflow/issues/28242#issuecomment-1343448969
Flamegraph generated using [py-spy](https://github.com/benfred/py-spy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #28242: Airflow CLI to list roles is slow
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #28242: Airflow CLI to list roles is slow
URL: https://github.com/apache/airflow/issues/28242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #28242: Airflow CLI to list roles is slow
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #28242:
URL: https://github.com/apache/airflow/issues/28242#issuecomment-1343454139
I believe there is not much we can do - when you look at the flamegraph it initializes flask and flask-app-builder. Until we replace the user model with somethiing else thanf Flass App Builder, there is not much we can do I am afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #28242: Airflow CLI to list roles is slow
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #28242:
URL: https://github.com/apache/airflow/issues/28242#issuecomment-1343458678
Or maybe we could actually not initialize views ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org