You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Wehner (JIRA)" <ji...@apache.org> on 2007/07/06 15:09:04 UTC
[jira] Created: (WICKET-724) WicketFilter doesn't handle filter
mapping parameter from FilterConfig properly
WicketFilter doesn't handle filter mapping parameter from FilterConfig properly
-------------------------------------------------------------------------------
Key: WICKET-724
URL: https://issues.apache.org/jira/browse/WICKET-724
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.0-beta2
Reporter: Martin Wehner
If the filterMappingUrlPattern Parameter is supplied as initParameter of the filterConfig and the url-pattern is not explicitly read from web.xml by Wicket (i.e. getFilterPath(HttpServletRequest) not getFilterPath(String, InputStream) is used to initialize the filter path), Wicket cuts off two chars ("/*"), not one char ("*") from the end of the pattern and uses that to calculate the relative Path which determines if a Request is to be served by Wicket or not. This makes requests to the application homepage not work in such cases, as getRelativePath() will yields "/", which is not recognized by Wicket as homepage request in isWicketRequest().
Since you can't manually mount the homepage on "/" there's no workaround besides adding an additional slash to the filter pattern ("//*").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-724) WicketFilter doesn't handle filter
mapping parameter from FilterConfig properly
Posted by "Martin Wehner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Wehner updated WICKET-724:
---------------------------------
Attachment: WICKET-724.diff
This is the patch we use in our branch to fix the issue: Only cut off the asterisk, but not the trailing slash (as getFilterPath(String, InputStream) does).
> WicketFilter doesn't handle filter mapping parameter from FilterConfig properly
> -------------------------------------------------------------------------------
>
> Key: WICKET-724
> URL: https://issues.apache.org/jira/browse/WICKET-724
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta2
> Reporter: Martin Wehner
> Attachments: WICKET-724.diff
>
>
> If the filterMappingUrlPattern Parameter is supplied as initParameter of the filterConfig and the url-pattern is not explicitly read from web.xml by Wicket (i.e. getFilterPath(HttpServletRequest) not getFilterPath(String, InputStream) is used to initialize the filter path), Wicket cuts off two chars ("/*"), not one char ("*") from the end of the pattern and uses that to calculate the relative Path which determines if a Request is to be served by Wicket or not. This makes requests to the application homepage not work in such cases, as getRelativePath() will yields "/", which is not recognized by Wicket as homepage request in isWicketRequest().
> Since you can't manually mount the homepage on "/" there's no workaround besides adding an additional slash to the filter pattern ("//*").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-724) WicketFilter doesn't handle filter
mapping parameter from FilterConfig properly
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot resolved WICKET-724.
-----------------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0-beta3
Assignee: Jean-Baptiste Quenot
Fixed, thanks for reporting!
> WicketFilter doesn't handle filter mapping parameter from FilterConfig properly
> -------------------------------------------------------------------------------
>
> Key: WICKET-724
> URL: https://issues.apache.org/jira/browse/WICKET-724
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta2
> Reporter: Martin Wehner
> Assignee: Jean-Baptiste Quenot
> Fix For: 1.3.0-beta3
>
> Attachments: WICKET-724.diff
>
>
> If the filterMappingUrlPattern Parameter is supplied as initParameter of the filterConfig and the url-pattern is not explicitly read from web.xml by Wicket (i.e. getFilterPath(HttpServletRequest) not getFilterPath(String, InputStream) is used to initialize the filter path), Wicket cuts off two chars ("/*"), not one char ("*") from the end of the pattern and uses that to calculate the relative Path which determines if a Request is to be served by Wicket or not. This makes requests to the application homepage not work in such cases, as getRelativePath() will yields "/", which is not recognized by Wicket as homepage request in isWicketRequest().
> Since you can't manually mount the homepage on "/" there's no workaround besides adding an additional slash to the filter pattern ("//*").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.