You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jdanekrh <gi...@git.apache.org> on 2017/08/03 04:54:18 UTC
[GitHub] activemq-artemis pull request #1439: ARTEMIS-1317 Expire messages that got e...
GitHub user jdanekrh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1439
ARTEMIS-1317 Expire messages that got expiredAck() from OpenWire client
This fixes org.apache.activemq.JmsSendReceiveWithMessageExpirationTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdanekrh/activemq-artemis jd_ow_expiry
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1439.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1439
----
commit 62d831fc5f8d99b8fdf2b4c9751c1c753c124b3d
Author: Jiri Danek <jd...@redhat.com>
Date: 2017-08-02T08:19:07Z
ARTEMIS-1317 Expire messages that got expiredAck() from OpenWire client
This fixes org.apache.activemq.JmsSendReceiveWithMessageExpirationTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1439: ARTEMIS-1317 Expire messages that got expiredA...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1439
@jdanekrh did you run the testsuite?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1439: ARTEMIS-1317 Expire messages that got expiredA...
Posted by jdanekrh <gi...@git.apache.org>.
Github user jdanekrh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1439
Yes, I run `mvn -Ptests -Pextra-tests -Popenwire-tests test` which includes integration-tests and activemq5-openwire tests you mentioned I should run.
The fails are either fails that happen "always"", but somehow did not happen in the run with which I was comparing, or they did not happen when I rerun that pariticular test from the IDE afterwards.
## List of fails, before/after PR
```diff
--- <unnamed>
+++ <unnamed>
@@ -1,34 +1,30 @@
-org.apache.activemq.ActiveMQXAConnectionFactoryTest.testRollbackXaErrorCode
-org.apache.activemq.artemis.tests.extras.byteman.BMFailoverTest.testFailoverOnCommit
+org.apache.activemq.ActiveMQXAConnectionFactoryTest.testRollbackXaErrorCode
+org.apache.activemq.artemis.tests.extras.byteman.BMFailoverTest.testFailoverOnCommit
org.apache.activemq.artemis.tests.extras.byteman.BMFailoverTest.testFailoverOnCommit2
org.apache.activemq.artemis.tests.extras.byteman.BMFailoverTest.testFailoverOnReceiveCommit
org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testReceiveLargeMessage
org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testSendLargeMessage
org.apache.activemq.artemis.tests.extras.byteman.RaceOnSyncLargeMessageOverReplication2Test.testSendLargeMessage
org.apache.activemq.artemis.tests.extras.byteman.RaceOnSyncLargeMessageOverReplicationTest.testSendLargeMessage
+org.apache.activemq.artemis.tests.integration.amqp.AmqpReceiverDrainTest.testReceiverCanDrainMessagesQueue
org.apache.activemq.artemis.tests.integration.client.LibaioDependencyCheckTest.testDependency
-org.apache.activemq.artemis.tests.integration.client.NettyConsumerWindowSizeTest.testSlowConsumerNoBuffer
org.apache.activemq.artemis.tests.integration.cluster.failover.AutomaticColocatedQuorumVoteTest.testSimpleDistributionOfBackupsMaxBackupsExceeded[replicated=true]
org.apache.activemq.artemis.tests.integration.cluster.failover.BackupSyncJournalTest.testFailBack
-org.apache.activemq.artemis.tests.integration.cluster.failover.BackupSyncJournalTest.testMessageSyncSimple
-org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedAsynchronousFailoverTest.testTransactional
-org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedFailoverTest.testTransactedMessagesWithConsumerStartedBeforeFailover
-org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageFailoverTest.testFailBack
-org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageWithDelayFailoverTest.testLiveAndBackupLiveComesBack
-org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageWithDelayFailoverTest.testNonTransacted
-org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageWithDelayFailoverTest.testTimeoutOnFailover
+org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedFailoverUsingNodeGroupNameTest.testXAMessagesSentSoRollbackOnEnd2
+org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageFailoverTest.testFailThenReceiveMoreMessagesAfterFailover
+org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedManyMultipleServerFailoverNoNodeGroupNameTest.testStartBackupFirst
+org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedManyMultipleServerFailoverNoNodeGroupNameTest.testStartLiveFirst
org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedManyMultipleServerFailoverNoNodeGroupNameTest.testStartLiveFirst
org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedManyMultipleServerFailoverTest.testStartLiveFirst
-org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedManyMultipleServerFailoverTest.testStartLiveFirst
-org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedPagedFailoverTest.testReplicatedFailback
-org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlUsingCoreTest.testForceFailover
+org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedPagedFailoverTest.testFailBackLiveRestartsBackupIsGone
+org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedPagedFailoverTest.testXAMessagesSentSoRollbackOnEnd2
+org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedWithDelayFailoverTest.testXAMessagesSentSoRollbackOnEnd2
+org.apache.activemq.artemis.tests.integration.divert.DivertTest.testInjectedTransformer
org.apache.activemq.artemis.tests.integration.replication.ReplicationOrderTest.testMixedPersistentAndNonPersistentMessagesOrderWithReplicatedBackup
-org.apache.activemq.artemis.tests.integration.replication.ReplicationOrderTest.testTxMixedPersistentAndNonPersistentMessagesOrderWithReplicatedBackup
org.apache.activemq.artemis.tests.integration.replication.ReplicationTest.testOrderOnNonPersistency
-org.apache.activemq.artemis.tests.integration.replication.ReplicationTest.testSendPacketsWithFailure
org.apache.activemq.artemis.tests.integration.server.AIOFileLockTimeoutTest.testAIOFileLockExpiration
-org.apache.activemq.artemis.tests.integration.server.ExpiryRunnerTest.testExpireConsumeHalf
-org.apache.activemq.artemis.tests.integration.server.ScaleDown3NodeTest.testBasicScaleDownWithDefaultReconnectAttemptsAndLargeMessages
+org.apache.activemq.artemis.tests.integration.ssl.CoreClientOverOneWaySSLTest.testOneWaySSLReloaded[storeType=JCEKS]
+org.apache.activemq.artemis.tests.integration.stomp.v12.StompV12Test.testDurableUnSubscribe
org.apache.activemq.JmsQueueCompositeSendReceiveTest.testDuplicate
org.apache.activemq.JmsQueueCompositeSendReceiveTest.testSendReceive
org.apache.activemq.JmsQueueWildcardSendReceiveTest.testReceiveWildcardQueueEndAsterisk
@@ -40,10 +36,10 @@
org.apache.activemq.JmsRedeliveredTest.testQueueSessionCloseMarksMessageRedelivered
org.apache.activemq.JmsRedeliveredTest.testQueueSessionCloseMarksUnAckedMessageRedelivered
org.apache.activemq.JmsRedeliveredTest.testQueueSessionCloseMarksUnAckedMessageRedelivered
-org.apache.activemq.JmsSendReceiveWithMessageExpirationTest.testConsumeExpiredQueueAndDlq
org.apache.activemq.JmsTopicWildcardSendReceiveTest.testReceiveWildcardTopicMatchDoubleWildcard
org.apache.activemq.QueueConsumerPriorityTest.testQueueConsumerPriority
-org.apache.activemq.transport.tcp.SslBrokerServiceTest.testTopicDurableSubscriptionCanBeRestored
+org.apache.activemq.transport.failover.FailoverComplexClusterTest.testThreeBrokerClusterSingleConnectorBackupFailoverConfig
+org.apache.activemq.transport.tcp.SslBrokerServiceTest.testTopicDispatchIsBroadcast
org.apache.activemq.transport.tcp.SslBrokerServiceTest.testTopicNoLocal {deliveryMode=1}
org.apache.activemq.transport.tcp.SslBrokerServiceTest.testTopicNoLocal {deliveryMode=2}
org.apache.activemq.transport.tcp.SslBrokerServiceTest.testTopicRetroactiveConsumerSeeMessagesBeforeCreation {deliveryMode=1, durableConsumer=false}
@@ -61,7 +57,6 @@
org.apache.activemq.transport.tcp.TcpTransportBrokerTest.testTopicDispatchIsBroadcast
org.apache.activemq.transport.tcp.TcpTransportBrokerTest.testTopicDurableSubscriptionCanBeRestored
org.apache.activemq.transport.tcp.TcpTransportBrokerTest.testTopicNoLocal {deliveryMode=1}
-org.apache.activemq.transport.tcp.TcpTransportBrokerTest.testTopicNoLocal {deliveryMode=2}
org.apache.activemq.transport.tcp.TcpTransportBrokerTest.testTopicRetroactiveConsumerSeeMessagesBeforeCreation {deliveryMode=1, durableConsumer=false}
org.apache.activemq.transport.tcp.TcpTransportBrokerTest.testTopicRetroactiveConsumerSeeMessagesBeforeCreation {deliveryMode=1, durableConsumer=true}
org.apache.activemq.transport.tcp.TcpTransportBrokerTest.testTopicRetroactiveConsumerSeeMessagesBeforeCreation {deliveryMode=2, durableConsumer=false}
```
## My comments
* `org.apache.activemq.ActiveMQXAConnectionFactoryTest.testRollbackXaErrorCode` somehow did not fail in the first run, but it is known issue https://issues.apache.org/jira/browse/ARTEMIS-1249 and it always failed when I rerun this single test later with or without this PR applied
* `org.apache.activemq.artemis.tests.extras.byteman.BMFailoverTest.testFailoverOnCommit` ditto, exept there is not a Jira for it
* `org.apache.activemq.transport.failover.FailoverComplexClusterTest.testThreeBrokerClusterSingleConnectorBackupFailoverConfig` ditto, also no Jira, it fails for me on thread leak check
* `org.apache.activemq.artemis.tests.integration.amqp.AmqpReceiverDrainTest.testReceiverCanDrainMessagesQueue` passes for me in a single test run, with or without PR; should not be affected, since this is AMQP
* `org.apache.activemq.artemis.tests.integration.ssl.CoreClientOverOneWaySSLTest.testOneWaySSLReloaded[storeType=JCEKS]` passed when running as a single test
* `org.apache.activemq.artemis.tests.integration.stomp.v12.StompV12Test.testDurableUnSubscribe` ditto
* `org.apache.activemq.artemis.tests.integration.divert.DivertTest.testInjectedTransformer` dtto, no jira, fails with or without PR applied (with very wierd error "ActiveMQQueueExistsException[errorType=QUEUE_EXISTS message=AMQ119019: Queue already exists myQueue")
* `org.apache.activemq.JmsSendReceiveWithMessageExpirationTest.testConsumeExpiredQueueAndDlq` is now passing
the other tests that failed before and passed after are just flukes, i think
I did not retry the failovers locally. Seems to me that every time a slightly different set fails.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1439: ARTEMIS-1317 Expire messages that got expiredA...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1439
@jdanekrh that's totally fine.. I just wanted to know if I should run the tests before merging.. will merge it now then.. thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1439: ARTEMIS-1317 Expire messages that got e...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1439
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---