[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4557: Fixed instance creation failure on dvswitch when using vlan id 4095

[GitBox <gi...@apache.org>]

Spaceman1984 commented on a change in pull request #4557:
URL: https://github.com/apache/cloudstack/pull/4557#discussion_r553765420



##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -1073,6 +1073,10 @@ public static VMwareDVSPvlanConfigSpec createDVPortPvlanConfigSpec(int vlanId, i
     }
 
     public static VmwareDistributedVirtualSwitchVlanSpec createDVPortVlanSpec(Integer vlanId, String vlanRange) {
+        if (vlanId != null && vlanId == 4095){

Review comment:
       This method is not olnly called when vlanid is null.
   If vid is not null, spvlanid would be evaluated and if spvlanid is null, the method will be called.
   ```
   if (vid == null || spvlanid == null) {
       vlanspec = createDVPortVlanSpec(vid, vlanRange);
       ...
   }
   ```
   I tested this as in the description.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org