You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/23 03:32:04 UTC
[GitHub] [dolphinscheduler] SbloodyS opened a new pull request, #10564: [Fix-10513] Fix the doc of pseudo-cluster mysql installation error
SbloodyS opened a new pull request, #10564:
URL: https://github.com/apache/dolphinscheduler/pull/10564
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
close #10513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS merged pull request #10564: [Fix-10513] Fix the doc of pseudo-cluster mysql installation error
Posted by GitBox <gi...@apache.org>.
SbloodyS merged PR #10564:
URL: https://github.com/apache/dolphinscheduler/pull/10564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10564: [Fix-10513] Fix the doc of pseudo-cluster mysql installation error
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10564:
URL: https://github.com/apache/dolphinscheduler/pull/10564#discussion_r904495397
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -142,7 +142,8 @@ export PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$PYTHON_HOME/bin:
## Initialize the Database
-DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the lib directory of DolphinScheduler, which is `tools/libs/`. Let's take MySQL as an example for how to initialize the database:
+DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
+which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs`. Let's take MySQL as an example for how to initialize the database:
Review Comment:
What do you mean how to use mysql datasource?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10564: [Fix-10513] Fix the doc of pseudo-cluster mysql installation error
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10564:
URL: https://github.com/apache/dolphinscheduler/pull/10564#issuecomment-1163982619
> @SbloodyS Hi, next time merge PR, we should pay more attention to the commit title, this commit title is "fix 10513" now. see [773ebc9](https://github.com/apache/dolphinscheduler/commit/773ebc9e523d1190dcc31ce63878071d3d2847c1)
I'll pay attention next time. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10564: [Fix-10513] Fix the doc of pseudo-cluster mysql installation error
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10564:
URL: https://github.com/apache/dolphinscheduler/pull/10564#discussion_r904494023
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -142,7 +142,8 @@ export PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$PYTHON_HOME/bin:
## Initialize the Database
-DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the lib directory of DolphinScheduler, which is `tools/libs/`. Let's take MySQL as an example for how to initialize the database:
+DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
+which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs`. Let's take MySQL as an example for how to initialize the database:
Review Comment:
The preview desc is correct, because part is **Initialize the Database**. maybe we should a separate part to tell user how to use mysql datasource instead of this part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10564: [Fix-10513] Fix the doc of pseudo-cluster mysql installation error
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10564:
URL: https://github.com/apache/dolphinscheduler/pull/10564#discussion_r904501424
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -142,7 +142,8 @@ export PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$PYTHON_HOME/bin:
## Initialize the Database
-DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the lib directory of DolphinScheduler, which is `tools/libs/`. Let's take MySQL as an example for how to initialize the database:
+DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
+which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs`. Let's take MySQL as an example for how to initialize the database:
Review Comment:
I think [how to](https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/guide/howto/general-setting.html ) is a great place to hold this. we could ad new page and link all relation doc to the new one. for example all installation(including container) and datasource center will face the same question. Actually I already add some related doc in https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/guide/datasource/introduction.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10564: [Fix-10513] Fix the doc of pseudo-cluster mysql installation error
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10564:
URL: https://github.com/apache/dolphinscheduler/pull/10564#discussion_r904499756
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -142,7 +142,8 @@ export PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$PYTHON_HOME/bin:
## Initialize the Database
-DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the lib directory of DolphinScheduler, which is `tools/libs/`. Let's take MySQL as an example for how to initialize the database:
+DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
+which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs`. Let's take MySQL as an example for how to initialize the database:
Review Comment:
use mysql as meta store for dolphinscheduler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10564: [Fix-10513] Fix the doc of pseudo-cluster mysql installation error
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10564:
URL: https://github.com/apache/dolphinscheduler/pull/10564#issuecomment-1163981036
@SbloodyS Hi, next time merge PR, we should pay more attention to the commit title, this commit title is "fix 10513" now. see
https://github.com/apache/dolphinscheduler/commit/773ebc9e523d1190dcc31ce63878071d3d2847c1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org