You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/06/19 22:32:13 UTC
[Impala-ASF-CR] GUTIL: Rename constant to Kudu's value
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10768
Change subject: GUTIL: Rename constant to Kudu's value
......................................................................
GUTIL: Rename constant to Kudu's value
Change-Id: Ib62c8e5b1a916e1d6a6c4472ab9b8dda94330115
---
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/util/error-util.h
3 files changed, 33 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/10768/2
--
To view, visit http://gerrit.cloudera.org:8080/10768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib62c8e5b1a916e1d6a6c4472ab9b8dda94330115
Gerrit-Change-Number: 10768
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] GUTIL: Rename constant to Kudu's value
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/10768 )
Change subject: GUTIL: Rename constant to Kudu's value
......................................................................
Abandoned
Not needed anymore.
--
To view, visit http://gerrit.cloudera.org:8080/10768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib62c8e5b1a916e1d6a6c4472ab9b8dda94330115
Gerrit-Change-Number: 10768
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] GUTIL: Rename constant to Kudu's value
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10768 )
Change subject: GUTIL: Rename constant to Kudu's value
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10768/2/be/src/gutil/strings/substitute.h
File be/src/gutil/strings/substitute.h:
http://gerrit.cloudera.org:8080/#/c/10768/2/be/src/gutil/strings/substitute.h@134
PS2, Line 134: static const SubstituteArg kNoArg;
This substitution is done in Kudu's version of gutil. I changed it on our side to keep the chances for future merge conflicts low.
--
To view, visit http://gerrit.cloudera.org:8080/10768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62c8e5b1a916e1d6a6c4472ab9b8dda94330115
Gerrit-Change-Number: 10768
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 00:54:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] GUTIL: Rename constant to Kudu's value
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10768 )
Change subject: GUTIL: Rename constant to Kudu's value
......................................................................
GUTIL: Rename constant to Kudu's value
Change-Id: Ib62c8e5b1a916e1d6a6c4472ab9b8dda94330115
---
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/util/error-util.h
3 files changed, 33 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/10768/4
--
To view, visit http://gerrit.cloudera.org:8080/10768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib62c8e5b1a916e1d6a6c4472ab9b8dda94330115
Gerrit-Change-Number: 10768
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>