You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by yu...@apache.org on 2022/07/29 02:48:45 UTC

[rocketmq] 02/02: Fix concurrent issues of testScanProducerHeartBeat

This is an automated email from the ASF dual-hosted git repository.

yukon pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git

commit 312599966447cbebcd80b58eca1410e34b414c0a
Author: 尘央 <xi...@alibaba-inc.com>
AuthorDate: Thu Jul 28 21:34:58 2022 +0800

    Fix concurrent issues of testScanProducerHeartBeat
---
 .../service/transaction/ClusterTransactionServiceTest.java     | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/proxy/src/test/java/org/apache/rocketmq/proxy/service/transaction/ClusterTransactionServiceTest.java b/proxy/src/test/java/org/apache/rocketmq/proxy/service/transaction/ClusterTransactionServiceTest.java
index 3f84e972a..f18f1eef3 100644
--- a/proxy/src/test/java/org/apache/rocketmq/proxy/service/transaction/ClusterTransactionServiceTest.java
+++ b/proxy/src/test/java/org/apache/rocketmq/proxy/service/transaction/ClusterTransactionServiceTest.java
@@ -176,13 +176,13 @@ public class ClusterTransactionServiceTest extends BaseServiceTest {
 
         assertEquals(Lists.newArrayList(BROKER_ADDR, BROKER_ADDR, BROKER_ADDR2, BROKER_ADDR2),
             brokerAddrArgumentCaptor.getAllValues().stream().sorted().collect(Collectors.toList()));
+
         List<HeartbeatData> heartbeatDataList = heartbeatDataArgumentCaptor.getAllValues();
-        for (ProducerData producerData : heartbeatDataList.get(0).getProducerDataSet()) {
-            groupSet.remove(producerData.getGroupName());
-        }
 
-        for (ProducerData producerData : heartbeatDataList.get(1).getProducerDataSet()) {
-            groupSet.remove(producerData.getGroupName());
+        for (final HeartbeatData heartbeatData : heartbeatDataList) {
+            for (ProducerData producerData : heartbeatData.getProducerDataSet()) {
+                groupSet.remove(producerData.getGroupName());
+            }
         }
 
         assertTrue(groupSet.isEmpty());