Re: [PR] Remove FileWriterMode and ListingTableInsertMode (#7994) [arrow-datafusion]

["devinjdangelo (via GitHub)" <gi...@apache.org>]

devinjdangelo commented on code in PR #8017:
URL: https://github.com/apache/arrow-datafusion/pull/8017#discussion_r1394996546


##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -214,33 +214,6 @@ impl ListingTableConfig {
     }
 }
 
-#[derive(Debug, Clone)]
-///controls how new data should be inserted to a ListingTable
-pub enum ListingTableInsertMode {
-    ///Data should be appended to an existing file
-    AppendToFile,
-    ///Data is appended as new files in existing TablePaths
-    AppendNewFiles,
-    ///Throw an error if insert into is attempted on this table
-    Error,

Review Comment:
   Removing error is fine by me. A formal access control mechanism would be better than the error mode option.
   
   I do think there is some value to append mode for ListingTable. Specifically it enables tables backed by a single file where inserts append to that file.
   
   This is a relatively niche usecase so I'm not bothered if it is removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org