You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@xmlgraphics.apache.org by Glenn Adams <gl...@skynav.com> on 2012/10/05 15:07:44 UTC
[VOTE] XGC 1.5 and FOP 1.1 Releases
I have posted images for final releases of XGC 1.5 and FOP 1.1 at [1]
and [2], respectively. I would like to initiate a 3-day vote on
publishing these releases.
If I see no negative vote and no comment remains unresolved by OCT11
0800Z, then I will publish to the appropriate sites on OCT15.
[1] http://people.apache.org/~gadams/candidates/xmlgraphics-commons-1_5/
[2] http://people.apache.org/~gadams/candidates/fop-1_1/
The only changes made to these images from the respective RC1 images are:
- update documentation to reflect final version numbers
- update fop/README to simplify and extend summary of feature
changes (per Vincent's suggestion at [3])
- update fop/xmlgraphics-fop-pom-template.xml to sync avalon
version with the version in fop/lib (i.e., 4.2.0, not 4.3.1)
- update fop/build.xml to add release-dist and related targets,
update maven-artifacts target to match xgc build usage
[3] http://mail-archives.apache.org/mod_mbox/xmlgraphics-general/201206.mbox/%3c4FEDFF2D.2010208@gmail.com%3e
Regards,
Glenn
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Same problem actually for
org.apache.xmlgraphics.image.loader.util.ImageUtil.getInputStream()
which was removed rather than deprecated. Note that I know of at least
one user of the image loading framework that does not use FOP. Sorry for
not catching that earlier.
Jeremias Maerki
On 05.10.2012 16:35:45 Jeremias Maerki wrote:
> Thanks for taking the time to do releases!
>
> Sadly, no vote from me but just a couple of comments:
> - The regression fixed in http://svn.apache.org/viewvc?view=revision&revision=1356456
> doesn't seems to have made it into the FOP 1.1 branch. That will hurt
> everyone who's working with font auto-detection.
> - The removal of Glyphs.MAC_GLYPH_NAMES in XGC presents a
> backwards-incompatible change with FOP 1.0. Incidentally, I've just run
> into that one a few minutes ago trying to keep up-to-date on XGC but
> staying on my pre-API-break branch of FOP. Better would have been to
> deprecate it before removing it.
>
> BTW, here's a good read: http://semver.org/
> This is going to very applicable after FOP 1.1.
>
> Jeremias Maerki
>
>
> On 05.10.2012 15:07:44 Glenn Adams wrote:
> > I have posted images for final releases of XGC 1.5 and FOP 1.1 at [1]
> > and [2], respectively. I would like to initiate a 3-day vote on
> > publishing these releases.
> >
> > If I see no negative vote and no comment remains unresolved by OCT11
> > 0800Z, then I will publish to the appropriate sites on OCT15.
> >
> > [1] http://people.apache.org/~gadams/candidates/xmlgraphics-commons-1_5/
> > [2] http://people.apache.org/~gadams/candidates/fop-1_1/
> >
> > The only changes made to these images from the respective RC1 images are:
> >
> >
> > - update documentation to reflect final version numbers
> > - update fop/README to simplify and extend summary of feature
> > changes (per Vincent's suggestion at [3])
> > - update fop/xmlgraphics-fop-pom-template.xml to sync avalon
> > version with the version in fop/lib (i.e., 4.2.0, not 4.3.1)
> > - update fop/build.xml to add release-dist and related targets,
> > update maven-artifacts target to match xgc build usage
> >
> > [3] http://mail-archives.apache.org/mod_mbox/xmlgraphics-general/201206.mbox/%3c4FEDFF2D.2010208@gmail.com%3e
> >
> > Regards,
> > Glenn
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: general-help@xmlgraphics.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Clay Leeds <th...@gmail.com>.
Thanks Glenn and Jeremias for your efforts on this! It's exciting to be so close to another release!
Clay
"My religion is simple. My religion is kindness."
- HH The Dalai Lama of Tibet
On Oct 9, 2012, at 7:05 AM, Glenn Adams <gl...@skynav.com> wrote:
> Thanks! I will take this as you have completed your changes to your
> satisfaction, and perhaps can vote positively for a release. I will
> generate new images and update my vote request in the next few days (I
> happen to be traveling tomorrow so it will take me a little while to do
> this).
>
> G.
>
> On Tue, Oct 9, 2012 at 5:16 PM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
>
>> Done:
>> http://svn.apache.org/viewvc?rev=1395896&view=rev
>> http://svn.apache.org/viewvc?rev=1395925&view=rev
>>
>> Turns out that the ImageUtil.getInputStream() case doesn't apply to the
>> 1.5 branch. This was done after the branching.
>>
>> Thanks for your patience,
>> Jeremias Maerki
>>
>>
>> On 09.10.2012 06:51:32 Glenn Adams wrote:
>>> Jeremias, please go ahead and make these changes on the appropriate
>>> branches, i.e.:
>> https://svn.apache.org/repos/asf/xmlgraphics/commons/branches/commons-1_5
>>> https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/fop-1_1
>>>
>>> Then I'll generate new images along with Vincent's suggestions and start
>> a
>>> new vote.
>>>
>>> On Mon, Oct 8, 2012 at 10:02 PM, Jeremias Maerki <dev@jeremias-maerki.ch
>>> wrote:
>>>
>>>> I'm happy to do the changes myself if nobody objects:
>>>> 1. Restore Glyphs.MAC_GLYPH_NAMES and deprecate it.
>>>> 2. Restore ImageUtil.getInputStream() and deprecate it.
>>>> 3. Cherry-pick the bugfix for the font auto-detection from trunk into
>>>> the 1.1 branch.
>>>>
>>>> As for "necessary": it's not if you always upgrade FOP.jar alongside
>>>> XGC.jar. But that may not always be the case. It's also difficult for
>>>> people to know which JAR works with which other JAR. I keep hearing
>>>> things like: which PDF Plug-in JAR do I have to use when I have FOP
>> 1.0?
>>>> And stuff like that. Also, XGC was intended to be usable and useful
>>>> without FOP. At any rate, the above changes restore full
>>>> backwards-compatibility of XGC 1.5 with XGC 1.0 to 1.4. And they will
>>>> avoid trouble for people using font auto-detection.
>>>>
>>>> Jeremias Maerki
>>>>
>>>>
>>>> On 08.10.2012 14:52:26 Glenn Adams wrote:
>>>>> On Mon, Oct 8, 2012 at 4:37 PM, Jeremias Maerki <
>> dev@jeremias-maerki.ch
>>>>> wrote:
>>>>>
>>>>>> I don't think these changes constitute substantive changes. They
>> do not
>>>>>> add new functionality or otherwise create a significant risk for
>>>>>> instability. They are merely bugfixes. The major motivation for
>> fixing
>>>>>> these IMO is in making everyone's life easier: Users will download
>> FOP
>>>>>> 1.1 and run into font auto-detection problems and others will have
>> to
>>>>>> help them.
>>>>>
>>>>> It's a matter of degree. It is substantive in the sense that it is a
>> code
>>>>> change [1]. It is also true that it is a very trivial change, and one
>>>> that
>>>>> I'm completely fine with making at this stage.
>>>>>
>>>>> Is this change sufficient to address your concerns about the
>> usability of
>>>>> 1.1? Do you also believe that a reversion to a change on
>>>> Glyphs.MAC_GLYPH_NAMES
>>>>> is necessary? If so, could you provide a minimal patch that makes
>> what
>>>> you
>>>>> believe is needed?
>>>>>
>>>>> If others do not object, then I could apply [1] and this additional
>> patch
>>>>> and upload a new set of images.
>>>>>
>>>>> [1]
>> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java?r1=1356456&r2=1356455&pathrev=1356456
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
>>>> For additional commands, e-mail: general-help@xmlgraphics.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
>> For additional commands, e-mail: general-help@xmlgraphics.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Glenn Adams <gl...@skynav.com>.
Thanks! I will take this as you have completed your changes to your
satisfaction, and perhaps can vote positively for a release. I will
generate new images and update my vote request in the next few days (I
happen to be traveling tomorrow so it will take me a little while to do
this).
G.
On Tue, Oct 9, 2012 at 5:16 PM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
> Done:
> http://svn.apache.org/viewvc?rev=1395896&view=rev
> http://svn.apache.org/viewvc?rev=1395925&view=rev
>
> Turns out that the ImageUtil.getInputStream() case doesn't apply to the
> 1.5 branch. This was done after the branching.
>
> Thanks for your patience,
> Jeremias Maerki
>
>
> On 09.10.2012 06:51:32 Glenn Adams wrote:
> > Jeremias, please go ahead and make these changes on the appropriate
> > branches, i.e.:
> >
> >
> https://svn.apache.org/repos/asf/xmlgraphics/commons/branches/commons-1_5
> > https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/fop-1_1
> >
> > Then I'll generate new images along with Vincent's suggestions and start
> a
> > new vote.
> >
> > On Mon, Oct 8, 2012 at 10:02 PM, Jeremias Maerki <dev@jeremias-maerki.ch
> >wrote:
> >
> > > I'm happy to do the changes myself if nobody objects:
> > > 1. Restore Glyphs.MAC_GLYPH_NAMES and deprecate it.
> > > 2. Restore ImageUtil.getInputStream() and deprecate it.
> > > 3. Cherry-pick the bugfix for the font auto-detection from trunk into
> > > the 1.1 branch.
> > >
> > > As for "necessary": it's not if you always upgrade FOP.jar alongside
> > > XGC.jar. But that may not always be the case. It's also difficult for
> > > people to know which JAR works with which other JAR. I keep hearing
> > > things like: which PDF Plug-in JAR do I have to use when I have FOP
> 1.0?
> > > And stuff like that. Also, XGC was intended to be usable and useful
> > > without FOP. At any rate, the above changes restore full
> > > backwards-compatibility of XGC 1.5 with XGC 1.0 to 1.4. And they will
> > > avoid trouble for people using font auto-detection.
> > >
> > > Jeremias Maerki
> > >
> > >
> > > On 08.10.2012 14:52:26 Glenn Adams wrote:
> > > > On Mon, Oct 8, 2012 at 4:37 PM, Jeremias Maerki <
> dev@jeremias-maerki.ch
> > > >wrote:
> > > >
> > > > > I don't think these changes constitute substantive changes. They
> do not
> > > > > add new functionality or otherwise create a significant risk for
> > > > > instability. They are merely bugfixes. The major motivation for
> fixing
> > > > > these IMO is in making everyone's life easier: Users will download
> FOP
> > > > > 1.1 and run into font auto-detection problems and others will have
> to
> > > > > help them.
> > > > >
> > > >
> > > > It's a matter of degree. It is substantive in the sense that it is a
> code
> > > > change [1]. It is also true that it is a very trivial change, and one
> > > that
> > > > I'm completely fine with making at this stage.
> > > >
> > > > Is this change sufficient to address your concerns about the
> usability of
> > > > 1.1? Do you also believe that a reversion to a change on
> > > Glyphs.MAC_GLYPH_NAMES
> > > > is necessary? If so, could you provide a minimal patch that makes
> what
> > > you
> > > > believe is needed?
> > > >
> > > > If others do not object, then I could apply [1] and this additional
> patch
> > > > and upload a new set of images.
> > > >
> > > > [1]
> > > >
> > >
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java?r1=1356456&r2=1356455&pathrev=1356456
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
> > > For additional commands, e-mail: general-help@xmlgraphics.apache.org
> > >
> > >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: general-help@xmlgraphics.apache.org
>
>
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Done:
http://svn.apache.org/viewvc?rev=1395896&view=rev
http://svn.apache.org/viewvc?rev=1395925&view=rev
Turns out that the ImageUtil.getInputStream() case doesn't apply to the
1.5 branch. This was done after the branching.
Thanks for your patience,
Jeremias Maerki
On 09.10.2012 06:51:32 Glenn Adams wrote:
> Jeremias, please go ahead and make these changes on the appropriate
> branches, i.e.:
>
> https://svn.apache.org/repos/asf/xmlgraphics/commons/branches/commons-1_5
> https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/fop-1_1
>
> Then I'll generate new images along with Vincent's suggestions and start a
> new vote.
>
> On Mon, Oct 8, 2012 at 10:02 PM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
>
> > I'm happy to do the changes myself if nobody objects:
> > 1. Restore Glyphs.MAC_GLYPH_NAMES and deprecate it.
> > 2. Restore ImageUtil.getInputStream() and deprecate it.
> > 3. Cherry-pick the bugfix for the font auto-detection from trunk into
> > the 1.1 branch.
> >
> > As for "necessary": it's not if you always upgrade FOP.jar alongside
> > XGC.jar. But that may not always be the case. It's also difficult for
> > people to know which JAR works with which other JAR. I keep hearing
> > things like: which PDF Plug-in JAR do I have to use when I have FOP 1.0?
> > And stuff like that. Also, XGC was intended to be usable and useful
> > without FOP. At any rate, the above changes restore full
> > backwards-compatibility of XGC 1.5 with XGC 1.0 to 1.4. And they will
> > avoid trouble for people using font auto-detection.
> >
> > Jeremias Maerki
> >
> >
> > On 08.10.2012 14:52:26 Glenn Adams wrote:
> > > On Mon, Oct 8, 2012 at 4:37 PM, Jeremias Maerki <dev@jeremias-maerki.ch
> > >wrote:
> > >
> > > > I don't think these changes constitute substantive changes. They do not
> > > > add new functionality or otherwise create a significant risk for
> > > > instability. They are merely bugfixes. The major motivation for fixing
> > > > these IMO is in making everyone's life easier: Users will download FOP
> > > > 1.1 and run into font auto-detection problems and others will have to
> > > > help them.
> > > >
> > >
> > > It's a matter of degree. It is substantive in the sense that it is a code
> > > change [1]. It is also true that it is a very trivial change, and one
> > that
> > > I'm completely fine with making at this stage.
> > >
> > > Is this change sufficient to address your concerns about the usability of
> > > 1.1? Do you also believe that a reversion to a change on
> > Glyphs.MAC_GLYPH_NAMES
> > > is necessary? If so, could you provide a minimal patch that makes what
> > you
> > > believe is needed?
> > >
> > > If others do not object, then I could apply [1] and this additional patch
> > > and upload a new set of images.
> > >
> > > [1]
> > >
> > http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java?r1=1356456&r2=1356455&pathrev=1356456
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
> > For additional commands, e-mail: general-help@xmlgraphics.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Glenn Adams <gl...@skynav.com>.
Jeremias, please go ahead and make these changes on the appropriate
branches, i.e.:
https://svn.apache.org/repos/asf/xmlgraphics/commons/branches/commons-1_5
https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/fop-1_1
Then I'll generate new images along with Vincent's suggestions and start a
new vote.
On Mon, Oct 8, 2012 at 10:02 PM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
> I'm happy to do the changes myself if nobody objects:
> 1. Restore Glyphs.MAC_GLYPH_NAMES and deprecate it.
> 2. Restore ImageUtil.getInputStream() and deprecate it.
> 3. Cherry-pick the bugfix for the font auto-detection from trunk into
> the 1.1 branch.
>
> As for "necessary": it's not if you always upgrade FOP.jar alongside
> XGC.jar. But that may not always be the case. It's also difficult for
> people to know which JAR works with which other JAR. I keep hearing
> things like: which PDF Plug-in JAR do I have to use when I have FOP 1.0?
> And stuff like that. Also, XGC was intended to be usable and useful
> without FOP. At any rate, the above changes restore full
> backwards-compatibility of XGC 1.5 with XGC 1.0 to 1.4. And they will
> avoid trouble for people using font auto-detection.
>
> Jeremias Maerki
>
>
> On 08.10.2012 14:52:26 Glenn Adams wrote:
> > On Mon, Oct 8, 2012 at 4:37 PM, Jeremias Maerki <dev@jeremias-maerki.ch
> >wrote:
> >
> > > I don't think these changes constitute substantive changes. They do not
> > > add new functionality or otherwise create a significant risk for
> > > instability. They are merely bugfixes. The major motivation for fixing
> > > these IMO is in making everyone's life easier: Users will download FOP
> > > 1.1 and run into font auto-detection problems and others will have to
> > > help them.
> > >
> >
> > It's a matter of degree. It is substantive in the sense that it is a code
> > change [1]. It is also true that it is a very trivial change, and one
> that
> > I'm completely fine with making at this stage.
> >
> > Is this change sufficient to address your concerns about the usability of
> > 1.1? Do you also believe that a reversion to a change on
> Glyphs.MAC_GLYPH_NAMES
> > is necessary? If so, could you provide a minimal patch that makes what
> you
> > believe is needed?
> >
> > If others do not object, then I could apply [1] and this additional patch
> > and upload a new set of images.
> >
> > [1]
> >
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java?r1=1356456&r2=1356455&pathrev=1356456
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: general-help@xmlgraphics.apache.org
>
>
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
I'm happy to do the changes myself if nobody objects:
1. Restore Glyphs.MAC_GLYPH_NAMES and deprecate it.
2. Restore ImageUtil.getInputStream() and deprecate it.
3. Cherry-pick the bugfix for the font auto-detection from trunk into
the 1.1 branch.
As for "necessary": it's not if you always upgrade FOP.jar alongside
XGC.jar. But that may not always be the case. It's also difficult for
people to know which JAR works with which other JAR. I keep hearing
things like: which PDF Plug-in JAR do I have to use when I have FOP 1.0?
And stuff like that. Also, XGC was intended to be usable and useful
without FOP. At any rate, the above changes restore full
backwards-compatibility of XGC 1.5 with XGC 1.0 to 1.4. And they will
avoid trouble for people using font auto-detection.
Jeremias Maerki
On 08.10.2012 14:52:26 Glenn Adams wrote:
> On Mon, Oct 8, 2012 at 4:37 PM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
>
> > I don't think these changes constitute substantive changes. They do not
> > add new functionality or otherwise create a significant risk for
> > instability. They are merely bugfixes. The major motivation for fixing
> > these IMO is in making everyone's life easier: Users will download FOP
> > 1.1 and run into font auto-detection problems and others will have to
> > help them.
> >
>
> It's a matter of degree. It is substantive in the sense that it is a code
> change [1]. It is also true that it is a very trivial change, and one that
> I'm completely fine with making at this stage.
>
> Is this change sufficient to address your concerns about the usability of
> 1.1? Do you also believe that a reversion to a change on Glyphs.MAC_GLYPH_NAMES
> is necessary? If so, could you provide a minimal patch that makes what you
> believe is needed?
>
> If others do not object, then I could apply [1] and this additional patch
> and upload a new set of images.
>
> [1]
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java?r1=1356456&r2=1356455&pathrev=1356456
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by mehdi houshmand <me...@gmail.com>.
I don't know how much my input matters here, but having spent quite a while
in the fonts packages I concur with Jeremias, putting MAC_GLYPH_NAMES back
in, doesn't have a major impact.
I should note, for future, we need to be more clear as to what constitutes
the public API. It may be prudent to do with XGC what we did with FOP and
make the "public" API explicit to all devs. Simply using the "public"
access modifier doesn't make something part of the public API. Conversely,
as Jeremias has pointed out, we have to be diligent and open when making
changes to the API.
Mehdi
On 8 October 2012 14:40, Chris Bowditch <bo...@hotmail.com> wrote:
> On 08/10/2012 13:52, Glenn Adams wrote:
>
> Hi Glenn,
>
> On Mon, Oct 8, 2012 at 4:37 PM, Jeremias Maerki <dev@jeremias-maerki.ch
>> >wrote:
>>
>> I don't think these changes constitute substantive changes. They do not
>>> add new functionality or otherwise create a significant risk for
>>> instability. They are merely bugfixes. The major motivation for fixing
>>> these IMO is in making everyone's life easier: Users will download FOP
>>> 1.1 and run into font auto-detection problems and others will have to
>>> help them.
>>>
>>
> Thanks for preparing the release. I have downloaded it and run a basic FO
> and all appears to be working ok.
>
> I concur with your understanding that we were only planning to fix low
> risk critical bugs between 1.1rc and 1.1 final. To my recollection the only
> bug I am aware of being fixed was in the pdf-plugin to make it compatible
> with 1.1. We probably need to release the plug-in too soon after FOP and
> XGC.
>
>
> It's a matter of degree. It is substantive in the sense that it is a code
>> change [1]. It is also true that it is a very trivial change, and one that
>> I'm completely fine with making at this stage.
>>
>
> I'm ok with bringing in bug fixes to 1.1 final if they are critical and
> low risk. It just a shame this was bought up so late in the release process.
>
>
>
>> Is this change sufficient to address your concerns about the usability of
>> 1.1? Do you also believe that a reversion to a change on
>> Glyphs.MAC_GLYPH_NAMES
>> is necessary? If so, could you provide a minimal patch that makes what you
>> believe is needed?
>>
>> If others do not object, then I could apply [1] and this additional patch
>> and upload a new set of images.
>>
>
> It's fine with me if you think it is critical and low risk. Otherwise it
> should probably wait until the next major release.
>
> Thanks,
>
> Chris
>
>
>> [1]
>> http://svn.apache.org/viewvc/**xmlgraphics/fop/trunk/src/**
>> java/org/apache/fop/fonts/**truetype/TTFFile.java?r1=**
>> 1356456&r2=1356455&pathrev=**1356456<http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java?r1=1356456&r2=1356455&pathrev=1356456>
>>
>>
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: general-unsubscribe@**xmlgraphics.apache.org<ge...@xmlgraphics.apache.org>
> For additional commands, e-mail: general-help@xmlgraphics.**apache.org<ge...@xmlgraphics.apache.org>
>
>
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Chris Bowditch <bo...@hotmail.com>.
On 08/10/2012 13:52, Glenn Adams wrote:
Hi Glenn,
> On Mon, Oct 8, 2012 at 4:37 PM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
>
>> I don't think these changes constitute substantive changes. They do not
>> add new functionality or otherwise create a significant risk for
>> instability. They are merely bugfixes. The major motivation for fixing
>> these IMO is in making everyone's life easier: Users will download FOP
>> 1.1 and run into font auto-detection problems and others will have to
>> help them.
Thanks for preparing the release. I have downloaded it and run a basic
FO and all appears to be working ok.
I concur with your understanding that we were only planning to fix low
risk critical bugs between 1.1rc and 1.1 final. To my recollection the
only bug I am aware of being fixed was in the pdf-plugin to make it
compatible with 1.1. We probably need to release the plug-in too soon
after FOP and XGC.
> It's a matter of degree. It is substantive in the sense that it is a code
> change [1]. It is also true that it is a very trivial change, and one that
> I'm completely fine with making at this stage.
I'm ok with bringing in bug fixes to 1.1 final if they are critical and
low risk. It just a shame this was bought up so late in the release process.
>
> Is this change sufficient to address your concerns about the usability of
> 1.1? Do you also believe that a reversion to a change on Glyphs.MAC_GLYPH_NAMES
> is necessary? If so, could you provide a minimal patch that makes what you
> believe is needed?
>
> If others do not object, then I could apply [1] and this additional patch
> and upload a new set of images.
It's fine with me if you think it is critical and low risk. Otherwise it
should probably wait until the next major release.
Thanks,
Chris
>
> [1]
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java?r1=1356456&r2=1356455&pathrev=1356456
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Glenn Adams <gl...@skynav.com>.
On Mon, Oct 8, 2012 at 4:37 PM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
> I don't think these changes constitute substantive changes. They do not
> add new functionality or otherwise create a significant risk for
> instability. They are merely bugfixes. The major motivation for fixing
> these IMO is in making everyone's life easier: Users will download FOP
> 1.1 and run into font auto-detection problems and others will have to
> help them.
>
It's a matter of degree. It is substantive in the sense that it is a code
change [1]. It is also true that it is a very trivial change, and one that
I'm completely fine with making at this stage.
Is this change sufficient to address your concerns about the usability of
1.1? Do you also believe that a reversion to a change on Glyphs.MAC_GLYPH_NAMES
is necessary? If so, could you provide a minimal patch that makes what you
believe is needed?
If others do not object, then I could apply [1] and this additional patch
and upload a new set of images.
[1]
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java?r1=1356456&r2=1356455&pathrev=1356456
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Hi Glenn,
I don't think these changes constitute substantive changes. They do not
add new functionality or otherwise create a significant risk for
instability. They are merely bugfixes. The major motivation for fixing
these IMO is in making everyone's life easier: Users will download FOP
1.1 and run into font auto-detection problems and others will have to
help them.
Jeremias Maerki
On 05.10.2012 18:31:37 Glenn Adams wrote:
> I personally have no issue with fixing these before we go final with 1.1;
> however, it has been expressed to me that it would be preferred to not make
> any further substantive changes between 1.1rc1 and 1.1.
>
> It seems like we could either try to get these fixes into 1.1, incurring
> some delay to perform an RC2 phase, or we could go final with 1.1 and then
> attempt to move quickly to a 1.2rc1 that not only fixes these issues, but
> catches up with recent trunk changes as well. My preference is to do the
> latter. But if folks prefer the former, I don't mind doing that either. I
> just think we may get more rapid progress by doing the latter than the
> former.
>
> On Fri, Oct 5, 2012 at 10:35 PM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
>
> > Thanks for taking the time to do releases!
> >
> > Sadly, no vote from me but just a couple of comments:
> > - The regression fixed in
> > http://svn.apache.org/viewvc?view=revision&revision=1356456
> > doesn't seems to have made it into the FOP 1.1 branch. That will hurt
> > everyone who's working with font auto-detection.
> > - The removal of Glyphs.MAC_GLYPH_NAMES in XGC presents a
> > backwards-incompatible change with FOP 1.0. Incidentally, I've just run
> > into that one a few minutes ago trying to keep up-to-date on XGC but
> > staying on my pre-API-break branch of FOP. Better would have been to
> > deprecate it before removing it.
> >
> > BTW, here's a good read: http://semver.org/
> > This is going to very applicable after FOP 1.1.
> >
> > Jeremias Maerki
> >
> >
> > On 05.10.2012 15:07:44 Glenn Adams wrote:
> > > I have posted images for final releases of XGC 1.5 and FOP 1.1 at [1]
> > > and [2], respectively. I would like to initiate a 3-day vote on
> > > publishing these releases.
> > >
> > > If I see no negative vote and no comment remains unresolved by OCT11
> > > 0800Z, then I will publish to the appropriate sites on OCT15.
> > >
> > > [1] http://people.apache.org/~gadams/candidates/xmlgraphics-commons-1_5/
> > > [2] http://people.apache.org/~gadams/candidates/fop-1_1/
> > >
> > > The only changes made to these images from the respective RC1 images are:
> > >
> > >
> > > - update documentation to reflect final version numbers
> > > - update fop/README to simplify and extend summary of feature
> > > changes (per Vincent's suggestion at [3])
> > > - update fop/xmlgraphics-fop-pom-template.xml to sync avalon
> > > version with the version in fop/lib (i.e., 4.2.0, not 4.3.1)
> > > - update fop/build.xml to add release-dist and related targets,
> > > update maven-artifacts target to match xgc build usage
> > >
> > > [3]
> > http://mail-archives.apache.org/mod_mbox/xmlgraphics-general/201206.mbox/%3c4FEDFF2D.2010208@gmail.com%3e
> > >
> > > Regards,
> > > Glenn
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
> > For additional commands, e-mail: general-help@xmlgraphics.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Glenn Adams <gl...@skynav.com>.
I personally have no issue with fixing these before we go final with 1.1;
however, it has been expressed to me that it would be preferred to not make
any further substantive changes between 1.1rc1 and 1.1.
It seems like we could either try to get these fixes into 1.1, incurring
some delay to perform an RC2 phase, or we could go final with 1.1 and then
attempt to move quickly to a 1.2rc1 that not only fixes these issues, but
catches up with recent trunk changes as well. My preference is to do the
latter. But if folks prefer the former, I don't mind doing that either. I
just think we may get more rapid progress by doing the latter than the
former.
On Fri, Oct 5, 2012 at 10:35 PM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
> Thanks for taking the time to do releases!
>
> Sadly, no vote from me but just a couple of comments:
> - The regression fixed in
> http://svn.apache.org/viewvc?view=revision&revision=1356456
> doesn't seems to have made it into the FOP 1.1 branch. That will hurt
> everyone who's working with font auto-detection.
> - The removal of Glyphs.MAC_GLYPH_NAMES in XGC presents a
> backwards-incompatible change with FOP 1.0. Incidentally, I've just run
> into that one a few minutes ago trying to keep up-to-date on XGC but
> staying on my pre-API-break branch of FOP. Better would have been to
> deprecate it before removing it.
>
> BTW, here's a good read: http://semver.org/
> This is going to very applicable after FOP 1.1.
>
> Jeremias Maerki
>
>
> On 05.10.2012 15:07:44 Glenn Adams wrote:
> > I have posted images for final releases of XGC 1.5 and FOP 1.1 at [1]
> > and [2], respectively. I would like to initiate a 3-day vote on
> > publishing these releases.
> >
> > If I see no negative vote and no comment remains unresolved by OCT11
> > 0800Z, then I will publish to the appropriate sites on OCT15.
> >
> > [1] http://people.apache.org/~gadams/candidates/xmlgraphics-commons-1_5/
> > [2] http://people.apache.org/~gadams/candidates/fop-1_1/
> >
> > The only changes made to these images from the respective RC1 images are:
> >
> >
> > - update documentation to reflect final version numbers
> > - update fop/README to simplify and extend summary of feature
> > changes (per Vincent's suggestion at [3])
> > - update fop/xmlgraphics-fop-pom-template.xml to sync avalon
> > version with the version in fop/lib (i.e., 4.2.0, not 4.3.1)
> > - update fop/build.xml to add release-dist and related targets,
> > update maven-artifacts target to match xgc build usage
> >
> > [3]
> http://mail-archives.apache.org/mod_mbox/xmlgraphics-general/201206.mbox/%3c4FEDFF2D.2010208@gmail.com%3e
> >
> > Regards,
> > Glenn
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: general-help@xmlgraphics.apache.org
>
>
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Thanks for taking the time to do releases!
Sadly, no vote from me but just a couple of comments:
- The regression fixed in http://svn.apache.org/viewvc?view=revision&revision=1356456
doesn't seems to have made it into the FOP 1.1 branch. That will hurt
everyone who's working with font auto-detection.
- The removal of Glyphs.MAC_GLYPH_NAMES in XGC presents a
backwards-incompatible change with FOP 1.0. Incidentally, I've just run
into that one a few minutes ago trying to keep up-to-date on XGC but
staying on my pre-API-break branch of FOP. Better would have been to
deprecate it before removing it.
BTW, here's a good read: http://semver.org/
This is going to very applicable after FOP 1.1.
Jeremias Maerki
On 05.10.2012 15:07:44 Glenn Adams wrote:
> I have posted images for final releases of XGC 1.5 and FOP 1.1 at [1]
> and [2], respectively. I would like to initiate a 3-day vote on
> publishing these releases.
>
> If I see no negative vote and no comment remains unresolved by OCT11
> 0800Z, then I will publish to the appropriate sites on OCT15.
>
> [1] http://people.apache.org/~gadams/candidates/xmlgraphics-commons-1_5/
> [2] http://people.apache.org/~gadams/candidates/fop-1_1/
>
> The only changes made to these images from the respective RC1 images are:
>
>
> - update documentation to reflect final version numbers
> - update fop/README to simplify and extend summary of feature
> changes (per Vincent's suggestion at [3])
> - update fop/xmlgraphics-fop-pom-template.xml to sync avalon
> version with the version in fop/lib (i.e., 4.2.0, not 4.3.1)
> - update fop/build.xml to add release-dist and related targets,
> update maven-artifacts target to match xgc build usage
>
> [3] http://mail-archives.apache.org/mod_mbox/xmlgraphics-general/201206.mbox/%3c4FEDFF2D.2010208@gmail.com%3e
>
> Regards,
> Glenn
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Vincent Hennebert <vh...@gmail.com>.
I guess the vote will be re-launched following the implementation of the
proposed changes, so I’ll defer mine for now.
A few things I noticed:
• The vote should be launched against a tagged version of the tree, so
that we can easily verify the artefact signatures and all know what we
are talking about. A tag for XGC should be created first, and the jar
resulting from a build of that tag be put in FOP’s lib directory, and
then the tag for FOP can be created.
• The download page on the website still refers to ‘This Candidate
Release’ and FOP 1.0 as the ‘Latest Stable Release’.
• The compiling page mentions Java 1.4 as a minimum requirement, instead
of Java 1.5
Vincent
On 05/10/12 14:07, Glenn Adams wrote:
> I have posted images for final releases of XGC 1.5 and FOP 1.1 at [1]
> and [2], respectively. I would like to initiate a 3-day vote on
> publishing these releases.
>
> If I see no negative vote and no comment remains unresolved by OCT11
> 0800Z, then I will publish to the appropriate sites on OCT15.
>
> [1] http://people.apache.org/~gadams/candidates/xmlgraphics-commons-1_5/
> [2] http://people.apache.org/~gadams/candidates/fop-1_1/
>
> The only changes made to these images from the respective RC1 images are:
>
>
> - update documentation to reflect final version numbers
> - update fop/README to simplify and extend summary of feature
> changes (per Vincent's suggestion at [3])
> - update fop/xmlgraphics-fop-pom-template.xml to sync avalon
> version with the version in fop/lib (i.e., 4.2.0, not 4.3.1)
> - update fop/build.xml to add release-dist and related targets,
> update maven-artifacts target to match xgc build usage
>
> [3] http://mail-archives.apache.org/mod_mbox/xmlgraphics-general/201206.mbox/%3c4FEDFF2D.2010208@gmail.com%3e
>
> Regards,
> Glenn
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Hi Pascal
I did not veto because releases may not be vetoed:
http://www.apache.org/dev/release.html#approving-a-release
On the version number: I don't know why you bring up 1.1 vs 2.0. If it
was due to my comment on semantic versioning, that only applies to the
trunk after 1.1. IMO, the next version (after 1.1) from trunk cannot be
a 1.2, but must be a 2.0 because of the API changes.
Jeremias Maerki
On 08.10.2012 10:04:20 Pascal Sancho wrote:
> Hi,
>
> +1
> Good job, Glenn (and *all* other contributors).
> From my point of view, current 1.1 branch is ready for a production usage.
> Calling it 1.1 or 2.0 is a little out of date for discussion, and I
> wish to have a new FOP version for now.
>
> @JM: your comment is relevant, so why do you not express your vote,
> your comment is like a veto (At least, it is what I understand), and
> your argument is a good one.
>
> 2012/10/5 Glenn Adams <gl...@skynav.com>:
> > Yes, please do check before you vote.
> >
> > On Fri, Oct 5, 2012 at 11:15 PM, The Web Maestro
> > <th...@gmail.com>wrote:
> >
> >> Thanks for this, Glenn! I'm not ready to VOTE on this yet (I want to
> >> install and run first), but I'll take a look at it over the weekend!
> >>
>
> --
> pascal
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Pascal Sancho <ps...@gmail.com>.
Hi,
+1
Good job, Glenn (and *all* other contributors).
>From my point of view, current 1.1 branch is ready for a production usage.
Calling it 1.1 or 2.0 is a little out of date for discussion, and I
wish to have a new FOP version for now.
@JM: your comment is relevant, so why do you not express your vote,
your comment is like a veto (At least, it is what I understand), and
your argument is a good one.
2012/10/5 Glenn Adams <gl...@skynav.com>:
> Yes, please do check before you vote.
>
> On Fri, Oct 5, 2012 at 11:15 PM, The Web Maestro
> <th...@gmail.com>wrote:
>
>> Thanks for this, Glenn! I'm not ready to VOTE on this yet (I want to
>> install and run first), but I'll take a look at it over the weekend!
>>
--
pascal
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by Glenn Adams <gl...@skynav.com>.
Yes, please do check before you vote.
On Fri, Oct 5, 2012 at 11:15 PM, The Web Maestro
<th...@gmail.com>wrote:
> Thanks for this, Glenn! I'm not ready to VOTE on this yet (I want to
> install and run first), but I'll take a look at it over the weekend!
>
Re: [VOTE] XGC 1.5 and FOP 1.1 Releases
Posted by The Web Maestro <th...@gmail.com>.
Thanks for this, Glenn! I'm not ready to VOTE on this yet (I want to
install and run first), but I'll take a look at it over the weekend!
Kind regards,
Clay Leeds
--
<th...@gmail.com> - <http://ourlil.com/>
My religion is simple. My religion is kindness.
- HH The 14th Dalai Lama of Tibet
On Fri, Oct 5, 2012 at 6:07 AM, Glenn Adams <gl...@skynav.com> wrote:
> I have posted images for final releases of XGC 1.5 and FOP 1.1 at [1]
> and [2], respectively. I would like to initiate a 3-day vote on
> publishing these releases.
>
> If I see no negative vote and no comment remains unresolved by OCT11
> 0800Z, then I will publish to the appropriate sites on OCT15.
>
> [1] http://people.apache.org/~gadams/candidates/xmlgraphics-commons-1_5/
> [2] http://people.apache.org/~gadams/candidates/fop-1_1/
>
> The only changes made to these images from the respective RC1 images are:
>
>
> - update documentation to reflect final version numbers
> - update fop/README to simplify and extend summary of feature
> changes (per Vincent's suggestion at [3])
> - update fop/xmlgraphics-fop-pom-template.xml to sync avalon
> version with the version in fop/lib (i.e., 4.2.0, not 4.3.1)
> - update fop/build.xml to add release-dist and related targets,
> update maven-artifacts target to match xgc build usage
>
> [3] http://mail-archives.apache.org/mod_mbox/xmlgraphics-general/201206.mbox/%3c4FEDFF2D.2010208@gmail.com%3e
>
> Regards,
> Glenn
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org