You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2025/03/17 18:05:38 UTC

[PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

WillAyd opened a new pull request, #45824:
URL: https://github.com/apache/arrow/pull/45824

   ### Rationale for this change
   
   This continues to add support for Meson in the Arrow C++ codebase
   
   ### What changes are included in this PR?
   
   The util directory has been added to the Meson configuration
   
   ### Are these changes tested?
   
   Yes
   
   ### Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2730433243

   Revision: 67896cb4f75ff786ec3f52efd1640f6b59ec5a49
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-b05af5f8a2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b05af5f8a2)
   
   |Task|Status|
   |----|------|
   |test-conda-cpp-meson|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-b05af5f8a2-github-test-conda-cpp-meson)](https://github.com/ursacomputing/crossbow/actions/runs/13906690323/job/38911319616)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45824:
URL: https://github.com/apache/arrow/pull/45824#discussion_r2000148400


##########
cpp/src/arrow/util/meson.build:
##########
@@ -92,3 +92,243 @@ configure_file(
     configuration: internal_conf_data,
     format: 'cmake@',
 )
+
+install_headers(
+    [
+        'algorithm.h',
+        'aligned_storage.h',
+        'align_util.h',
+        'async_generator_fwd.h',
+        'async_generator.h',
+        'async_util.h',
+        'base64.h',
+        'basic_decimal.h',
+        'benchmark_util.h',
+        'binary_view_util.h',
+        'bit_block_counter.h',
+        'bitmap_builders.h',
+        'bitmap_generate.h',
+        'bitmap.h',
+        'bitmap_ops.h',
+        'bitmap_reader.h',
+        'bitmap_visit.h',
+        'bitmap_writer.h',
+        'bit_run_reader.h',
+        'bitset_stack.h',
+        'bit_util.h',
+        'bpacking64_default.h',
+        'bpacking_avx2.h',
+        'bpacking_avx512.h',
+        'bpacking_default.h',
+        'bpacking.h',
+        'bpacking_neon.h',
+        'byte_size.h',
+        'cancel.h',
+        'checked_cast.h',
+        'compare.h',
+        'compression.h',
+        'concurrent_map.h',
+        'converter.h',
+        'counting_semaphore.h',
+        'cpu_info.h',
+        'crc32.h',
+        'debug.h',
+        'decimal.h',
+        'delimiting.h',
+        'dict_util.h',
+        'dispatch.h',
+        'double_conversion.h',
+        'endian.h',
+        'float16.h',
+        'formatting.h',
+        'functional.h',
+        'future.h',
+        'hashing.h',
+        'hash_util.h',
+        'int_util.h',
+        'int_util_overflow.h',
+        'io_util.h',
+        'iterator.h',
+        'key_value_metadata.h',
+        'launder.h',
+        'list_util.h',
+        'logger.h',
+        'logging.h',
+        'macros.h',
+        'map.h',
+        'math_constants.h',
+        'memory.h',
+        'mutex.h',
+        'parallel.h',
+        'pcg_random.h',
+        'prefetch.h',
+        'print.h',
+        'queue.h',
+        'range.h',
+        'ree_util.h',
+        'regex.h',
+        'rows_to_batches.h',
+        'simd.h',
+        'small_vector.h',
+        'sort.h',
+        'spaced.h',
+        'span.h',
+        'stopwatch.h',
+        'string_builder.h',
+        'string.h',
+        'task_group.h',
+        'tdigest.h',
+        'test_common.h',
+        'thread_pool.h',
+        'time.h',
+        'tracing.h',
+        'trie.h',
+        'type_fwd.h',
+        'type_traits.h',
+        'ubsan.h',
+        'union_util.h',
+        'unreachable.h',
+        'uri.h',
+        'utf8.h',
+        'value_parsing.h',
+        'vector.h',
+        'visibility.h',
+        'windows_compatibility.h',
+        'windows_fixup.h',
+    ],
+    subdir: 'arrow/util',
+)
+
+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        io_util_test_sources = ['io_util_test.cc', 'io_util_test.manifest']
+    else
+        io_util_test_sources = ['io_util_test.cc', 'io_util_test.rc']
+    endif
+else
+    io_util_test_sources = ['io_util_test.cc']
+endif

Review Comment:
   ```suggestion
   io_util_test_sources = ['io_util_test.cc']
   if host_machine.system() == 'windows'
       # This manifest enables long file paths on Windows 10+
       # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
       if cpp_compiler.get_id() == 'msvc'
           io_util_test_sources += ['io_util_test.manifest']
       else
           io_util_test_sources += ['io_util_test.rc']
       endif
   endif
   ```
   
   Can we use the following?
   
   ```meson
   utility_test_srcs = [
       ...,
       'io_util_test.cc'
       ...
   ]
   if host_machine.system() == 'windows'
       # This manifest enables long file paths on Windows 10+
       # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
       if cpp_compiler.get_id() == 'msvc'
           utility_test_srcs += ['io_util_test.manifest']
       else
           utility_test_srcs += ['io_util_test.rc']
       endif
   endif



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45824:
URL: https://github.com/apache/arrow/pull/45824#discussion_r2004514737


##########
cpp/src/arrow/util/meson.build:
##########
@@ -92,3 +92,242 @@ configure_file(
     configuration: internal_conf_data,
     format: 'cmake@',
 )
+
+install_headers(
+    [
+        'algorithm.h',
+        'aligned_storage.h',
+        'align_util.h',
+        'async_generator_fwd.h',
+        'async_generator.h',
+        'async_util.h',
+        'base64.h',
+        'basic_decimal.h',
+        'benchmark_util.h',
+        'binary_view_util.h',
+        'bit_block_counter.h',
+        'bitmap_builders.h',
+        'bitmap_generate.h',
+        'bitmap.h',
+        'bitmap_ops.h',
+        'bitmap_reader.h',
+        'bitmap_visit.h',
+        'bitmap_writer.h',
+        'bit_run_reader.h',
+        'bitset_stack.h',
+        'bit_util.h',
+        'bpacking64_default.h',
+        'bpacking_avx2.h',
+        'bpacking_avx512.h',
+        'bpacking_default.h',
+        'bpacking.h',
+        'bpacking_neon.h',
+        'byte_size.h',
+        'cancel.h',
+        'checked_cast.h',
+        'compare.h',
+        'compression.h',
+        'concurrent_map.h',
+        'converter.h',
+        'counting_semaphore.h',
+        'cpu_info.h',
+        'crc32.h',
+        'debug.h',
+        'decimal.h',
+        'delimiting.h',
+        'dict_util.h',
+        'dispatch.h',
+        'double_conversion.h',
+        'endian.h',
+        'float16.h',
+        'formatting.h',
+        'functional.h',
+        'future.h',
+        'hashing.h',
+        'hash_util.h',
+        'int_util.h',
+        'int_util_overflow.h',
+        'io_util.h',
+        'iterator.h',
+        'key_value_metadata.h',
+        'launder.h',
+        'list_util.h',
+        'logger.h',
+        'logging.h',
+        'macros.h',
+        'map.h',
+        'math_constants.h',
+        'memory.h',
+        'mutex.h',
+        'parallel.h',
+        'pcg_random.h',
+        'prefetch.h',
+        'print.h',
+        'queue.h',
+        'range.h',
+        'ree_util.h',
+        'regex.h',
+        'rows_to_batches.h',
+        'simd.h',
+        'small_vector.h',
+        'sort.h',
+        'spaced.h',
+        'span.h',
+        'stopwatch.h',
+        'string_builder.h',
+        'string.h',
+        'task_group.h',
+        'tdigest.h',
+        'test_common.h',
+        'thread_pool.h',
+        'time.h',
+        'tracing.h',
+        'trie.h',
+        'type_fwd.h',
+        'type_traits.h',
+        'ubsan.h',
+        'union_util.h',
+        'unreachable.h',
+        'uri.h',
+        'utf8.h',
+        'value_parsing.h',
+        'vector.h',
+        'visibility.h',
+        'windows_compatibility.h',
+        'windows_fixup.h',
+    ],
+    subdir: 'arrow/util',
+)
+
+utility_test_srcs = [
+    'align_util_test.cc',
+    'atfork_test.cc',
+    'byte_size_test.cc',
+    'byte_stream_split_test.cc',
+    'cache_test.cc',
+    'checked_cast_test.cc',
+    'compression_test.cc',
+    'decimal_test.cc',
+    'float16_test.cc',
+    'fixed_width_test.cc',
+    'formatting_util_test.cc',
+    'key_value_metadata_test.cc',
+    'hashing_test.cc',
+    'int_util_test.cc',
+    'io_util_test.cc',
+    'iterator_test.cc',
+    'list_util_test.cc',
+    'logger_test.cc',
+    'logging_test.cc',
+    'math_test.cc',
+    'queue_test.cc',
+    'range_test.cc',
+    'ree_util_test.cc',
+    'reflection_test.cc',
+    'rows_to_batches_test.cc',
+    'small_vector_test.cc',
+    'span_test.cc',
+    'stl_util_test.cc',
+    'string_test.cc',
+    'tdigest_test.cc',
+    'test_common.cc',
+    'time_test.cc',
+    'tracing_test.cc',
+    'trie_test.cc',
+    'uri_test.cc',
+    'utf8_util_test.cc',
+    'value_parsing_test.cc',
+]
+
+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        utility_test_sources += ['io_util_test.manifest']
+    else
+        utility_test_sources += ['io_util_test.rc']
+    endif
+endif
+
+exc = executable(
+    'arrow-utility-test',
+    sources: utility_test_srcs,
+    dependencies: [arrow_dep, filesystem_dep, gtest_dep, gmock_dep],
+    link_with: [arrow_test_lib],
+    implicit_include_directories: false,
+)
+test('arrow-utility-test', exc)
+
+util_tests = {
+    'arrow-async-utility-test': {
+        'sources': [
+            'async_generator_test.cc',
+            'async_util_test.cc',
+            'test_common.cc',
+        ],
+    },
+    'arrow-bit-utility-test': {
+        'sources': [
+            'bit_block_counter_test.cc',
+            'bit_util_test.cc',
+            'rle_encoding_test.cc',
+        ],
+    },
+    'arrow-threading-utility-test': {
+        'sources': [
+            'cancel_test.cc',
+            'counting_semaphore_test.cc',
+            'future_test.cc',
+            'task_group_test.cc',
+            'test_common.cc',
+            'thread_pool_test.cc',
+        ],
+    },
+    'arrow-crc32-test': {
+        'sources': ['crc32_test.cc'],
+        'dependencies': [filesystem_dep],
+    },
+}
+
+if needs_tests

Review Comment:
   Can we use separated dependency for benchmarks something like the following?
   
   ```meson
   if needs_tests
       arrow_test_dep = declare_dependency(
           link_with: [arrow_test_lib],
           dependencies: [arrow_dep, filesystem_dep, gmock_dep, gtest_main_dep],
       )
   else
       arrow_test_dep = disabler()
   endif
   
   if needs_benchmarks
     arrow_benchmark_dep = declare_dependency(
           dependencies: [benchmark_dep, arrow_test_dep],
       )
   else
     arrow_benchmark_dep = disabler()
   end
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #45824:
URL: https://github.com/apache/arrow/pull/45824#discussion_r2004250587


##########
cpp/src/arrow/util/meson.build:
##########
@@ -92,3 +92,242 @@ configure_file(
     configuration: internal_conf_data,
     format: 'cmake@',
 )
+
+install_headers(
+    [
+        'algorithm.h',
+        'aligned_storage.h',
+        'align_util.h',
+        'async_generator_fwd.h',
+        'async_generator.h',
+        'async_util.h',
+        'base64.h',
+        'basic_decimal.h',
+        'benchmark_util.h',
+        'binary_view_util.h',
+        'bit_block_counter.h',
+        'bitmap_builders.h',
+        'bitmap_generate.h',
+        'bitmap.h',
+        'bitmap_ops.h',
+        'bitmap_reader.h',
+        'bitmap_visit.h',
+        'bitmap_writer.h',
+        'bit_run_reader.h',
+        'bitset_stack.h',
+        'bit_util.h',
+        'bpacking64_default.h',
+        'bpacking_avx2.h',
+        'bpacking_avx512.h',
+        'bpacking_default.h',
+        'bpacking.h',
+        'bpacking_neon.h',
+        'byte_size.h',
+        'cancel.h',
+        'checked_cast.h',
+        'compare.h',
+        'compression.h',
+        'concurrent_map.h',
+        'converter.h',
+        'counting_semaphore.h',
+        'cpu_info.h',
+        'crc32.h',
+        'debug.h',
+        'decimal.h',
+        'delimiting.h',
+        'dict_util.h',
+        'dispatch.h',
+        'double_conversion.h',
+        'endian.h',
+        'float16.h',
+        'formatting.h',
+        'functional.h',
+        'future.h',
+        'hashing.h',
+        'hash_util.h',
+        'int_util.h',
+        'int_util_overflow.h',
+        'io_util.h',
+        'iterator.h',
+        'key_value_metadata.h',
+        'launder.h',
+        'list_util.h',
+        'logger.h',
+        'logging.h',
+        'macros.h',
+        'map.h',
+        'math_constants.h',
+        'memory.h',
+        'mutex.h',
+        'parallel.h',
+        'pcg_random.h',
+        'prefetch.h',
+        'print.h',
+        'queue.h',
+        'range.h',
+        'ree_util.h',
+        'regex.h',
+        'rows_to_batches.h',
+        'simd.h',
+        'small_vector.h',
+        'sort.h',
+        'spaced.h',
+        'span.h',
+        'stopwatch.h',
+        'string_builder.h',
+        'string.h',
+        'task_group.h',
+        'tdigest.h',
+        'test_common.h',
+        'thread_pool.h',
+        'time.h',
+        'tracing.h',
+        'trie.h',
+        'type_fwd.h',
+        'type_traits.h',
+        'ubsan.h',
+        'union_util.h',
+        'unreachable.h',
+        'uri.h',
+        'utf8.h',
+        'value_parsing.h',
+        'vector.h',
+        'visibility.h',
+        'windows_compatibility.h',
+        'windows_fixup.h',
+    ],
+    subdir: 'arrow/util',
+)
+
+utility_test_srcs = [
+    'align_util_test.cc',
+    'atfork_test.cc',
+    'byte_size_test.cc',
+    'byte_stream_split_test.cc',
+    'cache_test.cc',
+    'checked_cast_test.cc',
+    'compression_test.cc',
+    'decimal_test.cc',
+    'float16_test.cc',
+    'fixed_width_test.cc',
+    'formatting_util_test.cc',
+    'key_value_metadata_test.cc',
+    'hashing_test.cc',
+    'int_util_test.cc',
+    'io_util_test.cc',
+    'iterator_test.cc',
+    'list_util_test.cc',
+    'logger_test.cc',
+    'logging_test.cc',
+    'math_test.cc',
+    'queue_test.cc',
+    'range_test.cc',
+    'ree_util_test.cc',
+    'reflection_test.cc',
+    'rows_to_batches_test.cc',
+    'small_vector_test.cc',
+    'span_test.cc',
+    'stl_util_test.cc',
+    'string_test.cc',
+    'tdigest_test.cc',
+    'test_common.cc',
+    'time_test.cc',
+    'tracing_test.cc',
+    'trie_test.cc',
+    'uri_test.cc',
+    'utf8_util_test.cc',
+    'value_parsing_test.cc',
+]
+
+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        utility_test_sources += ['io_util_test.manifest']
+    else
+        utility_test_sources += ['io_util_test.rc']
+    endif
+endif
+
+exc = executable(
+    'arrow-utility-test',
+    sources: utility_test_srcs,
+    dependencies: [arrow_dep, filesystem_dep, gtest_dep, gmock_dep],
+    link_with: [arrow_test_lib],
+    implicit_include_directories: false,
+)
+test('arrow-utility-test', exc)
+
+util_tests = {
+    'arrow-async-utility-test': {
+        'sources': [
+            'async_generator_test.cc',
+            'async_util_test.cc',
+            'test_common.cc',
+        ],
+    },
+    'arrow-bit-utility-test': {
+        'sources': [
+            'bit_block_counter_test.cc',
+            'bit_util_test.cc',
+            'rle_encoding_test.cc',
+        ],
+    },
+    'arrow-threading-utility-test': {
+        'sources': [
+            'cancel_test.cc',
+            'counting_semaphore_test.cc',
+            'future_test.cc',
+            'task_group_test.cc',
+            'test_common.cc',
+            'thread_pool_test.cc',
+        ],
+    },
+    'arrow-crc32-test': {
+        'sources': ['crc32_test.cc'],
+        'dependencies': [filesystem_dep],
+    },
+}
+
+if needs_tests

Review Comment:
   Nice catch on the arrow-utility-test - I can do that.
   
   With respect to the `if needs_tests`, it depends how much we want to adhere to what CMake has in place. In fact, we used to use that same condition, but I had to change it from `if needs_tests` to `if needs_testing` in the benchmarks PR. 
   
   https://github.com/apache/arrow/pull/45793/files
   
   Unless I am misreading the CMake configuration (which is certainly possible) it seems like it is possible to disable tests but turn the benchmarks on. In such a case, you would still need the current `arrow_test_dep` dependency to build benchmarks; the change you are proposing would add a dependency between the test suite and benchmark suite



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2731559307

   Revision: 39031254a0c9f86f641162c0b0c947f49b64fa10
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-f5d42b5ad9](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f5d42b5ad9)
   
   |Task|Status|
   |----|------|
   |test-conda-cpp-meson|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f5d42b5ad9-github-test-conda-cpp-meson)](https://github.com/ursacomputing/crossbow/actions/runs/13915150897/job/38936750968)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #45824:
URL: https://github.com/apache/arrow/pull/45824#discussion_r2002339578


##########
cpp/src/arrow/util/meson.build:
##########
@@ -92,3 +92,242 @@ configure_file(
     configuration: internal_conf_data,
     format: 'cmake@',
 )
+
+install_headers(
+    [
+        'algorithm.h',
+        'aligned_storage.h',
+        'align_util.h',
+        'async_generator_fwd.h',
+        'async_generator.h',
+        'async_util.h',
+        'base64.h',
+        'basic_decimal.h',
+        'benchmark_util.h',
+        'binary_view_util.h',
+        'bit_block_counter.h',
+        'bitmap_builders.h',
+        'bitmap_generate.h',
+        'bitmap.h',
+        'bitmap_ops.h',
+        'bitmap_reader.h',
+        'bitmap_visit.h',
+        'bitmap_writer.h',
+        'bit_run_reader.h',
+        'bitset_stack.h',
+        'bit_util.h',
+        'bpacking64_default.h',
+        'bpacking_avx2.h',
+        'bpacking_avx512.h',
+        'bpacking_default.h',
+        'bpacking.h',
+        'bpacking_neon.h',
+        'byte_size.h',
+        'cancel.h',
+        'checked_cast.h',
+        'compare.h',
+        'compression.h',
+        'concurrent_map.h',
+        'converter.h',
+        'counting_semaphore.h',
+        'cpu_info.h',
+        'crc32.h',
+        'debug.h',
+        'decimal.h',
+        'delimiting.h',
+        'dict_util.h',
+        'dispatch.h',
+        'double_conversion.h',
+        'endian.h',
+        'float16.h',
+        'formatting.h',
+        'functional.h',
+        'future.h',
+        'hashing.h',
+        'hash_util.h',
+        'int_util.h',
+        'int_util_overflow.h',
+        'io_util.h',
+        'iterator.h',
+        'key_value_metadata.h',
+        'launder.h',
+        'list_util.h',
+        'logger.h',
+        'logging.h',
+        'macros.h',
+        'map.h',
+        'math_constants.h',
+        'memory.h',
+        'mutex.h',
+        'parallel.h',
+        'pcg_random.h',
+        'prefetch.h',
+        'print.h',
+        'queue.h',
+        'range.h',
+        'ree_util.h',
+        'regex.h',
+        'rows_to_batches.h',
+        'simd.h',
+        'small_vector.h',
+        'sort.h',
+        'spaced.h',
+        'span.h',
+        'stopwatch.h',
+        'string_builder.h',
+        'string.h',
+        'task_group.h',
+        'tdigest.h',
+        'test_common.h',
+        'thread_pool.h',
+        'time.h',
+        'tracing.h',
+        'trie.h',
+        'type_fwd.h',
+        'type_traits.h',
+        'ubsan.h',
+        'union_util.h',
+        'unreachable.h',
+        'uri.h',
+        'utf8.h',
+        'value_parsing.h',
+        'vector.h',
+        'visibility.h',
+        'windows_compatibility.h',
+        'windows_fixup.h',
+    ],
+    subdir: 'arrow/util',
+)
+
+utility_test_srcs = [
+    'align_util_test.cc',
+    'atfork_test.cc',
+    'byte_size_test.cc',
+    'byte_stream_split_test.cc',
+    'cache_test.cc',
+    'checked_cast_test.cc',
+    'compression_test.cc',
+    'decimal_test.cc',
+    'float16_test.cc',
+    'fixed_width_test.cc',
+    'formatting_util_test.cc',
+    'key_value_metadata_test.cc',
+    'hashing_test.cc',
+    'int_util_test.cc',
+    'io_util_test.cc',
+    'iterator_test.cc',
+    'list_util_test.cc',
+    'logger_test.cc',
+    'logging_test.cc',
+    'math_test.cc',
+    'queue_test.cc',
+    'range_test.cc',
+    'ree_util_test.cc',
+    'reflection_test.cc',
+    'rows_to_batches_test.cc',
+    'small_vector_test.cc',
+    'span_test.cc',
+    'stl_util_test.cc',
+    'string_test.cc',
+    'tdigest_test.cc',
+    'test_common.cc',
+    'time_test.cc',
+    'tracing_test.cc',
+    'trie_test.cc',
+    'uri_test.cc',
+    'utf8_util_test.cc',
+    'value_parsing_test.cc',
+]
+
+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        utility_test_sources += ['io_util_test.manifest']
+    else
+        utility_test_sources += ['io_util_test.rc']
+    endif
+endif
+
+exc = executable(
+    'arrow-utility-test',
+    sources: utility_test_srcs,
+    dependencies: [arrow_dep, filesystem_dep, gtest_dep, gmock_dep],
+    link_with: [arrow_test_lib],
+    implicit_include_directories: false,
+)
+test('arrow-utility-test', exc)
+
+util_tests = {
+    'arrow-async-utility-test': {
+        'sources': [
+            'async_generator_test.cc',
+            'async_util_test.cc',
+            'test_common.cc',
+        ],
+    },
+    'arrow-bit-utility-test': {
+        'sources': [
+            'bit_block_counter_test.cc',
+            'bit_util_test.cc',
+            'rle_encoding_test.cc',
+        ],
+    },
+    'arrow-threading-utility-test': {
+        'sources': [
+            'cancel_test.cc',
+            'counting_semaphore_test.cc',
+            'future_test.cc',
+            'task_group_test.cc',
+            'test_common.cc',
+            'thread_pool_test.cc',
+        ],
+    },
+    'arrow-crc32-test': {
+        'sources': ['crc32_test.cc'],
+        'dependencies': [filesystem_dep],
+    },
+}
+
+if needs_tests
+    foreach key, val : util_tests
+        exc = executable(
+            key,
+            sources: val['sources'],
+            dependencies: [arrow_test_dep, val.get('dependencies', [])],

Review Comment:
   `arrow_test_dep` already provides `gtest_main_dep` transitively



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #45824:
URL: https://github.com/apache/arrow/pull/45824#discussion_r2004242830


##########
cpp/src/arrow/util/meson.build:
##########
@@ -92,3 +92,242 @@ configure_file(
     configuration: internal_conf_data,
     format: 'cmake@',
 )
+
+install_headers(
+    [
+        'algorithm.h',
+        'aligned_storage.h',
+        'align_util.h',
+        'async_generator_fwd.h',
+        'async_generator.h',
+        'async_util.h',
+        'base64.h',
+        'basic_decimal.h',
+        'benchmark_util.h',
+        'binary_view_util.h',
+        'bit_block_counter.h',
+        'bitmap_builders.h',
+        'bitmap_generate.h',
+        'bitmap.h',
+        'bitmap_ops.h',
+        'bitmap_reader.h',
+        'bitmap_visit.h',
+        'bitmap_writer.h',
+        'bit_run_reader.h',
+        'bitset_stack.h',
+        'bit_util.h',
+        'bpacking64_default.h',
+        'bpacking_avx2.h',
+        'bpacking_avx512.h',
+        'bpacking_default.h',
+        'bpacking.h',
+        'bpacking_neon.h',
+        'byte_size.h',
+        'cancel.h',
+        'checked_cast.h',
+        'compare.h',
+        'compression.h',
+        'concurrent_map.h',
+        'converter.h',
+        'counting_semaphore.h',
+        'cpu_info.h',
+        'crc32.h',
+        'debug.h',
+        'decimal.h',
+        'delimiting.h',
+        'dict_util.h',
+        'dispatch.h',
+        'double_conversion.h',
+        'endian.h',
+        'float16.h',
+        'formatting.h',
+        'functional.h',
+        'future.h',
+        'hashing.h',
+        'hash_util.h',
+        'int_util.h',
+        'int_util_overflow.h',
+        'io_util.h',
+        'iterator.h',
+        'key_value_metadata.h',
+        'launder.h',
+        'list_util.h',
+        'logger.h',
+        'logging.h',
+        'macros.h',
+        'map.h',
+        'math_constants.h',
+        'memory.h',
+        'mutex.h',
+        'parallel.h',
+        'pcg_random.h',
+        'prefetch.h',
+        'print.h',
+        'queue.h',
+        'range.h',
+        'ree_util.h',
+        'regex.h',
+        'rows_to_batches.h',
+        'simd.h',
+        'small_vector.h',
+        'sort.h',
+        'spaced.h',
+        'span.h',
+        'stopwatch.h',
+        'string_builder.h',
+        'string.h',
+        'task_group.h',
+        'tdigest.h',
+        'test_common.h',
+        'thread_pool.h',
+        'time.h',
+        'tracing.h',
+        'trie.h',
+        'type_fwd.h',
+        'type_traits.h',
+        'ubsan.h',
+        'union_util.h',
+        'unreachable.h',
+        'uri.h',
+        'utf8.h',
+        'value_parsing.h',
+        'vector.h',
+        'visibility.h',
+        'windows_compatibility.h',
+        'windows_fixup.h',
+    ],
+    subdir: 'arrow/util',
+)
+
+utility_test_srcs = [
+    'align_util_test.cc',
+    'atfork_test.cc',
+    'byte_size_test.cc',
+    'byte_stream_split_test.cc',
+    'cache_test.cc',
+    'checked_cast_test.cc',
+    'compression_test.cc',
+    'decimal_test.cc',
+    'float16_test.cc',
+    'fixed_width_test.cc',
+    'formatting_util_test.cc',
+    'key_value_metadata_test.cc',
+    'hashing_test.cc',
+    'int_util_test.cc',
+    'io_util_test.cc',
+    'iterator_test.cc',
+    'list_util_test.cc',
+    'logger_test.cc',
+    'logging_test.cc',
+    'math_test.cc',
+    'queue_test.cc',
+    'range_test.cc',
+    'ree_util_test.cc',
+    'reflection_test.cc',
+    'rows_to_batches_test.cc',
+    'small_vector_test.cc',
+    'span_test.cc',
+    'stl_util_test.cc',
+    'string_test.cc',
+    'tdigest_test.cc',
+    'test_common.cc',
+    'time_test.cc',
+    'tracing_test.cc',
+    'trie_test.cc',
+    'uri_test.cc',
+    'utf8_util_test.cc',
+    'value_parsing_test.cc',
+]
+
+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        utility_test_sources += ['io_util_test.manifest']
+    else
+        utility_test_sources += ['io_util_test.rc']
+    endif
+endif
+
+exc = executable(
+    'arrow-utility-test',
+    sources: utility_test_srcs,
+    dependencies: [arrow_dep, filesystem_dep, gtest_dep, gmock_dep],
+    link_with: [arrow_test_lib],
+    implicit_include_directories: false,
+)
+test('arrow-utility-test', exc)
+
+util_tests = {
+    'arrow-async-utility-test': {
+        'sources': [
+            'async_generator_test.cc',
+            'async_util_test.cc',
+            'test_common.cc',
+        ],
+    },
+    'arrow-bit-utility-test': {
+        'sources': [
+            'bit_block_counter_test.cc',
+            'bit_util_test.cc',
+            'rle_encoding_test.cc',
+        ],
+    },
+    'arrow-threading-utility-test': {
+        'sources': [
+            'cancel_test.cc',
+            'counting_semaphore_test.cc',
+            'future_test.cc',
+            'task_group_test.cc',
+            'test_common.cc',
+            'thread_pool_test.cc',
+        ],
+    },
+    'arrow-crc32-test': {
+        'sources': ['crc32_test.cc'],
+        'dependencies': [filesystem_dep],
+    },
+}
+
+if needs_tests
+    foreach key, val : util_tests
+        exc = executable(
+            key,
+            sources: val['sources'],
+            dependencies: [arrow_test_dep, val.get('dependencies', [])],

Review Comment:
   Ah nice catch - yea we can do that for now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2730547458

   Revision: f5cebe7ba0486744271af40b5d93c9d98a62540d
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-8cfff641da](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8cfff641da)
   
   |Task|Status|
   |----|------|
   |test-conda-cpp-meson|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8cfff641da-github-test-conda-cpp-meson)](https://github.com/ursacomputing/crossbow/actions/runs/13907648123/job/38914336713)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #45824:
URL: https://github.com/apache/arrow/pull/45824#discussion_r2004518627


##########
cpp/src/arrow/util/meson.build:
##########
@@ -92,3 +92,242 @@ configure_file(
     configuration: internal_conf_data,
     format: 'cmake@',
 )
+
+install_headers(
+    [
+        'algorithm.h',
+        'aligned_storage.h',
+        'align_util.h',
+        'async_generator_fwd.h',
+        'async_generator.h',
+        'async_util.h',
+        'base64.h',
+        'basic_decimal.h',
+        'benchmark_util.h',
+        'binary_view_util.h',
+        'bit_block_counter.h',
+        'bitmap_builders.h',
+        'bitmap_generate.h',
+        'bitmap.h',
+        'bitmap_ops.h',
+        'bitmap_reader.h',
+        'bitmap_visit.h',
+        'bitmap_writer.h',
+        'bit_run_reader.h',
+        'bitset_stack.h',
+        'bit_util.h',
+        'bpacking64_default.h',
+        'bpacking_avx2.h',
+        'bpacking_avx512.h',
+        'bpacking_default.h',
+        'bpacking.h',
+        'bpacking_neon.h',
+        'byte_size.h',
+        'cancel.h',
+        'checked_cast.h',
+        'compare.h',
+        'compression.h',
+        'concurrent_map.h',
+        'converter.h',
+        'counting_semaphore.h',
+        'cpu_info.h',
+        'crc32.h',
+        'debug.h',
+        'decimal.h',
+        'delimiting.h',
+        'dict_util.h',
+        'dispatch.h',
+        'double_conversion.h',
+        'endian.h',
+        'float16.h',
+        'formatting.h',
+        'functional.h',
+        'future.h',
+        'hashing.h',
+        'hash_util.h',
+        'int_util.h',
+        'int_util_overflow.h',
+        'io_util.h',
+        'iterator.h',
+        'key_value_metadata.h',
+        'launder.h',
+        'list_util.h',
+        'logger.h',
+        'logging.h',
+        'macros.h',
+        'map.h',
+        'math_constants.h',
+        'memory.h',
+        'mutex.h',
+        'parallel.h',
+        'pcg_random.h',
+        'prefetch.h',
+        'print.h',
+        'queue.h',
+        'range.h',
+        'ree_util.h',
+        'regex.h',
+        'rows_to_batches.h',
+        'simd.h',
+        'small_vector.h',
+        'sort.h',
+        'spaced.h',
+        'span.h',
+        'stopwatch.h',
+        'string_builder.h',
+        'string.h',
+        'task_group.h',
+        'tdigest.h',
+        'test_common.h',
+        'thread_pool.h',
+        'time.h',
+        'tracing.h',
+        'trie.h',
+        'type_fwd.h',
+        'type_traits.h',
+        'ubsan.h',
+        'union_util.h',
+        'unreachable.h',
+        'uri.h',
+        'utf8.h',
+        'value_parsing.h',
+        'vector.h',
+        'visibility.h',
+        'windows_compatibility.h',
+        'windows_fixup.h',
+    ],
+    subdir: 'arrow/util',
+)
+
+utility_test_srcs = [
+    'align_util_test.cc',
+    'atfork_test.cc',
+    'byte_size_test.cc',
+    'byte_stream_split_test.cc',
+    'cache_test.cc',
+    'checked_cast_test.cc',
+    'compression_test.cc',
+    'decimal_test.cc',
+    'float16_test.cc',
+    'fixed_width_test.cc',
+    'formatting_util_test.cc',
+    'key_value_metadata_test.cc',
+    'hashing_test.cc',
+    'int_util_test.cc',
+    'io_util_test.cc',
+    'iterator_test.cc',
+    'list_util_test.cc',
+    'logger_test.cc',
+    'logging_test.cc',
+    'math_test.cc',
+    'queue_test.cc',
+    'range_test.cc',
+    'ree_util_test.cc',
+    'reflection_test.cc',
+    'rows_to_batches_test.cc',
+    'small_vector_test.cc',
+    'span_test.cc',
+    'stl_util_test.cc',
+    'string_test.cc',
+    'tdigest_test.cc',
+    'test_common.cc',
+    'time_test.cc',
+    'tracing_test.cc',
+    'trie_test.cc',
+    'uri_test.cc',
+    'utf8_util_test.cc',
+    'value_parsing_test.cc',
+]
+
+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        utility_test_sources += ['io_util_test.manifest']
+    else
+        utility_test_sources += ['io_util_test.rc']
+    endif
+endif
+
+exc = executable(
+    'arrow-utility-test',
+    sources: utility_test_srcs,
+    dependencies: [arrow_dep, filesystem_dep, gtest_dep, gmock_dep],
+    link_with: [arrow_test_lib],
+    implicit_include_directories: false,
+)
+test('arrow-utility-test', exc)
+
+util_tests = {
+    'arrow-async-utility-test': {
+        'sources': [
+            'async_generator_test.cc',
+            'async_util_test.cc',
+            'test_common.cc',
+        ],
+    },
+    'arrow-bit-utility-test': {
+        'sources': [
+            'bit_block_counter_test.cc',
+            'bit_util_test.cc',
+            'rle_encoding_test.cc',
+        ],
+    },
+    'arrow-threading-utility-test': {
+        'sources': [
+            'cancel_test.cc',
+            'counting_semaphore_test.cc',
+            'future_test.cc',
+            'task_group_test.cc',
+            'test_common.cc',
+            'thread_pool_test.cc',
+        ],
+    },
+    'arrow-crc32-test': {
+        'sources': ['crc32_test.cc'],
+        'dependencies': [filesystem_dep],
+    },
+}
+
+if needs_tests

Review Comment:
   Yes we can. Nice idea!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2733625159

   Revision: d1fcfeda9b26d4c70dad27dbc0c00e90d4b5427a
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-fbda2d1a9d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-fbda2d1a9d)
   
   |Task|Status|
   |----|------|
   |test-conda-cpp-meson|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-fbda2d1a9d-github-test-conda-cpp-meson)](https://github.com/ursacomputing/crossbow/actions/runs/13926786718/job/38973332596)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2730427604

   :warning: GitHub issue #45800 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2730427629

   :warning: GitHub issue #45800 **has no components**, please add labels for components.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45824:
URL: https://github.com/apache/arrow/pull/45824#discussion_r2002473062


##########
cpp/src/arrow/util/meson.build:
##########
@@ -92,3 +92,242 @@ configure_file(
     configuration: internal_conf_data,
     format: 'cmake@',
 )
+
+install_headers(
+    [
+        'algorithm.h',
+        'aligned_storage.h',
+        'align_util.h',
+        'async_generator_fwd.h',
+        'async_generator.h',
+        'async_util.h',
+        'base64.h',
+        'basic_decimal.h',
+        'benchmark_util.h',
+        'binary_view_util.h',
+        'bit_block_counter.h',
+        'bitmap_builders.h',
+        'bitmap_generate.h',
+        'bitmap.h',
+        'bitmap_ops.h',
+        'bitmap_reader.h',
+        'bitmap_visit.h',
+        'bitmap_writer.h',
+        'bit_run_reader.h',
+        'bitset_stack.h',
+        'bit_util.h',
+        'bpacking64_default.h',
+        'bpacking_avx2.h',
+        'bpacking_avx512.h',
+        'bpacking_default.h',
+        'bpacking.h',
+        'bpacking_neon.h',
+        'byte_size.h',
+        'cancel.h',
+        'checked_cast.h',
+        'compare.h',
+        'compression.h',
+        'concurrent_map.h',
+        'converter.h',
+        'counting_semaphore.h',
+        'cpu_info.h',
+        'crc32.h',
+        'debug.h',
+        'decimal.h',
+        'delimiting.h',
+        'dict_util.h',
+        'dispatch.h',
+        'double_conversion.h',
+        'endian.h',
+        'float16.h',
+        'formatting.h',
+        'functional.h',
+        'future.h',
+        'hashing.h',
+        'hash_util.h',
+        'int_util.h',
+        'int_util_overflow.h',
+        'io_util.h',
+        'iterator.h',
+        'key_value_metadata.h',
+        'launder.h',
+        'list_util.h',
+        'logger.h',
+        'logging.h',
+        'macros.h',
+        'map.h',
+        'math_constants.h',
+        'memory.h',
+        'mutex.h',
+        'parallel.h',
+        'pcg_random.h',
+        'prefetch.h',
+        'print.h',
+        'queue.h',
+        'range.h',
+        'ree_util.h',
+        'regex.h',
+        'rows_to_batches.h',
+        'simd.h',
+        'small_vector.h',
+        'sort.h',
+        'spaced.h',
+        'span.h',
+        'stopwatch.h',
+        'string_builder.h',
+        'string.h',
+        'task_group.h',
+        'tdigest.h',
+        'test_common.h',
+        'thread_pool.h',
+        'time.h',
+        'tracing.h',
+        'trie.h',
+        'type_fwd.h',
+        'type_traits.h',
+        'ubsan.h',
+        'union_util.h',
+        'unreachable.h',
+        'uri.h',
+        'utf8.h',
+        'value_parsing.h',
+        'vector.h',
+        'visibility.h',
+        'windows_compatibility.h',
+        'windows_fixup.h',
+    ],
+    subdir: 'arrow/util',
+)
+
+utility_test_srcs = [
+    'align_util_test.cc',
+    'atfork_test.cc',
+    'byte_size_test.cc',
+    'byte_stream_split_test.cc',
+    'cache_test.cc',
+    'checked_cast_test.cc',
+    'compression_test.cc',
+    'decimal_test.cc',
+    'float16_test.cc',
+    'fixed_width_test.cc',
+    'formatting_util_test.cc',
+    'key_value_metadata_test.cc',
+    'hashing_test.cc',
+    'int_util_test.cc',
+    'io_util_test.cc',
+    'iterator_test.cc',
+    'list_util_test.cc',
+    'logger_test.cc',
+    'logging_test.cc',
+    'math_test.cc',
+    'queue_test.cc',
+    'range_test.cc',
+    'ree_util_test.cc',
+    'reflection_test.cc',
+    'rows_to_batches_test.cc',
+    'small_vector_test.cc',
+    'span_test.cc',
+    'stl_util_test.cc',
+    'string_test.cc',
+    'tdigest_test.cc',
+    'test_common.cc',
+    'time_test.cc',
+    'tracing_test.cc',
+    'trie_test.cc',
+    'uri_test.cc',
+    'utf8_util_test.cc',
+    'value_parsing_test.cc',
+]
+
+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        utility_test_sources += ['io_util_test.manifest']
+    else
+        utility_test_sources += ['io_util_test.rc']
+    endif
+endif
+
+exc = executable(
+    'arrow-utility-test',
+    sources: utility_test_srcs,
+    dependencies: [arrow_dep, filesystem_dep, gtest_dep, gmock_dep],
+    link_with: [arrow_test_lib],
+    implicit_include_directories: false,
+)
+test('arrow-utility-test', exc)
+
+util_tests = {
+    'arrow-async-utility-test': {
+        'sources': [
+            'async_generator_test.cc',
+            'async_util_test.cc',
+            'test_common.cc',
+        ],
+    },
+    'arrow-bit-utility-test': {
+        'sources': [
+            'bit_block_counter_test.cc',
+            'bit_util_test.cc',
+            'rle_encoding_test.cc',
+        ],
+    },
+    'arrow-threading-utility-test': {
+        'sources': [
+            'cancel_test.cc',
+            'counting_semaphore_test.cc',
+            'future_test.cc',
+            'task_group_test.cc',
+            'test_common.cc',
+            'thread_pool_test.cc',
+        ],
+    },
+    'arrow-crc32-test': {
+        'sources': ['crc32_test.cc'],
+        'dependencies': [filesystem_dep],
+    },
+}
+
+if needs_tests

Review Comment:
   If we need this here, we need it for `test('arrow-utility-test', exc)` too?
   
   It seems that we don't need both `arrow_test_dep` and `arrow_testing_dep`. Can we use this instead?
   
   ```meson
   if needs_tests
       arrow_test_dep = declare_dependency(
           link_with: [arrow_test_lib],
           dependencies: [arrow_dep, filesystem_dep, gmock_dep, gtest_main_dep],
       )
   else
       arrow_test_dep = disabler()
   endif
   ```



##########
cpp/src/arrow/util/meson.build:
##########
@@ -92,3 +92,242 @@ configure_file(
     configuration: internal_conf_data,
     format: 'cmake@',
 )
+
+install_headers(
+    [
+        'algorithm.h',
+        'aligned_storage.h',
+        'align_util.h',
+        'async_generator_fwd.h',
+        'async_generator.h',
+        'async_util.h',
+        'base64.h',
+        'basic_decimal.h',
+        'benchmark_util.h',
+        'binary_view_util.h',
+        'bit_block_counter.h',
+        'bitmap_builders.h',
+        'bitmap_generate.h',
+        'bitmap.h',
+        'bitmap_ops.h',
+        'bitmap_reader.h',
+        'bitmap_visit.h',
+        'bitmap_writer.h',
+        'bit_run_reader.h',
+        'bitset_stack.h',
+        'bit_util.h',
+        'bpacking64_default.h',
+        'bpacking_avx2.h',
+        'bpacking_avx512.h',
+        'bpacking_default.h',
+        'bpacking.h',
+        'bpacking_neon.h',
+        'byte_size.h',
+        'cancel.h',
+        'checked_cast.h',
+        'compare.h',
+        'compression.h',
+        'concurrent_map.h',
+        'converter.h',
+        'counting_semaphore.h',
+        'cpu_info.h',
+        'crc32.h',
+        'debug.h',
+        'decimal.h',
+        'delimiting.h',
+        'dict_util.h',
+        'dispatch.h',
+        'double_conversion.h',
+        'endian.h',
+        'float16.h',
+        'formatting.h',
+        'functional.h',
+        'future.h',
+        'hashing.h',
+        'hash_util.h',
+        'int_util.h',
+        'int_util_overflow.h',
+        'io_util.h',
+        'iterator.h',
+        'key_value_metadata.h',
+        'launder.h',
+        'list_util.h',
+        'logger.h',
+        'logging.h',
+        'macros.h',
+        'map.h',
+        'math_constants.h',
+        'memory.h',
+        'mutex.h',
+        'parallel.h',
+        'pcg_random.h',
+        'prefetch.h',
+        'print.h',
+        'queue.h',
+        'range.h',
+        'ree_util.h',
+        'regex.h',
+        'rows_to_batches.h',
+        'simd.h',
+        'small_vector.h',
+        'sort.h',
+        'spaced.h',
+        'span.h',
+        'stopwatch.h',
+        'string_builder.h',
+        'string.h',
+        'task_group.h',
+        'tdigest.h',
+        'test_common.h',
+        'thread_pool.h',
+        'time.h',
+        'tracing.h',
+        'trie.h',
+        'type_fwd.h',
+        'type_traits.h',
+        'ubsan.h',
+        'union_util.h',
+        'unreachable.h',
+        'uri.h',
+        'utf8.h',
+        'value_parsing.h',
+        'vector.h',
+        'visibility.h',
+        'windows_compatibility.h',
+        'windows_fixup.h',
+    ],
+    subdir: 'arrow/util',
+)
+
+utility_test_srcs = [
+    'align_util_test.cc',
+    'atfork_test.cc',
+    'byte_size_test.cc',
+    'byte_stream_split_test.cc',
+    'cache_test.cc',
+    'checked_cast_test.cc',
+    'compression_test.cc',
+    'decimal_test.cc',
+    'float16_test.cc',
+    'fixed_width_test.cc',
+    'formatting_util_test.cc',
+    'key_value_metadata_test.cc',
+    'hashing_test.cc',
+    'int_util_test.cc',
+    'io_util_test.cc',
+    'iterator_test.cc',
+    'list_util_test.cc',
+    'logger_test.cc',
+    'logging_test.cc',
+    'math_test.cc',
+    'queue_test.cc',
+    'range_test.cc',
+    'ree_util_test.cc',
+    'reflection_test.cc',
+    'rows_to_batches_test.cc',
+    'small_vector_test.cc',
+    'span_test.cc',
+    'stl_util_test.cc',
+    'string_test.cc',
+    'tdigest_test.cc',
+    'test_common.cc',
+    'time_test.cc',
+    'tracing_test.cc',
+    'trie_test.cc',
+    'uri_test.cc',
+    'utf8_util_test.cc',
+    'value_parsing_test.cc',
+]
+
+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        utility_test_sources += ['io_util_test.manifest']
+    else
+        utility_test_sources += ['io_util_test.rc']
+    endif
+endif
+
+exc = executable(
+    'arrow-utility-test',
+    sources: utility_test_srcs,
+    dependencies: [arrow_dep, filesystem_dep, gtest_dep, gmock_dep],
+    link_with: [arrow_test_lib],
+    implicit_include_directories: false,
+)
+test('arrow-utility-test', exc)
+
+util_tests = {
+    'arrow-async-utility-test': {
+        'sources': [
+            'async_generator_test.cc',
+            'async_util_test.cc',
+            'test_common.cc',
+        ],
+    },
+    'arrow-bit-utility-test': {
+        'sources': [
+            'bit_block_counter_test.cc',
+            'bit_util_test.cc',
+            'rle_encoding_test.cc',
+        ],
+    },
+    'arrow-threading-utility-test': {
+        'sources': [
+            'cancel_test.cc',
+            'counting_semaphore_test.cc',
+            'future_test.cc',
+            'task_group_test.cc',
+            'test_common.cc',
+            'thread_pool_test.cc',
+        ],
+    },
+    'arrow-crc32-test': {
+        'sources': ['crc32_test.cc'],
+        'dependencies': [filesystem_dep],
+    },
+}
+
+if needs_tests
+    foreach key, val : util_tests
+        exc = executable(
+            key,
+            sources: val['sources'],
+            dependencies: [arrow_test_dep, val.get('dependencies', [])],

Review Comment:
   Ah, `arrow_test_dep` doesn't link to only `libarrow_testing.so`.
   
   Then can we remove `filesystem_dep` from `arrow-crc32-test` dependencies?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2730427842

   @github-actions crossbow submit *meson


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #45824:
URL: https://github.com/apache/arrow/pull/45824


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2790950827

   @github-actions crossbow submit *meson


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45824:
URL: https://github.com/apache/arrow/pull/45824#discussion_r2002336039


##########
cpp/src/arrow/util/meson.build:
##########
@@ -92,3 +92,242 @@ configure_file(
     configuration: internal_conf_data,
     format: 'cmake@',
 )
+
+install_headers(
+    [
+        'algorithm.h',
+        'aligned_storage.h',
+        'align_util.h',
+        'async_generator_fwd.h',
+        'async_generator.h',
+        'async_util.h',
+        'base64.h',
+        'basic_decimal.h',
+        'benchmark_util.h',
+        'binary_view_util.h',
+        'bit_block_counter.h',
+        'bitmap_builders.h',
+        'bitmap_generate.h',
+        'bitmap.h',
+        'bitmap_ops.h',
+        'bitmap_reader.h',
+        'bitmap_visit.h',
+        'bitmap_writer.h',
+        'bit_run_reader.h',
+        'bitset_stack.h',
+        'bit_util.h',
+        'bpacking64_default.h',
+        'bpacking_avx2.h',
+        'bpacking_avx512.h',
+        'bpacking_default.h',
+        'bpacking.h',
+        'bpacking_neon.h',
+        'byte_size.h',
+        'cancel.h',
+        'checked_cast.h',
+        'compare.h',
+        'compression.h',
+        'concurrent_map.h',
+        'converter.h',
+        'counting_semaphore.h',
+        'cpu_info.h',
+        'crc32.h',
+        'debug.h',
+        'decimal.h',
+        'delimiting.h',
+        'dict_util.h',
+        'dispatch.h',
+        'double_conversion.h',
+        'endian.h',
+        'float16.h',
+        'formatting.h',
+        'functional.h',
+        'future.h',
+        'hashing.h',
+        'hash_util.h',
+        'int_util.h',
+        'int_util_overflow.h',
+        'io_util.h',
+        'iterator.h',
+        'key_value_metadata.h',
+        'launder.h',
+        'list_util.h',
+        'logger.h',
+        'logging.h',
+        'macros.h',
+        'map.h',
+        'math_constants.h',
+        'memory.h',
+        'mutex.h',
+        'parallel.h',
+        'pcg_random.h',
+        'prefetch.h',
+        'print.h',
+        'queue.h',
+        'range.h',
+        'ree_util.h',
+        'regex.h',
+        'rows_to_batches.h',
+        'simd.h',
+        'small_vector.h',
+        'sort.h',
+        'spaced.h',
+        'span.h',
+        'stopwatch.h',
+        'string_builder.h',
+        'string.h',
+        'task_group.h',
+        'tdigest.h',
+        'test_common.h',
+        'thread_pool.h',
+        'time.h',
+        'tracing.h',
+        'trie.h',
+        'type_fwd.h',
+        'type_traits.h',
+        'ubsan.h',
+        'union_util.h',
+        'unreachable.h',
+        'uri.h',
+        'utf8.h',
+        'value_parsing.h',
+        'vector.h',
+        'visibility.h',
+        'windows_compatibility.h',
+        'windows_fixup.h',
+    ],
+    subdir: 'arrow/util',
+)
+
+utility_test_srcs = [
+    'align_util_test.cc',
+    'atfork_test.cc',
+    'byte_size_test.cc',
+    'byte_stream_split_test.cc',
+    'cache_test.cc',
+    'checked_cast_test.cc',
+    'compression_test.cc',
+    'decimal_test.cc',
+    'float16_test.cc',
+    'fixed_width_test.cc',
+    'formatting_util_test.cc',
+    'key_value_metadata_test.cc',
+    'hashing_test.cc',
+    'int_util_test.cc',
+    'io_util_test.cc',
+    'iterator_test.cc',
+    'list_util_test.cc',
+    'logger_test.cc',
+    'logging_test.cc',
+    'math_test.cc',
+    'queue_test.cc',
+    'range_test.cc',
+    'ree_util_test.cc',
+    'reflection_test.cc',
+    'rows_to_batches_test.cc',
+    'small_vector_test.cc',
+    'span_test.cc',
+    'stl_util_test.cc',
+    'string_test.cc',
+    'tdigest_test.cc',
+    'test_common.cc',
+    'time_test.cc',
+    'tracing_test.cc',
+    'trie_test.cc',
+    'uri_test.cc',
+    'utf8_util_test.cc',
+    'value_parsing_test.cc',
+]
+
+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        utility_test_sources += ['io_util_test.manifest']
+    else
+        utility_test_sources += ['io_util_test.rc']
+    endif
+endif
+
+exc = executable(
+    'arrow-utility-test',
+    sources: utility_test_srcs,
+    dependencies: [arrow_dep, filesystem_dep, gtest_dep, gmock_dep],
+    link_with: [arrow_test_lib],
+    implicit_include_directories: false,
+)
+test('arrow-utility-test', exc)
+
+util_tests = {
+    'arrow-async-utility-test': {
+        'sources': [
+            'async_generator_test.cc',
+            'async_util_test.cc',
+            'test_common.cc',
+        ],
+    },
+    'arrow-bit-utility-test': {
+        'sources': [
+            'bit_block_counter_test.cc',
+            'bit_util_test.cc',
+            'rle_encoding_test.cc',
+        ],
+    },
+    'arrow-threading-utility-test': {
+        'sources': [
+            'cancel_test.cc',
+            'counting_semaphore_test.cc',
+            'future_test.cc',
+            'task_group_test.cc',
+            'test_common.cc',
+            'thread_pool_test.cc',
+        ],
+    },
+    'arrow-crc32-test': {
+        'sources': ['crc32_test.cc'],
+        'dependencies': [filesystem_dep],
+    },
+}
+
+if needs_tests

Review Comment:
   Do we need this?



##########
cpp/src/arrow/util/meson.build:
##########
@@ -92,3 +92,242 @@ configure_file(
     configuration: internal_conf_data,
     format: 'cmake@',
 )
+
+install_headers(
+    [
+        'algorithm.h',
+        'aligned_storage.h',
+        'align_util.h',
+        'async_generator_fwd.h',
+        'async_generator.h',
+        'async_util.h',
+        'base64.h',
+        'basic_decimal.h',
+        'benchmark_util.h',
+        'binary_view_util.h',
+        'bit_block_counter.h',
+        'bitmap_builders.h',
+        'bitmap_generate.h',
+        'bitmap.h',
+        'bitmap_ops.h',
+        'bitmap_reader.h',
+        'bitmap_visit.h',
+        'bitmap_writer.h',
+        'bit_run_reader.h',
+        'bitset_stack.h',
+        'bit_util.h',
+        'bpacking64_default.h',
+        'bpacking_avx2.h',
+        'bpacking_avx512.h',
+        'bpacking_default.h',
+        'bpacking.h',
+        'bpacking_neon.h',
+        'byte_size.h',
+        'cancel.h',
+        'checked_cast.h',
+        'compare.h',
+        'compression.h',
+        'concurrent_map.h',
+        'converter.h',
+        'counting_semaphore.h',
+        'cpu_info.h',
+        'crc32.h',
+        'debug.h',
+        'decimal.h',
+        'delimiting.h',
+        'dict_util.h',
+        'dispatch.h',
+        'double_conversion.h',
+        'endian.h',
+        'float16.h',
+        'formatting.h',
+        'functional.h',
+        'future.h',
+        'hashing.h',
+        'hash_util.h',
+        'int_util.h',
+        'int_util_overflow.h',
+        'io_util.h',
+        'iterator.h',
+        'key_value_metadata.h',
+        'launder.h',
+        'list_util.h',
+        'logger.h',
+        'logging.h',
+        'macros.h',
+        'map.h',
+        'math_constants.h',
+        'memory.h',
+        'mutex.h',
+        'parallel.h',
+        'pcg_random.h',
+        'prefetch.h',
+        'print.h',
+        'queue.h',
+        'range.h',
+        'ree_util.h',
+        'regex.h',
+        'rows_to_batches.h',
+        'simd.h',
+        'small_vector.h',
+        'sort.h',
+        'spaced.h',
+        'span.h',
+        'stopwatch.h',
+        'string_builder.h',
+        'string.h',
+        'task_group.h',
+        'tdigest.h',
+        'test_common.h',
+        'thread_pool.h',
+        'time.h',
+        'tracing.h',
+        'trie.h',
+        'type_fwd.h',
+        'type_traits.h',
+        'ubsan.h',
+        'union_util.h',
+        'unreachable.h',
+        'uri.h',
+        'utf8.h',
+        'value_parsing.h',
+        'vector.h',
+        'visibility.h',
+        'windows_compatibility.h',
+        'windows_fixup.h',
+    ],
+    subdir: 'arrow/util',
+)
+
+utility_test_srcs = [
+    'align_util_test.cc',
+    'atfork_test.cc',
+    'byte_size_test.cc',
+    'byte_stream_split_test.cc',
+    'cache_test.cc',
+    'checked_cast_test.cc',
+    'compression_test.cc',
+    'decimal_test.cc',
+    'float16_test.cc',
+    'fixed_width_test.cc',
+    'formatting_util_test.cc',
+    'key_value_metadata_test.cc',
+    'hashing_test.cc',
+    'int_util_test.cc',
+    'io_util_test.cc',
+    'iterator_test.cc',
+    'list_util_test.cc',
+    'logger_test.cc',
+    'logging_test.cc',
+    'math_test.cc',
+    'queue_test.cc',
+    'range_test.cc',
+    'ree_util_test.cc',
+    'reflection_test.cc',
+    'rows_to_batches_test.cc',
+    'small_vector_test.cc',
+    'span_test.cc',
+    'stl_util_test.cc',
+    'string_test.cc',
+    'tdigest_test.cc',
+    'test_common.cc',
+    'time_test.cc',
+    'tracing_test.cc',
+    'trie_test.cc',
+    'uri_test.cc',
+    'utf8_util_test.cc',
+    'value_parsing_test.cc',
+]
+
+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        utility_test_sources += ['io_util_test.manifest']
+    else
+        utility_test_sources += ['io_util_test.rc']
+    endif
+endif
+
+exc = executable(
+    'arrow-utility-test',
+    sources: utility_test_srcs,
+    dependencies: [arrow_dep, filesystem_dep, gtest_dep, gmock_dep],
+    link_with: [arrow_test_lib],
+    implicit_include_directories: false,
+)
+test('arrow-utility-test', exc)
+
+util_tests = {
+    'arrow-async-utility-test': {
+        'sources': [
+            'async_generator_test.cc',
+            'async_util_test.cc',
+            'test_common.cc',
+        ],
+    },
+    'arrow-bit-utility-test': {
+        'sources': [
+            'bit_block_counter_test.cc',
+            'bit_util_test.cc',
+            'rle_encoding_test.cc',
+        ],
+    },
+    'arrow-threading-utility-test': {
+        'sources': [
+            'cancel_test.cc',
+            'counting_semaphore_test.cc',
+            'future_test.cc',
+            'task_group_test.cc',
+            'test_common.cc',
+            'thread_pool_test.cc',
+        ],
+    },
+    'arrow-crc32-test': {
+        'sources': ['crc32_test.cc'],
+        'dependencies': [filesystem_dep],
+    },
+}
+
+if needs_tests
+    foreach key, val : util_tests
+        exc = executable(
+            key,
+            sources: val['sources'],
+            dependencies: [arrow_test_dep, val.get('dependencies', [])],

Review Comment:
   Do we need `gtest_main_dep` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2730541917

   @github-actions crossbow submit *meson


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2790955636

   Revision: cc1cb9ccab6b65541a496b544285857e3b9f909f
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-16f3047112](https://github.com/ursacomputing/crossbow/branches/all?query=actions-16f3047112)
   
   |Task|Status|
   |----|------|
   |test-conda-cpp-meson|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-16f3047112-github-test-conda-cpp-meson)](https://github.com/ursacomputing/crossbow/actions/runs/14366604414/job/40280938642)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2791734935

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9d9e9a596bf7b3119742c4390f7ec5c88f4cbd30.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/40302704803) has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2733617831

   @github-actions crossbow submit *meson


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #45824:
URL: https://github.com/apache/arrow/pull/45824#issuecomment-2731556803

   @github-actions crossbow submit *meson


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45800: [C++] Implement util configuration in Meson [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #45824:
URL: https://github.com/apache/arrow/pull/45824#discussion_r2002339155


##########
cpp/src/arrow/util/meson.build:
##########
@@ -92,3 +92,242 @@ configure_file(
     configuration: internal_conf_data,
     format: 'cmake@',
 )
+
+install_headers(
+    [
+        'algorithm.h',
+        'aligned_storage.h',
+        'align_util.h',
+        'async_generator_fwd.h',
+        'async_generator.h',
+        'async_util.h',
+        'base64.h',
+        'basic_decimal.h',
+        'benchmark_util.h',
+        'binary_view_util.h',
+        'bit_block_counter.h',
+        'bitmap_builders.h',
+        'bitmap_generate.h',
+        'bitmap.h',
+        'bitmap_ops.h',
+        'bitmap_reader.h',
+        'bitmap_visit.h',
+        'bitmap_writer.h',
+        'bit_run_reader.h',
+        'bitset_stack.h',
+        'bit_util.h',
+        'bpacking64_default.h',
+        'bpacking_avx2.h',
+        'bpacking_avx512.h',
+        'bpacking_default.h',
+        'bpacking.h',
+        'bpacking_neon.h',
+        'byte_size.h',
+        'cancel.h',
+        'checked_cast.h',
+        'compare.h',
+        'compression.h',
+        'concurrent_map.h',
+        'converter.h',
+        'counting_semaphore.h',
+        'cpu_info.h',
+        'crc32.h',
+        'debug.h',
+        'decimal.h',
+        'delimiting.h',
+        'dict_util.h',
+        'dispatch.h',
+        'double_conversion.h',
+        'endian.h',
+        'float16.h',
+        'formatting.h',
+        'functional.h',
+        'future.h',
+        'hashing.h',
+        'hash_util.h',
+        'int_util.h',
+        'int_util_overflow.h',
+        'io_util.h',
+        'iterator.h',
+        'key_value_metadata.h',
+        'launder.h',
+        'list_util.h',
+        'logger.h',
+        'logging.h',
+        'macros.h',
+        'map.h',
+        'math_constants.h',
+        'memory.h',
+        'mutex.h',
+        'parallel.h',
+        'pcg_random.h',
+        'prefetch.h',
+        'print.h',
+        'queue.h',
+        'range.h',
+        'ree_util.h',
+        'regex.h',
+        'rows_to_batches.h',
+        'simd.h',
+        'small_vector.h',
+        'sort.h',
+        'spaced.h',
+        'span.h',
+        'stopwatch.h',
+        'string_builder.h',
+        'string.h',
+        'task_group.h',
+        'tdigest.h',
+        'test_common.h',
+        'thread_pool.h',
+        'time.h',
+        'tracing.h',
+        'trie.h',
+        'type_fwd.h',
+        'type_traits.h',
+        'ubsan.h',
+        'union_util.h',
+        'unreachable.h',
+        'uri.h',
+        'utf8.h',
+        'value_parsing.h',
+        'vector.h',
+        'visibility.h',
+        'windows_compatibility.h',
+        'windows_fixup.h',
+    ],
+    subdir: 'arrow/util',
+)
+
+utility_test_srcs = [
+    'align_util_test.cc',
+    'atfork_test.cc',
+    'byte_size_test.cc',
+    'byte_stream_split_test.cc',
+    'cache_test.cc',
+    'checked_cast_test.cc',
+    'compression_test.cc',
+    'decimal_test.cc',
+    'float16_test.cc',
+    'fixed_width_test.cc',
+    'formatting_util_test.cc',
+    'key_value_metadata_test.cc',
+    'hashing_test.cc',
+    'int_util_test.cc',
+    'io_util_test.cc',
+    'iterator_test.cc',
+    'list_util_test.cc',
+    'logger_test.cc',
+    'logging_test.cc',
+    'math_test.cc',
+    'queue_test.cc',
+    'range_test.cc',
+    'ree_util_test.cc',
+    'reflection_test.cc',
+    'rows_to_batches_test.cc',
+    'small_vector_test.cc',
+    'span_test.cc',
+    'stl_util_test.cc',
+    'string_test.cc',
+    'tdigest_test.cc',
+    'test_common.cc',
+    'time_test.cc',
+    'tracing_test.cc',
+    'trie_test.cc',
+    'uri_test.cc',
+    'utf8_util_test.cc',
+    'value_parsing_test.cc',
+]
+
+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        utility_test_sources += ['io_util_test.manifest']
+    else
+        utility_test_sources += ['io_util_test.rc']
+    endif
+endif
+
+exc = executable(
+    'arrow-utility-test',
+    sources: utility_test_srcs,
+    dependencies: [arrow_dep, filesystem_dep, gtest_dep, gmock_dep],
+    link_with: [arrow_test_lib],
+    implicit_include_directories: false,
+)
+test('arrow-utility-test', exc)
+
+util_tests = {
+    'arrow-async-utility-test': {
+        'sources': [
+            'async_generator_test.cc',
+            'async_util_test.cc',
+            'test_common.cc',
+        ],
+    },
+    'arrow-bit-utility-test': {
+        'sources': [
+            'bit_block_counter_test.cc',
+            'bit_util_test.cc',
+            'rle_encoding_test.cc',
+        ],
+    },
+    'arrow-threading-utility-test': {
+        'sources': [
+            'cancel_test.cc',
+            'counting_semaphore_test.cc',
+            'future_test.cc',
+            'task_group_test.cc',
+            'test_common.cc',
+            'thread_pool_test.cc',
+        ],
+    },
+    'arrow-crc32-test': {
+        'sources': ['crc32_test.cc'],
+        'dependencies': [filesystem_dep],
+    },
+}
+
+if needs_tests

Review Comment:
   We do. I think there are ways to improve the terminology, but technically the `arrow_test_dep` becomes a disabler only if `needs_testing` is false. It is possible for `needs_tests` to be false while `needs_testing` is true. Without this extra condition these tests would build when `-Dtests=false` and `-Dtesting=true`
   
   I do wonder if it wouldn't be better to have an `arrow_test_dep` and separately an `arrow_testing_dep`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org