You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/07/26 02:29:11 UTC
[GitHub] [mynewt-core] ncasaril opened a new pull request #2643: hw/mcu/nrf52: Accept NULL txbuf in hal_spi_txrx by transmitting 0xFF
ncasaril opened a new pull request #2643:
URL: https://github.com/apache/mynewt-core/pull/2643
The new bus_spi_write_read function in the bus driver doesn't handle write_reads with a combined length of more than 16 without passing NULL as the txbuf parameter:
https://github.com/apache/mynewt-core/blob/595a074aec88de2dc50688990debedb3c228e89c/hw/bus/drivers/spi_hal/src/spi_hal.c#L242
This change allows nrf52:hal_spi_txrx to handle a NULL txbuf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer commented on pull request #2643: hw/mcu/nrf52: Accept NULL txbuf in hal_spi_txrx by transmitting 0xFF
Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #2643:
URL: https://github.com/apache/mynewt-core/pull/2643#issuecomment-886456440
@ncasaril I'm not opposed to your change, but accepting it would make one MCU implementation ready to work with bus_node_write_read_transact while others would still fail.
We could change them all of course but maybe this solution #2644 would work for you instead.
Could you please check it it solves the issue (I will verify that it works if you don't have time but it will take some time).
Thank you for your involvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] ncasaril commented on pull request #2643: hw/mcu/nrf52: Accept NULL txbuf in hal_spi_txrx by transmitting 0xFF
Posted by GitBox <gi...@apache.org>.
ncasaril commented on pull request #2643:
URL: https://github.com/apache/mynewt-core/pull/2643#issuecomment-886501412
Closing as #2644 solves this problem for all mcus whilst my fix only addresses nrf52.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] ncasaril closed pull request #2643: hw/mcu/nrf52: Accept NULL txbuf in hal_spi_txrx by transmitting 0xFF
Posted by GitBox <gi...@apache.org>.
ncasaril closed pull request #2643:
URL: https://github.com/apache/mynewt-core/pull/2643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org