You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/03 08:50:08 UTC
[GitHub] [shardingsphere] cherrylzhao opened a new pull request #5417: use Junit @Rule to watch failed test case
cherrylzhao opened a new pull request #5417:
URL: https://github.com/apache/shardingsphere/pull/5417
print out the test description when failed execute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #5417: use Junit @Rule to watch failed test case
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5417:
URL: https://github.com/apache/shardingsphere/pull/5417#issuecomment-623079167
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=h1) Report
> Merging [#5417](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/68ee1f8bef17fb9a43f7d4ca0a59a926a94b5722&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5417 +/- ##
=========================================
Coverage 53.87% 53.87%
Complexity 419 419
=========================================
Files 1161 1161
Lines 20857 20857
Branches 3772 3772
=========================================
Hits 11236 11236
Misses 8905 8905
Partials 716 716
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=footer). Last update [68ee1f8...5503e4f](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #5417: use Junit @Rule to watch failed test case
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #5417:
URL: https://github.com/apache/shardingsphere/pull/5417#issuecomment-623782662
Using assertThat and fail to handle error message of assertion may better than using @rule and TestWatcher.
we should just keep consistent way for junit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #5417: use Junit @Rule to watch failed test case
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #5417:
URL: https://github.com/apache/shardingsphere/pull/5417#issuecomment-623079167
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=h1) Report
> Merging [#5417](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/68ee1f8bef17fb9a43f7d4ca0a59a926a94b5722&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5417 +/- ##
============================================
- Coverage 53.87% 53.83% -0.04%
Complexity 419 419
============================================
Files 1161 1165 +4
Lines 20857 20873 +16
Branches 3772 3769 -3
============================================
+ Hits 11236 11238 +2
- Misses 8905 8919 +14
Partials 716 716
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/shardingsphere/core/log/ConfigurationLogger.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9sb2cvQ29uZmlndXJhdGlvbkxvZ2dlci5qYXZh) | `54.05% <0.00%> (-6.56%)` | `0.00% <0.00%> (ø%)` | |
| [...re/shardingjdbc/api/ShardingDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9hcGkvU2hhcmRpbmdEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `50.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ngjdbc/api/yaml/YamlShardingDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9hcGkveWFtbC9ZYW1sU2hhcmRpbmdEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `25.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...rdingproxy/backend/schema/impl/ShardingSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9pbXBsL1NoYXJkaW5nU2NoZW1hLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...on/api/OrchestrationShardingDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2FwaS9PcmNoZXN0cmF0aW9uU2hhcmRpbmdEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...rdingjdbc/spring/boot/SpringBootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLWJvb3Qtc3RhcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9ib290L1NwcmluZ0Jvb3RDb25maWd1cmF0aW9uLmphdmE=) | `84.84% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...al/datasource/OrchestrationShardingDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2ludGVybmFsL2RhdGFzb3VyY2UvT3JjaGVzdHJhdGlvblNoYXJkaW5nRGF0YVNvdXJjZS5qYXZh) | `85.10% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...bc/spring/datasource/SpringShardingDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9kYXRhc291cmNlL1NwcmluZ1NoYXJkaW5nRGF0YVNvdXJjZS5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...e/configcenter/listener/SchemaChangedListener.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9TY2hlbWFDaGFuZ2VkTGlzdGVuZXIuamF2YQ==) | `72.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ing/boot/OrchestrationSpringBootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtb3JjaGVzdHJhdGlvbi1zcHJpbmcvc2hhcmRpbmctamRiYy1vcmNoZXN0cmF0aW9uLXNwcmluZy1ib290LXN0YXJ0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL3NwcmluZy9ib290L09yY2hlc3RyYXRpb25TcHJpbmdCb290Q29uZmlndXJhdGlvbi5qYXZh) | `88.37% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [13 more](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=footer). Last update [68ee1f8...aaa3bc9](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #5417: use Junit @Rule to watch failed test case
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5417:
URL: https://github.com/apache/shardingsphere/pull/5417#issuecomment-623079417
## Pull Request Test Coverage Report for [Build 11414](https://coveralls.io/builds/30528932)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **44** unchanged lines in **10** files lost coverage.
* Overall coverage decreased (**-0.03%**) to **57.332%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/ShardingDataSourceFactory.java](https://coveralls.io/builds/30528932/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fapi%2FShardingDataSourceFactory.java#L53) | 1 | 50.0% |
| [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/30528932/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L193) | 1 | 95.35% |
| [sharding-spring/sharding-jdbc-spring/sharding-jdbc-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/spring/boot/SpringBootConfiguration.java](https://coveralls.io/builds/30528932/source?filename=sharding-spring%2Fsharding-jdbc-spring%2Fsharding-jdbc-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fspring%2Fboot%2FSpringBootConfiguration.java#L162) | 1 | 87.88% |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/internal/datasource/OrchestrationShardingDataSource.java](https://coveralls.io/builds/30528932/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Finternal%2Fdatasource%2FOrchestrationShardingDataSource.java#L94) | 2 | 89.36% |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/OrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/30528932/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2FOrchestrationShardingDataSourceFactory.java#L53) | 4 | 0% |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/30528932/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L87) | 4 | 62.5% |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/listener/SchemaChangedListener.java](https://coveralls.io/builds/30528932/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2Flistener%2FSchemaChangedListener.java#L78) | 4 | 82.0% |
| [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/yaml/YamlShardingDataSourceFactory.java](https://coveralls.io/builds/30528932/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fapi%2Fyaml%2FYamlShardingDataSourceFactory.java#L51) | 8 | 25.0% |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/log/ConfigurationLogger.java](https://coveralls.io/builds/30528932/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Flog%2FConfigurationLogger.java#L54) | 9 | 72.97% |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/30528932/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L52) | 10 | 0% |
<!-- | **Total:** | **44** | | -->
| Totals | [](https://coveralls.io/builds/30528932) |
| :-- | --: |
| Change from base [Build 11407](https://coveralls.io/builds/30517362): | -0.03% |
| Covered Lines: | 11967 |
| Relevant Lines: | 20873 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5417: use Junit @Rule to watch failed test case
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5417:
URL: https://github.com/apache/shardingsphere/pull/5417#issuecomment-623079417
## Pull Request Test Coverage Report for [Build 11408](https://coveralls.io/builds/30518741)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.367%**
---
| Totals | [](https://coveralls.io/builds/30518741) |
| :-- | --: |
| Change from base [Build 11407](https://coveralls.io/builds/30517362): | 0.0% |
| Covered Lines: | 11965 |
| Relevant Lines: | 20857 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #5417: use Junit @Rule to watch failed test case
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #5417:
URL: https://github.com/apache/shardingsphere/pull/5417#issuecomment-623079167
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=h1) Report
> Merging [#5417](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/68ee1f8bef17fb9a43f7d4ca0a59a926a94b5722&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5417 +/- ##
============================================
- Coverage 53.87% 53.86% -0.01%
Complexity 419 419
============================================
Files 1161 1169 +8
Lines 20857 21050 +193
Branches 3772 3834 +62
============================================
+ Hits 11236 11339 +103
- Misses 8905 8991 +86
- Partials 716 720 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...re/shardingjdbc/api/ShardingDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9hcGkvU2hhcmRpbmdEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `50.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...rdingproxy/backend/schema/impl/ShardingSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9pbXBsL1NoYXJkaW5nU2NoZW1hLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...on/api/OrchestrationShardingDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2FwaS9PcmNoZXN0cmF0aW9uU2hhcmRpbmdEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...bc/spring/datasource/SpringShardingDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9kYXRhc291cmNlL1NwcmluZ1NoYXJkaW5nRGF0YVNvdXJjZS5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...rlying/common/rule/ShardingSphereRulesBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL3J1bGUvU2hhcmRpbmdTcGhlcmVSdWxlc0J1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...phere/underlying/common/datanode/DataNodeUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2RhdGFub2RlL0RhdGFOb2RlVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...hardingsphere/encrypt/rule/EncryptRuleBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcnVsZS9FbmNyeXB0UnVsZUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ngsphere/underlying/common/datanode/DataNodes.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2RhdGFub2RlL0RhdGFOb2Rlcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../shardingsphere/core/rule/ShardingRuleBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ingsphere/underlying/common/datanode/DataNode.java](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2RhdGFub2RlL0RhdGFOb2RlLmphdmE=) | `87.50% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [9 more](https://codecov.io/gh/apache/shardingsphere/pull/5417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=footer). Last update [68ee1f8...5503e4f](https://codecov.io/gh/apache/shardingsphere/pull/5417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cherrylzhao commented on pull request #5417: use Junit @Rule to watch failed test case
Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on pull request #5417:
URL: https://github.com/apache/shardingsphere/pull/5417#issuecomment-623240569
after rewrite AssertError, case context can be appended as we set a description in assertThat, image is as below
```
java.lang.AssertionError: assertExecuteUpdate[tbl -> H2 -> Literal -> 22:int, 1:int, insert:String -> insert_for_order_1.xml -> INSERT INTO t_order (order_id, user_id, status) VALUES (?, ?, ?)](org.apache.shardingsphere.dbtest.engine.dml.GeneralDMLIT)
Expected: is "1"
but: was "1001"
Expected :1
Actual :1001
<Click to see difference>
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:956)
at org.junit.Assert.assertThat(Assert.java:923)
at org.apache.shardingsphere.dbtest.engine.dml.BaseDMLIT.assertRows(BaseDMLIT.java:126)
at org.apache.shardingsphere.dbtest.engine.dml.BaseDMLIT.assertDataSet(BaseDMLIT.java:104)
at org.apache.shardingsphere.dbtest.engine.dml.BaseDMLIT.assertDataSet(BaseDMLIT.java:96)
at org.apache.shardingsphere.dbtest.engine.dml.GeneralDMLIT.assertExecuteUpdate(GeneralDMLIT.java:72)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.apache.shardingsphere.dbtest.engine.util.IntegrateTestWatcher$1.evaluate(IntegrateTestWatcher.java:39)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #5417: use Junit @Rule to watch failed test case
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5417:
URL: https://github.com/apache/shardingsphere/pull/5417#issuecomment-623079417
## Pull Request Test Coverage Report for [Build 11413](https://coveralls.io/builds/30528468)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **44** unchanged lines in **10** files lost coverage.
* Overall coverage decreased (**-0.03%**) to **57.332%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/ShardingDataSourceFactory.java](https://coveralls.io/builds/30528468/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fapi%2FShardingDataSourceFactory.java#L53) | 1 | 50.0% |
| [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/30528468/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L193) | 1 | 95.35% |
| [sharding-spring/sharding-jdbc-spring/sharding-jdbc-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/spring/boot/SpringBootConfiguration.java](https://coveralls.io/builds/30528468/source?filename=sharding-spring%2Fsharding-jdbc-spring%2Fsharding-jdbc-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fspring%2Fboot%2FSpringBootConfiguration.java#L162) | 1 | 87.88% |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/internal/datasource/OrchestrationShardingDataSource.java](https://coveralls.io/builds/30528468/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Finternal%2Fdatasource%2FOrchestrationShardingDataSource.java#L94) | 2 | 89.36% |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/OrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/30528468/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2FOrchestrationShardingDataSourceFactory.java#L53) | 4 | 0% |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/30528468/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L87) | 4 | 62.5% |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/listener/SchemaChangedListener.java](https://coveralls.io/builds/30528468/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2Flistener%2FSchemaChangedListener.java#L78) | 4 | 82.0% |
| [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/yaml/YamlShardingDataSourceFactory.java](https://coveralls.io/builds/30528468/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fapi%2Fyaml%2FYamlShardingDataSourceFactory.java#L51) | 8 | 25.0% |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/log/ConfigurationLogger.java](https://coveralls.io/builds/30528468/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Flog%2FConfigurationLogger.java#L54) | 9 | 72.97% |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/30528468/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L52) | 10 | 0% |
<!-- | **Total:** | **44** | | -->
| Totals | [](https://coveralls.io/builds/30528468) |
| :-- | --: |
| Change from base [Build 11407](https://coveralls.io/builds/30517362): | -0.03% |
| Covered Lines: | 11967 |
| Relevant Lines: | 20873 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cherrylzhao commented on pull request #5417: use Junit @Rule to watch failed test case
Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on pull request #5417:
URL: https://github.com/apache/shardingsphere/pull/5417#issuecomment-623090653
close it currently to keep consistency with SQLCaseAssertContext
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org