You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Paul Spencer (JIRA)" <ji...@codehaus.org> on 2007/07/11 20:19:13 UTC
[jira] Created: (MCHANGES-82) Issue Management URL not ending in a
'/' result in an incorrect issue link on the change report.
Issue Management URL not ending in a '/' result in an incorrect issue link on the change report.
------------------------------------------------------------------------------------------------
Key: MCHANGES-82
URL: http://jira.codehaus.org/browse/MCHANGES-82
Project: Maven 2.x Changes Plugin
Issue Type: Bug
Components: changes-report
Affects Versions: 2.0-beta-2
Reporter: Paul Spencer
Issue Management URL not ending in a '/' result in an incorrect issue link on the change report. If the Url is "http://issues.foo.com", then the link to issue 1 is "http://ViewIssue.jspa?key=1". This problem is made worse by the issue management example in http://maven.apache.org/pom.html. In that example the url is <url>http://127.0.0.1/bugzilla</url>.
I believe the source of the problem is in ChangesReportGenerator.parseIssueLink(). This method assumes the URL will end in a "/", instead of checking for an ending "/"
String url = this.url.substring( 0, this.url.lastIndexOf( "/" ) );
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-82) Issue Management URL not ending in
a '/' result in an incorrect issue link on the change report.
Posted by "Paul Spencer (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102382 ]
Paul Spencer commented on MCHANGES-82:
--------------------------------------
> Are you using a changes.xml file to produce the report?
Yes, I am using changes.xml
> What does it look like?
<?xml version="1.0" encoding="UTF-8"?>
<document>
<properties>
<title>Changes</title>
</properties>
<body>
<release version="1.0.4" date="IN CVS" description="Bugfix">
<action dev="paul" type="fix" issue="2">
Selected list will not change as when group
changes.
</action>
</release>
</body>
</document>
> How is this problem made worse by the example that you mention?
It is documenting how to experience this issue.
Please note: I have no reason to believe the example is incorrect. I believe the issue is in the changes plugin and it's usage of the URL.
> Can you please supply a full issue management element that exemplifies this issue.
The following will produce an incorrect URL in the changes report
<issueManagement>
<system>Bugzilla</system>
<url>http://127.0.0.1/bugzilla</url>
</issueManagement>
The following will produce the correct URL in the changes report
<issueManagement>
<system>Bugzilla</system>
<url>http://127.0.0.1/bugzilla/</url>
</issueManagement>
> Issue Management URL not ending in a '/' result in an incorrect issue link on the change report.
> ------------------------------------------------------------------------------------------------
>
> Key: MCHANGES-82
> URL: http://jira.codehaus.org/browse/MCHANGES-82
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Affects Versions: 2.0-beta-2
> Reporter: Paul Spencer
>
> Issue Management URL not ending in a '/' result in an incorrect issue link on the change report. If the Url is "http://issues.foo.com", then the link to issue 1 is "http://ViewIssue.jspa?key=1". This problem is made worse by the issue management example in http://maven.apache.org/pom.html. In that example the url is <url>http://127.0.0.1/bugzilla</url>.
> I believe the source of the problem is in ChangesReportGenerator.parseIssueLink(). This method assumes the URL will end in a "/", instead of checking for an ending "/"
> String url = this.url.substring( 0, this.url.lastIndexOf( "/" ) );
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHANGES-82) Issue Management URL not ending in a
'/' result in an incorrect issue link on the change report.
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MCHANGES-82.
-----------------------------------
Assignee: Dennis Lundberg
Resolution: Won't Fix
I have updated the documentation to explain how this works. The example at the pom page has also been updated with a trailing slash.
> Issue Management URL not ending in a '/' result in an incorrect issue link on the change report.
> ------------------------------------------------------------------------------------------------
>
> Key: MCHANGES-82
> URL: http://jira.codehaus.org/browse/MCHANGES-82
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Affects Versions: 2.0-beta-2
> Reporter: Paul Spencer
> Assignee: Dennis Lundberg
>
> Issue Management URL not ending in a '/' result in an incorrect issue link on the change report. If the Url is "http://issues.foo.com", then the link to issue 1 is "http://ViewIssue.jspa?key=1". This problem is made worse by the issue management example in http://maven.apache.org/pom.html. In that example the url is <url>http://127.0.0.1/bugzilla</url>.
> I believe the source of the problem is in ChangesReportGenerator.parseIssueLink(). This method assumes the URL will end in a "/", instead of checking for an ending "/"
> String url = this.url.substring( 0, this.url.lastIndexOf( "/" ) );
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-82) Issue Management URL not ending in
a '/' result in an incorrect issue link on the change report.
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102234 ]
Dennis Lundberg commented on MCHANGES-82:
-----------------------------------------
Are you using a changes.xml file to produce the report? What does it look like?
How is this problem made worse by the example that you mention?
Can you please supply a full issue management element that exemplifies this issue.
> Issue Management URL not ending in a '/' result in an incorrect issue link on the change report.
> ------------------------------------------------------------------------------------------------
>
> Key: MCHANGES-82
> URL: http://jira.codehaus.org/browse/MCHANGES-82
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Affects Versions: 2.0-beta-2
> Reporter: Paul Spencer
>
> Issue Management URL not ending in a '/' result in an incorrect issue link on the change report. If the Url is "http://issues.foo.com", then the link to issue 1 is "http://ViewIssue.jspa?key=1". This problem is made worse by the issue management example in http://maven.apache.org/pom.html. In that example the url is <url>http://127.0.0.1/bugzilla</url>.
> I believe the source of the problem is in ChangesReportGenerator.parseIssueLink(). This method assumes the URL will end in a "/", instead of checking for an ending "/"
> String url = this.url.substring( 0, this.url.lastIndexOf( "/" ) );
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira