You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/10/06 02:36:07 UTC
[kudu-CR] KUDU-1610. Bump trace viewer to new upstream version
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4642
to review the following change.
Change subject: KUDU-1610. Bump trace viewer to new upstream version
......................................................................
KUDU-1610. Bump trace viewer to new upstream version
This bumps to a new build of trace-viewer. The upstream work was
reasonably substantial since trace-viewer has been moved into a new
'Catapult' project run by Google. But, I fooled around with it until it
seems to work again on my newly-updated Chrome.
Change-Id: I69cf7c5615165c6374e999ac22b89f876ff7140d
---
M thirdparty/vars.sh
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/4642/1
--
To view, visit http://gerrit.cloudera.org:8080/4642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69cf7c5615165c6374e999ac22b89f876ff7140d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
[kudu-CR] KUDU-1610. Bump trace viewer to new upstream version
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1610. Bump trace viewer to new upstream version
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69cf7c5615165c6374e999ac22b89f876ff7140d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1610. Bump trace viewer to new upstream version
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1610. Bump trace viewer to new upstream version
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4642/1/thirdparty/vars.sh
File thirdparty/vars.sh:
Line 159: # The source can be found at https://github.com/cloudera/catapult
You may want to call out the kudu branch specifically.
--
To view, visit http://gerrit.cloudera.org:8080/4642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69cf7c5615165c6374e999ac22b89f876ff7140d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1610. Bump trace viewer to new upstream version
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1610. Bump trace viewer to new upstream version
......................................................................
KUDU-1610. Bump trace viewer to new upstream version
This bumps to a new build of trace-viewer. The upstream work was
reasonably substantial since trace-viewer has been moved into a new
'Catapult' project run by Google. But, I fooled around with it until it
seems to work again on my newly-updated Chrome.
Change-Id: I69cf7c5615165c6374e999ac22b89f876ff7140d
Reviewed-on: http://gerrit.cloudera.org:8080/4642
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M thirdparty/vars.sh
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69cf7c5615165c6374e999ac22b89f876ff7140d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1610. Bump trace viewer to new upstream version
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4642
to look at the new patch set (#2).
Change subject: KUDU-1610. Bump trace viewer to new upstream version
......................................................................
KUDU-1610. Bump trace viewer to new upstream version
This bumps to a new build of trace-viewer. The upstream work was
reasonably substantial since trace-viewer has been moved into a new
'Catapult' project run by Google. But, I fooled around with it until it
seems to work again on my newly-updated Chrome.
Change-Id: I69cf7c5615165c6374e999ac22b89f876ff7140d
---
M thirdparty/vars.sh
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/4642/2
--
To view, visit http://gerrit.cloudera.org:8080/4642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69cf7c5615165c6374e999ac22b89f876ff7140d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins