You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/10 18:57:59 UTC
[GitHub] [incubator-superset] graceguo-supercat commented on issue #7248:
Fix refresh frequency
graceguo-supercat commented on issue #7248: Fix refresh frequency
URL: https://github.com/apache/incubator-superset/pull/7248#issuecomment-481819753
@betodealmeida this PR makes auto-refresh interval only at edit mode:
<img width="776" alt="Screen Shot 2019-04-10 at 11 49 22 AM" src="https://user-images.githubusercontent.com/27990562/55905416-bad86580-5b86-11e9-9b54-24009edd15be.png">
For Superset dashboard, only owner can enable edit mode. check `dash_edit_perm`.
As dashboard viewer (not owner), he should be able to adjust auto-refresh interval at his visit. Just like dashboard filter, any user can apply filter to see different results, but won't affect the original dashboard setting. After this PR, viewer can't have auto-refresh interval anymore.
I think we need to make auto refresh interval choice available for all dashboard viewer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org