You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/30 23:22:59 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #12981: [BEAM-10435] Add LOOPBACK mode Java ValidatesRunner test suite for ULR

tvalentyn commented on a change in pull request #12981:
URL: https://github.com/apache/beam/pull/12981#discussion_r497854011



##########
File path: runners/portability/java/build.gradle
##########
@@ -82,8 +87,15 @@ void execBackgroundInVirtualenv(String... args) {
   proc.waitFor();
 }
 
-task startLocalJobService {
+task installBeamPythonInVirtualenv {
   dependsOn setupVirtualenv
+  doLast {
+    execInVirtualenv "pip", "install", "-e", "."

Review comment:
       We had issues in the past with installing SDK in developer mode in tests. Not sure if this still relevant. If you want to install from tarball, you can consider using https://github.com/apache/beam/blob/943a948e5a6dd7ec81760359c198c3fb2b3c3dcd/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L1999
   
   (nameing is for that target is not very mnemonic..)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org